- 14 Oct, 2016 7 commits
-
-
1. HttpMediaDrmCallback.executeProvisionRequest needs to specify an empty byte[], else we do a GET instead of a POST. 2. Content-Type should not be set when making the provision request, since there's no body. 3. DataSource implementations must correctly handle a non-null body with zero length. CronetDataSource was not handling this case. DefaultHttpDataSource was, but made a code modification to make it a little clearer. OkHttpDataSource seems to handle the case correctly, and it doens't look like the code can be made clearer. Issue #1925 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=136042641
olly committed -
Note that actually handling CEA-708 is not yet implemented, and so this is a no-op change from a behavior point of view. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=136038439
olly committed -
The method track(int id) currently has different behaviours across implementations. This CL maps ids to track outputs, which means that successive calls with the same id will return the same TrackOutput instance. Also fixes TsExtractor inconsistent behavior after a seek. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=136026721
aquilescanta committed -
Issue:#1782 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=136025847
aquilescanta committed -
A blocking call is necessary where we want to guarantee that the player wont access the surface after the method call has returned. We currently only do this for the case: Surface->Null But we should also do it for the case: SurfaceA->SurfaceB Since the caller may reasonably do something like destroy SurfaceA immediately after it's been replaced. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135921296
olly committed -
This allows the injectable reader factory to be a stateless factory, allows the seeking to be consistent and will allow multiple CC channel support later on. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135909712
aquilescanta committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135819142
olly committed
-
- 11 Oct, 2016 13 commits
-
-
Issue: #1907 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135798950
olly committed -
- Fix issue in ExoPlayerImpl where the timeline was null'd but onTimelineChanged was not fired. - Add the ability to not reset the timeline. This is useful for retries where you know the timeline will be the same as it was previously. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135797577
olly committed -
playingPeriodHolder can be null in the case that the first period is still being prepared. We need to make sure we release the period that's being prepared in such cases, which is loadingPeriodHolder. Issue: #1914 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135793472
olly committed -
- Move nearly all logic onto the calling thread (i.e. the thread calling open/read/close), to make threading correctness more obvious. - Document which variables are read/written from which thread, and why the call sequences are safe. - Fix thread safety issue that I think could probably cause data corruption in the case of a read timeout followed by another request into the DataSource. Also: - Relaxed content length checking to be consistent with the other http DataSource implementations, and avoided parsing the headers where they're not used. - Fixed missing generics in CronetDataSourceFactory. - Added TODO to work with servers that don't support partial range requests. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135702217
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135700280
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135692709
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135682130
eguven committed -
- Make sure no events are posted on PlaybackControlView if it's not attached to a window. This can cause leaks. The target hide time is recorded if necessary and processed when the view is re-attached. - Deduplicated PlaybackControlView.VisibilityListener invocations. - Fixed timeouts to be more intuitive (I think). - Fixed initial visibility of PlaybackControlView when used as part of SimpleExoPlayerView. - Made some more attributes configurable from layout xml. Issue: #1908 Issue: #1919 Issue: #1923 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135679988
olly committed -
This is a minor cleanup. The main thing it fixes is that the "Inconsistent headers" and "Unexpected Content-Range" log messages were printing List<String> objects, rather than the actual headers they are supposed to print. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135378074
olly committed -
The access in fillCurrentRequestPostBody wasn't protected with synchronization. Furthermore, just synchronizing it wouldn't be sufficient, since what we really need to check is whether the Content-Type header has been added to the UrlRequest.Builder. The contents of requestProperties may have changed between the headers being added to UrlRequest.Builder and the call to fillCurrentRequestPostBody. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135376904
olly committed -
- Allow null Content-Type in response headers. - Inline validateResponse, just because it makes it clearer what thread it's being executed on when inlined. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135375063
olly committed -
- Fix bug in getCurrentRequestStatus where we weren't blocking on the condition variable. - Make methods static where possible. - Clean up getUri implementation. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135373586
olly committed -
This change is a no-op reodering, as a precursor to further cleanup. The public methods are grouped by the class/interface they implement. The private methods are ordered with things that will become static in a subsequent change at the bottom. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135372629
olly committed
-
- 09 Oct, 2016 1 commit
-
-
Use Call.Factory instead of OkHttpClient
ojw28 committed
-
- 07 Oct, 2016 1 commit
-
-
This allows using alternate implementation of an HTTP client. We can use OkHttpClient as before as it implements Call.Factory.
Satoshi Matsumoto committed
-
- 06 Oct, 2016 2 commits
-
-
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135353593
olly committed -
Without this developers which reuse a SurfaceHolder with multiple instances of SimpleExoPlayer need to call simpleExoPlayer.setVideoSurfaceHolder(null) to get the SimpleExoPlayer.ComponentListener removed from the surface holder. If they don't, the component listener is still registered and as a member class leaks an instance of simpleExoPlayer. Issue #1855 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135292439
[]inger committed
-
- 05 Oct, 2016 7 commits
-
-
Playback would fail if a renderer is toggled from consuming from one child to another in a single step. Issue: #1900 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135270356
olly committed -
https://github.com/google/ExoPlayer/issues/1827 Three different modes available: fit (default), fixed_width, fixed_height Developers need to use wrap_content for the dimension which is not fixed: app:resize_mode="fixed_width" android:layout_width="320dp" android:layout_height="wrap_content" ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135264861
[]inger committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135260806
olly committed -
Configuration of retry currently fails if all of the following are true, which is highly unlikely but does occur in the ref'd issue. 1. Loading/extraction fails 2. Neither length of stream of a seek map is known 3. At least one track has been output by the extractor Issue: #1899 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135228687
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135215320
olly committed -
Issue: #1895 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135211179
olly committed -
Ref: https://blog.bintray.com/2015/02/09/android-studio-migration-from-maven-central-to-jcenter/ ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135211072
olly committed
-
- 04 Oct, 2016 7 commits
-
-
- Enfroce read returns 0 if readLength==0 everywhere. - Fixes and simplifications for CronetDataSource. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135138232
olly committed -
- Make read return 0 if readLength==0 - Return RESULT_END_OF_INPUT properly in the case that bytesRemaining is unset (this was broken previously, but only applies for assets > 2^31 bytes, so it's unlikely anyone ever hit this issue) ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135136541
olly committed -
It'll be a TODO to clean up some of the commonality between publishing this and the core library (e.g. the version number should really be spec'd in one place only). Just getting this submitted for now so that we don't lose track of how I created https://bintray.com/google/exoplayer/extension-okhttp ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135102459
olly committed -
Issue:#1875 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135100986
aquilescanta committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135100455
olly committed -
- Correctly null out streams[j] in the case that a renderer is being disabled. - Read discontinuities from all children, not just enabled ones. This fixes a failure when reading a discontinuity with all renderers disabled. - Add in some assertions to make incorrect stream selection failures obvious and immediate. - Relocate subtitles so they're above the shutter (needed so they continue to be visible when video is disabled but text is still enabled). Issue: #1854 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135089944
olly committed -
This CL adds support for initialization segments in HLS. This is required mainly for(but not limited to) usage of fMP4. The fMP4 support only consists in creating the required extractor if the extension is .mp4, provided the initialization segment is correctly loaded and passed to the extractor. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=134997636
aquilescanta committed
-
- 03 Oct, 2016 2 commits
-
-
This prevents a large amount of memory from being held in the case that a player instance is released, but the application is holding dangling references to the player that are preventing it from being garbage collected. Issue: #1855 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=134992945
olly committed -
- Fix NPE issue in SingleSampleMediaPeriod. - Delay handling of EOS in TextRenderer until the last subtitle is fully played out. Issue: #1882 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=134979286
olly committed
-