- 28 Feb, 2020 9 commits
-
-
This is more accurate since it's just a placeholder and none of the values is provided by the media. It also allows to fix a problem in ClippingMediaSource where we couldn't detect a clipping error because we didn't know if the timeline is a placeholder or not. Issue:#5924 PiperOrigin-RevId: 297813606
tonihei committed -
This ensures all player interactions in tests automatically verify that timestamps calculations are done correctly. PiperOrigin-RevId: 297813324
tonihei committed -
This while loop started with the second period in the queue and the first one was always ignored. PiperOrigin-RevId: 297812937
tonihei committed -
When a new Timeline arrives in the Player, we check whether we can keep existing MediaPeriods. This check currently involves a condition that checks if the MediaPeriod is already prepared. The only reason we do that is to avoid calling MediaPeriod.seekToUs, which is not allowed on an unprepared MediaPeriod. It's better to keep the MediaPeriod to prevent restarting the preparation process. The prepration check can move further down to the place right before we would call seekToUs. PiperOrigin-RevId: 297812584
tonihei committed -
AnalyticsCollector keeps a list of existing MediaPeriodInfo that need to be updated to new Timelines when they arrive. This already happens in all cases except that the playingMediaPeriod wasn't updated when it didn't change during the timeline update. PiperOrigin-RevId: 297812038
tonihei committed -
The positions were interchangeably used with window and period positions. This change more clearly ensures that all positions in the AdPlaybackState are based on periods and that we use the right adjustments for all usages. PiperOrigin-RevId: 297811633
tonihei committed -
PiperOrigin-RevId: 297806457
andrewlewis committed -
Selection flags and language tags appear to apply to all tracks in MKV, so I think the change in output is correct. PiperOrigin-RevId: 297646190
olly committed -
This removes noisy data from the dump files and allows updating less dump files if a format field is added, removed or updated. PiperOrigin-RevId: 297617138
kimvde committed
-
- 27 Feb, 2020 16 commits
-
-
PiperOrigin-RevId: 297603312
aquilescanta committed -
These were accidentally introduced when rebasing https://github.com/google/ExoPlayer/commit/6946170d3ece533655a23f8fe65936412f365a6c PiperOrigin-RevId: 297602131
ibaker committed -
Parallel asynchronous calls to MediaCodec.queueSecureInputBuffer() may produce garbled video on some platforms. This workaround synchronizes calls to MediaCodec.queueSecureInputBuffer() so that only one call is in flight. PiperOrigin-RevId: 297601037
christosts committed -
Issue:#6914 PiperOrigin-RevId: 297598910
samrobinson committed -
PiperOrigin-RevId: 297591404
kim-vde committed -
This change adds the callback onSkipSilenceEnabledChange to the AudioListener and calls it when changed by the user by calling setPlaybackParameters, or when changed internally by the DefaultAudioSink if the parameters are not applicable. It needs to be plumped through AudioSink, AudioRenderer to SEP which eventually calls the AudioListener. No changes to the Player interface so far. The getter of skipSilenceEnabled is added to SimpleExoPlayer for completeness, but not yet to the Player interface. The setter is not yet exposed, but implemented as a private method for implementation reasons. PiperOrigin-RevId: 297590291
bachinger committed -
PiperOrigin-RevId: 297579793
andrewlewis committed -
PiperOrigin-RevId: 297579733
kim-vde committed -
PiperOrigin-RevId: 297578984
andrewlewis committed -
PiperOrigin-RevId: 297562889
olly committed -
In order to make DataSource extend SampleDataReader. PiperOrigin-RevId: 297368181
aquilescanta committed -
PiperOrigin-RevId: 297354294
tonihei committed -
PiperOrigin-RevId: 297336461
kimvde committed -
- Which abstracts ProgressiveMediaPeriod from the Extraction implementation. - Will allow us to depend on MediaParser. PiperOrigin-RevId: 297330623
aquilescanta committed -
DefaultLoadControl applies the same min buffer duration to audio and video. By default, min buffer is set equal to max buffer (50 seconds). PiperOrigin-RevId: 297324489
christosts committed -
Note: The dump files will need updating again when the extractors are modified to only set the appropriate bitrate. Enhancing the test first is nice, because it means that in subsequent CLs the dump file updates can be used to quickly see what's changed in the output. PiperOrigin-RevId: 297188367
olly committed
-
- 25 Feb, 2020 15 commits
-
-
PiperOrigin-RevId: 297187116
Oliver Woodman committed -
PiperOrigin-RevId: 297111999
tonihei committed -
- Avoid having ExtractorHolder expose the underlying extractor. - Make ProgressiveMP inject a DataSource instead of a DefaultExtractor. This CL should introduce no functional changes. PiperOrigin-RevId: 296944788
aquilescanta committed -
This seems to be no longer used PiperOrigin-RevId: 296856117
ibaker committed -
Issue: #2863 PiperOrigin-RevId: 296482726
olly committed -
Bitrates in the DASH manifest are peak bitrates, as per the ref'd issue. Issue: #5978 PiperOrigin-RevId: 296478812
olly committed -
Bitrates in SmoothStreaming manifests are average bitrates, as per the ref'd issue. Issue: #5978 PiperOrigin-RevId: 296467667
olly committed -
This change deprecates PlaybackParameter in AudioSink and splits it into playbackSpeed and skipSilenceEnabled. These properties are set separately in a future CL. The playback speed will be set through the MediaClock, while skipSilenceEnabled will be set by sending a message to the audio renderer. PiperOrigin-RevId: 296457043
bachinger committed -
- Deprecate old Format.createXXX methods - Deprecate most Format.copyXXX methods - Stop using deprecated Format.copyXXX methods in the library Note: Replacing library usages of Format.createXXX method will be done in follow up CLs. These changes aren't purely mechanical because we need to decide which out of peakBitrate and averageBitrate to set in each case where currently a single bitrate is provided. Issue: #2863 PiperOrigin-RevId: 296450935
olly committed -
PiperOrigin-RevId: 296405881
aquilescanta committed -
PiperOrigin-RevId: 296387837
olly committed -
The release_input_buffer callback will be called when the library is done consuming an "input buffer". The buffer passed into EnqueueFrame must be kept valid until this callback is called. If frame parallel is false, then this callback can be nullptr (in this case the buffer has to be kept valid until the next call to DequeueFrame). If frame parallel is true, this callback cannot be nullptr. PiperOrigin-RevId: 296276083
vigneshv committed -
Package private for now. It will be made visible in a child CL. Issue: #2863 PiperOrigin-RevId: 296255558
olly committed -
It's not clear why we're currently outputting the format in both init() and consume() - it seems likely that this was accidentally introduced in <unknown commit> when we started outputting the format in consume() but didn't remove it from init(). The SCTE-35 TsExtractorTest doesn't pass with the current code because when it seeks back to the beginning of the file init() is not called again so the second pass through only sees one sample (and ExtractorAsserts checks that seeking back to 0 produces the same output as reading the file from the beginning). I generated the SCTE-35 sample using TSDuck's tsp command: $ tsp --add-input-stuffing 1/10 \ -I file testdata/src/test/assets/ts/sample.ts \ -P pmt --service 1 --add-programinfo-id 0x43554549 --add-pid 600/0x86 \ -P spliceinject --service 1 --files scte_35.xml --wait-first-batch \ -P filter --negate --pid 0x1FFF \ -O file testdata/src/test/assets/ts/sample_scte35.ts This was adapted from the instructions in section 5.2.24.1 of the TSDuck user manual: https://tsduck.io/download/docs/tsduck.pdf PiperOrigin-RevId: 296217084
ibaker committed -
This info is already in the javadoc of FakeExtractorOutput#assertOutput but it's not super discoverable if you just see the test failure. I was manually copying the dump results around before realising there was a mechanism to auto-update. PiperOrigin-RevId: 296204463
ibaker committed
-