- 23 Jan, 2023 11 commits
-
-
Clarify that we always output on full range colors, and don't handle hdrStaticInfo input yet. PiperOrigin-RevId: 503224687
huangdarwin committed -
https://github.com/google/ExoPlayer/commit/ad51d1ca8766b699fe62f67e3fdf1e7363cc61ec
*** Original commit *** Fix "Transforming media" page Some information there is not correct anymore. *** PiperOrigin-RevId: 503196165
kimvde committed -
PiperOrigin-RevId: 503187291
samrobinson committed -
This makes it implicitly clear that if the value of a getter changes due to a change in command availability then the listener will be invoked, without needing to explicitly document every command on every listener method. #minor-release PiperOrigin-RevId: 503178383
ibaker committed -
Some information there is not correct anymore. PiperOrigin-RevId: 503141754
kimvde committed -
PiperOrigin-RevId: 503138745
kimvde committed -
We currently only document it for the getCurrentMediaItem(), but the command was always meant to cover all information about the current media item and the position therein. To correctly hide information for controllers, we need to filter the Timeline when bundling the PlayerInfo class if only this command is available. PiperOrigin-RevId: 503098124
tonihei committed -
Usages of the deprecated methods in Transformer.Builder will be removed in a follow-up CL. PiperOrigin-RevId: 502889423
kimvde committed -
This is to avoid regressions introduced by removing the convenience methods from TransformationRequest. PiperOrigin-RevId: 502864512
kimvde committed -
When bundling PlayerInfo, we need to remove information if the controller is not allowed to access it. This was only partially done at the moment. PiperOrigin-RevId: 502852798
tonihei committed -
TESTED: Manually verified the ColorInfo is propagated when VSP is used. PiperOrigin-RevId: 502843773
samrobinson committed
-
- 18 Jan, 2023 8 commits
-
-
PiperOrigin-RevId: 502821506
rohks committed -
To always generate silent audio, `removeAudio(true)` can be used in conjunction. PiperOrigin-RevId: 502814315
samrobinson committed -
This class will be used in a follow-up CL. PiperOrigin-RevId: 502615323
kimvde committed -
When bundling PlayerInfo, we remove data when the controller is not allowed to access this data via getters. We also remove data for performance reasons. In the toBundle() method, it's currently hard to make the connection between allowed commands and filtering, because the values are checked at a different place. This can be made more readable by forwarding the applicable Commands directly. The only functional fix is to filter the Timeline when sending the first PlayerInfo after a connecting a controller if the command to get the Timeline is not available. This also allows us to remove a path to filter MediaItems from Timelines as it isn't used. PiperOrigin-RevId: 502607391
tonihei committed -
If a device only supports 1920x1080 as maximum resolution, then adding the 25% case ensures 8k is reduced correctly. PiperOrigin-RevId: 502588364
samrobinson committed -
PiperOrigin-RevId: 502573469
samrobinson committed -
PiperOrigin-RevId: 502571320
Googler committed -
This is an AssetLoader that wraps a sequence of AssetLoaders. It will be used for constrained multi-asset. This class can currently only concatenate media items with the exact same format. PiperOrigin-RevId: 502525796
kimvde committed
-
- 17 Jan, 2023 21 commits
-
-
Also remove usages of TransformationRequest convenience methods (setScale, setRotationDegrees and setResolution). Some usages of setResolution can't be removed yet because they are used for fallback. PiperOrigin-RevId: 502415748
kimvde committed -
This CL includes following changes: 1. Remove GCA related terms/links from java docs and comments. 2. Make class final where ever possible. 3. Append /* package */ for default classes. 4. Change java docs to recommended format. 5. Replace term "packet" with "sample" to avoid confusion. 6. Correct TODO format. 7. Delete MediaFormatUtil.java from muxer module and add its methods into MediaFormatUtil.java in common module. Note: The java doc on various boxes has the limited description which was already present. In future I am planning to add proper small description for each box (from MP4 spec). Not included in this CL: 1. Order of element correction as it will show lot of changes and might create confusion with other minor changes. 2. Correction in test cases (Only some renaming). PiperOrigin-RevId: 502414139
sheenachhabra committed -
This is needed for constrained multi-asset to shift the timestamps of the media items that are not the first in the sequence. PiperOrigin-RevId: 502409923
kimvde committed -
PiperOrigin-RevId: 502388865
bachinger committed -
Also, omit the "actual" label from output files, as this boilerplate isn't necessary (it doesn't disambiguate between any other saved filename like "expected"). PiperOrigin-RevId: 502378188
huangdarwin committed -
This should make debugging much easier as values will be more human-readable. Before this CL, one needed to reference MediaFormatUtil to check the colorSpace/colorTransfer/colorRange values and make sure values were as expected. PiperOrigin-RevId: 502367147
huangdarwin committed -
Makes GlEffectsFrameProcessorPixelTest slightly more modular in preparation for copying this into transformer/mh. Refactoring change. No functional change intended. PiperOrigin-RevId: 501902223
huangdarwin committed -
PiperOrigin-RevId: 501881646
samrobinson committed -
Frame cache compensates for the fluctuation in frame processing times. Imagine a frame takes 10ms to process, and the interval between two frames is 33ms. The third frame took 40ms to process. If we don't have frame cache: - Process frame 1, ready after 10ms, starts playback, now t=0 ms - Start processing frame 2, ready at t=10ms, - Release frame 2 at t=33ms - We start processing the third frame at t=33ms - The third frame is due presentation at t=66ms - But frame 3 is available at t=73ms, late If we have a frame cache of say 3 frams, - Process frame 1, ready after 10ms, starts playback, now t=0 ms - Start processing frame 2, ready at t=10ms - Start processing frame 3, ready at t=50ms - Release frame 2 at t=33ms - Start frame 4, ready at t=60ms - Frame 3 is due presentation at t=66ms - Frame 3 isn't late PiperOrigin-RevId: 501869948
claincly committed -
PiperOrigin-RevId: 501865706
claincly committed -
Previously, after calling MCVR.setOutput() with null, `frameProcessorManager`'s output surface is cleared. What was unexpected is `ExoPlayerInternal` notifies a zero output resolution after clearing the output surface. This zero resolution causes FrameProcessor to fail. PiperOrigin-RevId: 501861993
claincly committed -
Move BitmapTestUtil from media3.effect to media3.test.utils. This allows this class to be accessed from both transformer and effect tests. Refactoring change. No functional change intended. PiperOrigin-RevId: 501837130
huangdarwin committed -
Each error will make the output be a solid color with a unique color. PiperOrigin-RevId: 501824355
huangdarwin committed -
Tested manually on the Pixel 7 and Samsung S10. PiperOrigin-RevId: 501626354
huangdarwin committed -
Notifies event listener of FrameProcessor's new output size to layout the PlayerView PiperOrigin-RevId: 501590239
claincly committed -
This class may be removed soon, but in the meantime clarify this method's javadoc summary fragment to make it marginally clearer that this only affects the "displayed" height instead of the "encoded" height. PiperOrigin-RevId: 501582219
huangdarwin committed -
PiperOrigin-RevId: 501575932
samrobinson committed -
Small refactoring change to simplify the logic a tiny bit by removing one unnecessary variable. No functional change intended. PiperOrigin-RevId: 501566533
huangdarwin committed -
This is a prerequisite step to making the `ResamplingAudioProcessor` public. PiperOrigin-RevId: 501545561
samrobinson committed -
This method allows to call through to `StreamManager.focus()` of the currently playing SSAI stream. PiperOrigin-RevId: 501399144
bachinger committed -
Starting with Android 13 (API 33) an app needs to request the permission to post notifications or notifications are suppressed. This change documents this in the class level JavaDoc of the `DownloadService`. Issue: google/ExoPlayer#10884 PiperOrigin-RevId: 501346908
bachinger committed
-