- 01 Jun, 2020 7 commits
-
-
Oliver Woodman committed
-
Oliver Woodman committed
-
Merge fix for #7193 into dev-v2-r2.11.5
Oliver Woodman committed -
We currently have a currentMediaPeriodId and an activeSessionId that are more or less tracking the same thing unless the current media period isn't "active" yet. Simplify this logic by using a single currentSessionId field and the respective isActive flag of this session. Also move all session creation and activation code in the same method to make it easier to reason about the code. This change also fixes a subtle bug where events after a seek to a new window are not ignored as they should. PiperOrigin-RevId: 289432181
tonihei committed -
Currently, this method is only supposed to be called before removing the listener from the player or when releasing the player. If called at other times, it will throw an exception later when a playback session is ended automatically. issue:#7193 PiperOrigin-RevId: 308254993
tonihei committed -
The first session should only be created once we have the media items and/or called prepare. Otherwise the first session is created with an EventTime having an empty timeline making it less useful. issue:#7193 PiperOrigin-RevId: 308100555
tonihei committed -
This reverts commit b05e9944.
Oliver Woodman committed
-
- 29 May, 2020 33 commits
-
-
PiperOrigin-RevId: 312083761
andrewlewis committed -
PiperOrigin-RevId: 312080838
andrewlewis committed -
The ad break time in seconds from IMA was "-1" for postrolls, but this didn't match C.TIME_END_OF_SOURCE in the ad group times array. Handle an ad break time of -1 directly by mapping it onto the last ad group, instead of trying to look it up in the array. PiperOrigin-RevId: 312064886
andrewlewis committed -
Detect stuck buffering cases in ImaAdsLoader, and discard the ad group after a timeout. This is intended to make the IMA extension more robust in the case where an ad group unexpectedly doesn't load. The timing out behavior is enabled by default but apps can choose to retain the old behavior by setting an unset timeout on ImaAdsLoader.Builder. PiperOrigin-RevId: 311729798
andrewlewis committed -
PiperOrigin-RevId: 311106612
andrewlewis committed -
Put static methods at the end. Also add a couple of missing parameter name comments. PiperOrigin-RevId: 311077684
andrewlewis committed -
Log content progress events, as these are helpful to debug triggering of events based on the content progress. Don't log AD_PROGRESS events as they occur several times per second while ads are playing, and the verbosity makes logs difficult to read. PiperOrigin-RevId: 311077302
andrewlewis committed -
PiperOrigin-RevId: 310901647
andrewlewis committed -
PiperOrigin-RevId: 310883076
andrewlewis committed -
issue:#6429 PiperOrigin-RevId: 309906760
andrewlewis committed -
adPlaybackState is now non-null, and the uninitialized case is covered by a new boolean hasAdPlaybackState. Position progress updates are now non-null and initialized with IMA's VIDEO_TIME_NOT_READY constant. Also fix some misc code issues: - Remove empty branch for SmoothStreaming (Android Studio warns about this). - Tidy onTimelineChanged and onPositionDiscontinuity and the methods they call to improve naming. - Remove logging for IMA events after release, as these methods are expected to be called in the current IMA SDK behavior. PiperOrigin-RevId: 308977116
andrewlewis committed -
The mocking setup is quite messy/unclear compared to the fakes, but it seems worth switching over because IMA API changes have already required changes to fakes in the past, and there are more API changes in the version we are about to upgrade to. This change should generally remove the need to keep the fakes up-to-date. PiperOrigin-RevId: 308819176
andrewlewis committed -
The positions were interchangeably used with window and period positions. This change more clearly ensures that all positions in the AdPlaybackState are based on periods and that we use the right adjustments for all usages. PiperOrigin-RevId: 297811633
tonihei committed -
This tests explicitly that initialization happens even if the Timeline is a placeholder. No other change is needed. While the Timeline is still a placeholder ImaAdsLoader.getCurrentPeriodPosition will return 0 and trigger pre-rolls (intended behaviour) and it doesn't matter whether the actual initial period position may be somewhere else. PiperOrigin-RevId: 298833867
tonihei committed -
This change is similar to e8293b92 but without relying on new player events that haven't been released yet, to make it easier to merge changes related to ImaAdsLoader on top.
Andrew Lewis committed -
ImaAdsLoader relies on preloading being enabled (it doesn't work without it) so we may as well remove the constant to avoid potential confusion. PiperOrigin-RevId: 284951356
andrewlewis committed -
Oliver Woodman committed
-
PiperOrigin-RevId: 292316767
Oliver Woodman committed -
PiperOrigin-RevId: 300249371
olly committed -
- Add method to scale scrubber handle of DefaultTimeBar PiperOrigin-RevId: 294366734
olly committed -
The capture frame rate is currently available both via Format.metadata and decoded in Format.frameRate. As the container Format.frameRate may be useful to apps, only store the capture frame rate in metadata (apps will need to decode it but can now access the container frame rate too). PiperOrigin-RevId: 284165711
andrewlewis committed -
We keep an index hint for the next pending player message. This hint wasn't updated correctly when messages are removed due to a timeline update. This change makes sure to only use the hint locally in one method so that it doesn't need to be updated anywhere else and also adds the "hint" suffix to the variable name to make it clearer that it's just a hint and there are no guarantees this index actually exists anymore. issue:#7278 PiperOrigin-RevId: 309217614
tonihei committed -
The MediaSessionConnector gets a Bundle passed to the MediaSession.Callback from the framework which can be null. This needs to be properly annotated with @Nullable. Issue: #7234 PiperOrigin-RevId: 307822764
bachinger committed -
Oliver Woodman committed
-
PiperOrigin-RevId: 313372995
Oliver Woodman committed -
This ensure style themes are correctly applied. issue:#7357 PiperOrigin-RevId: 313145345
tonihei committed -
Issue:#7338 PiperOrigin-RevId: 312470913
olly committed -
PiperOrigin-RevId: 312266156
olly committed -
Issue:#7337 PiperOrigin-RevId: 312042768
samrobinson committed -
- Add Widevine AV1 streams - Remove SD and HD only Widevine streams (we don't need so many!) - Simplify naming PiperOrigin-RevId: 311697741
olly committed -
PiperOrigin-RevId: 311628160
olly committed -
PiperOrigin-RevId: 311623784
Oliver Woodman committed -
PiperOrigin-RevId: 311290214
olly committed
-