- 15 Jun, 2016 40 commits
-
-
Now uses buffer position + limit in both new and legacy modes. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120713837
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120699171
eguven committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120694784
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120693278
andrewlewis committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120691990
andrewlewis committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120689946
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120553402
olly committed -
Reading the format and/or a sample needs to be done as a single operation. Else you can have a situation where the queue is initially empty, and this happens: 1) Read downstream format X 2) Read downstream format X (unchanged) 3) Write format Y 4) Write first sample 5) Read first sample The first sample then appears to be format X rather than Y. Note that readData in the SampleSource implementations always looks roughly the same. readReset is identical in all cases. isReady is identical in all cases now I've fixed them to be that way. So it should be pretty easy to get DefaultTrackOutput to implement TrackStream directly, at which point a whole load of duplication will disappear. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120546377
olly committed -
- Code is simpler. We only ever reset all tracks. - Allows the standalone media clock to be updated properly. This allows simpler recovery for live streams in ExtractorSampleSource. - Fixes #1285 and paves the way for a fix for #758. Issue: #1285 Issue: #758 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120530682
olly committed -
I think the concept of a sparse track might need formalizing in Format at some point. We should probably do a similar thing with sparse tracks in ExtractorSampleSource as well. WDYT? Issue: #551 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120530195
olly committed -
This is just wrong. I think there used to be an off-by-one timestamp error in YouTube's fmp4 streams, and this code was initially designed exclusively to play such streams. I don't see this issue any more though, if it was ever there! ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120447694
olly committed -
Having moved HLS to use single sample queues per track, these classes have become relatively similar. This CL aligns the two to make this more obvious. It remains unclear whether it'll ever be sensible to merge them; there are still some niggly complications for HLS. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120429618
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120425278
[]inger committed -
This CL provides the necessary infrastructure to add styling by class. This was separated into two different CLs to ease reviewing. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120336976
aquilescanta committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120335929
olly committed -
Here is a WAV that exhibits this issue: https://storage.googleapis.com/courtside-public/dcower/reaper_16bit_nonbwf.wav ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120334203
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120334164
olly committed -
This can occur in some Broadcast Wave Format (BWF) files, such as those produced by the Zoom H2n. See the included sample for an example. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120334117
olly committed -
Also support "lpcm" and "sowt" sample descriptors. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120334017
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120332794
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120332721
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120331805
andrewlewis committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120326293
olly committed -
- RollingSampleBuffer -> DefaultTrackOutput - TsChunk -> HlsMediaChunk - Established hls.playlist package for HLS playlist things ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120325049
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120240634
olly committed -
Notes: - RollingSampleBuffer will be renamed DefaultTrackOutput in a following CL, and variable naming will be sanitized. - TsChunk will also be renamed to HlsMediaChunk, since it can be used for non-TS containers (e.g. MP3). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120240243
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120225655
eguven committed -
This also fixes the largest queued timestamp to be the correct value if upstream samples are discarded. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120207054
olly committed -
At this point the only reason preventing the chunk package from using RollingSampleBuffer directly, rather than DefaultTrackOutput, is that the latter maintains the largest parsed timestamp. This will be pushed inside the former in the next CL. Following that, splicing logic will also be pushed inside of RollingSampleBuffer, and HLS will be moved over to using a single RollingSampleBuffer per track, with the splicing done inline. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120206658
olly committed -
- Rename preparePlayer to initializePlayer, to reflect the fact that the preparing state is gone. Replace playerNeedsPrepare with playerNeedsSource. - playWhenReady is now always true in calls to initializePlayer. - Handle the intent just before setting the source. - Use URIs consistently instead of Strings to avoid reparsing. - onShown becomes initializePlayer. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120125576
andrewlewis committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120123489
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120123335
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120123223
olly committed -
This is the first step toward merging of RollingSampleBuffer and DefaultTrackOutput, which is a precursor to removing some indirection for DASH/SS playbacks, and to moving HLS playbacks to use a single output buffer per track (with inline splicing). Where this is heading is that sample format changes will eventually be attached to samples in the rolling buffer. This will eliminate the need for piping sample formats around the edges of the rolling buffer (e.g. via redirection in ChunkExtractorWrapper and BaseMediaChunk.getSampleFormat). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120123093
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120119973
andrewlewis committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120115490
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120107182
andrewlewis committed -
There's a more nuanced version of this where we actually disable on the loading side, but it's quite tricky to get the threading just right. I have a change that I'll probably manage to clean up and send out at some point. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120106967
olly committed -
Oops, forgot this from my previous CL! ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=120104992
olly committed -
Issue: #1428 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=119952373
olly committed
-