1. 06 May, 2020 11 commits
  2. 05 May, 2020 22 commits
  3. 04 May, 2020 3 commits
  4. 01 May, 2020 4 commits
    • DownloadManager.Task: Remove top level thread interrupt · bb744e5f
      DownloadManager doesn't know enough about the Downloader implementations to
      know that interrupting the thread is the right thing to do. In particular,
      if a Downloader implementation wants to delegate work to additional worker
      threads, then it will probably not want its main thread to be interrupted
      on cancelation. Instead, it will want to cancel/interrupt its worker threads,
      and keep its main thread blocked until work on those worker threads has
      stopped (download() must not return whilst the Downloader is still touching
      the cache).
      
      This change moves control over what happens to the individual Downloader
      implementations.
      
      Issue: #5978
      PiperOrigin-RevId: 309419177
      olly committed
    • Simplify thread interruption for downloads. · 32516d85
      - Stop throwing InterruptedException from CacheUtil. When a CacheUtil operation
        throws or returns, the caller should always check its own state to determine
        whether they canceled the operation. If a caller is trying to catch
        InterruptedException separately to IOException to do something different in
        that case, they're probably doing the wrong thing. So it's simpler, and probably
        less error prone, just to throw an IOException in the case of interruption.
      - Throwing InterruptedIOException is also consistent with what our Extractor and
        DataSource implementations do.
      
      Issue: #5978
      PiperOrigin-RevId: 309411556
      olly committed
    • Map R-prerelease to SDK_INT=30 · f9466066
      PiperOrigin-RevId: 309411490
      olly committed
    • Merge pull request #7304 from AChep:patch-1 · af6baaed
      PiperOrigin-RevId: 309395364
      Oliver Woodman committed