Commits · 4f15cfaa78f8053c4bf83ef0871df98d29fa6e0b · SDK / exoplayer

08 Jan, 2020 19 commits
- Merge pull request #6836 from DolbyLaboratories:dev-v2-refineAC4 · 4f15cfaa
```
PiperOrigin-RevId: 288772277
```
  Oliver Woodman committed Jan 08, 2020
  4f15cfaa Browse Files
- FlacExtractor: add condition for zero-length reads · 79edf7cc
```
This improves readability by making clearer that reading no bytes from
the input in readFrames() is an expected case if the buffer is full.

PiperOrigin-RevId: 288711841
```
  kimvde committed Jan 08, 2020
  79edf7cc Browse Files
- Disable chronometer for playback speeds != 1.0 · 216518eb
```
This doesn't work because the Chronometer text layout can only count in realtime.

Issue:#6816
PiperOrigin-RevId: 288711702
```
  tonihei committed Jan 08, 2020
  216518eb
- Fix typo in SpannedSubject.hasBoldItalicSpanBetween · e5eaacec
```
PiperOrigin-RevId: 288710939
```
  ibaker committed Jan 08, 2020
  e5eaacec Browse Files
- Ensure seeks to new windows are reported as seeking. · fa9bf9c8
```
Currently, seeks are only tracked if both the start and the end of the seek
is within the same window. This means no seeking state is reported if the
playback switches to a new window during the seek.

This problem is fixed by tracking seek start and end events in all cases,
but only report seeking state once the window becomes the foreground window.

PiperOrigin-RevId: 288706674
```
  tonihei committed Jan 08, 2020
  fa9bf9c8
- Update TtmlDecoder to keep only one Span of each type · 14e401f5
```
The current code relies on Android's evaluation order of spans, which
doesn't seem to be defined anywhere.

PiperOrigin-RevId: 288700011
```
  ibaker committed Jan 08, 2020
  14e401f5
- Fix what I think is a typo in WebVTT test data · 8e26505e
```
Without the CSS tweak the additional test assertion fails.

PiperOrigin-RevId: 288698323
```
  ibaker committed Jan 08, 2020
  8e26505e
- Fix TrueHD chunking in Matroska · 762bc18a
```
Issue: #6845
PiperOrigin-RevId: 288688716
```
  andrewlewis committed Jan 08, 2020
  762bc18a Browse Files
- Add TypefaceSpan and hasNoFooSpanBetween() support to SpannedSubject · 448db894
```
Use these to migrate the last WebvttDecoderTest method to SpannedSubject

PiperOrigin-RevId: 288688620
```
  ibaker committed Jan 08, 2020
  448db894 Browse Files
- Use FlacLibrary.isAvailable in FlacExtractor selection · ee091e6a
```
PiperOrigin-RevId: 288667790
```
  kimvde committed Jan 08, 2020
  ee091e6a
- Upgrade OkHttp library to fix HTTP2 issue · 70fe6b45
```
Issue: #4078
PiperOrigin-RevId: 288651166
```
  olly committed Jan 08, 2020
  70fe6b45 Browse Files
- Add package level NonNull to extractor.ts · 63f90ade
```
Also remove most classes from the nullness blacklist

PiperOrigin-RevId: 288494712
```
  olly committed Jan 08, 2020
  63f90ade Browse Files
- Add start() method in MediaCodecAdapter · fb42f818
```
PiperOrigin-RevId: 288476415
```
  christosts committed Jan 08, 2020
  fb42f818 Browse Files
- Fix null-checker suppression introduced by 3.0.1 upgrade · c5535e82
```
Suppression added in https://github.com/google/ExoPlayer/commit/6f9baffa0cc7daf8cbfd5e1f6c55a908190d2041

PiperOrigin-RevId: 288475120
```
  ibaker committed Jan 08, 2020
  c5535e82 Browse Files
- Remove assertCues() helper methods from WebvttDecoderTest · 18160613
```
These make the interesting bits of each assertion harder to follow imo.

Also remove all the assertWithMessage() calls at the same time, Olly
convinced me these are rarely useful since you can click from the stack
trace to the failing line in the IDE.

PiperOrigin-RevId: 288470704
```
  ibaker committed Jan 08, 2020
  18160613 Browse Files
- Fix playback for Vivo codecs that output non-16-bit audio · 692c8ee0
```
PiperOrigin-RevId: 288468497
```
  olly committed Jan 08, 2020
  692c8ee0 Browse Files
- Add comment explaining FlacBinarySearchSeeker output · 35fbb7f7
```
PiperOrigin-RevId: 288464154
```
  kimvde committed Jan 08, 2020
  35fbb7f7 Browse Files
- Remove assertWithMessage() calls from SsaDecoderTest · 09ca5c07
```
As discussed with Olly, these don't add much info and are liable
to go stale.

PiperOrigin-RevId: 288463027
```
  ibaker committed Jan 08, 2020
  09ca5c07 Browse Files
- FlacExtractor: Fix possible skipping of frame boundaries · 9618e5e0
```
PiperOrigin-RevId: 288304477
```
  olly committed Jan 08, 2020
  9618e5e0 Browse Files
06 Jan, 2020 18 commits

Remove WavExtractor from the nullness blacklist · 24743c77
```
PiperOrigin-RevId: 288292488
```
olly committed Jan 06, 2020
24743c77 Browse Files
Add tate-chu-yoko support to WebVTT decoding · a98fc7ca
```
PiperOrigin-RevId: 288285953
```
ibaker committed Jan 06, 2020
a98fc7ca Browse Files

Simulate IO exceptions in all FlacExtractor tests · 06fcf29e

- Simulate IO exceptions in the test using FlacBinarySearchSeeker for
  seeking in FlacExtractorTests. This makes the test slower but covers
  more test cases.

PiperOrigin-RevId: 288285057

committed Jan 06, 2020

06fcf29e Browse Files

Support 5G in network type detection · 3a31bc17
```
PiperOrigin-RevId: 288280500
```
tonihei committed Jan 06, 2020
3a31bc17 Browse Files

Add <ruby> tag support to WebvttCueParser · 6f312c05

There's currently no rendering support for ruby text in SubtitleView
or SubtitlePainter, but this does have a visible impact with the
current implementation by stripping the ruby text from Cue.text
meaning it doesn't show up at all under the 'naive' rendering.
This is an improvement over the current behaviour of including
the ruby text in-line with the base text (no rubies is better than
wrongly rendered rubies).

PiperOrigin-RevId: 288280416

committed Jan 06, 2020

6f312c05 Browse Files

Add RubySpan support to SpannedSubject · 2b1a0663
```
PiperOrigin-RevId: 288280332
```
ibaker committed Jan 06, 2020
2b1a0663 Browse Files

Add RubySpan · e55af3e3

This will be used when parsing Ruby info from WebVTT and TTML/IMSC
subtitles.

PiperOrigin-RevId: 288280181

committed Jan 06, 2020

e55af3e3 Browse Files

Convert StyleSpan assertions in SpannedSubject to fluent style · 1e7db22e
```
PiperOrigin-RevId: 288274998
```
ibaker committed Jan 06, 2020
1e7db22e Browse Files

Fix MatroskaExtractor to use blockDurationUs not durationUs · 29df73e2

This typo was introduced in https://github.com/google/ExoPlayer/commit/ddb70d96ad99f07fe10f53a76ce3262fe625be70
when migrating a static method with parameter `durationUs` to an
instance method where the correct field to use was `blockDurationUs`
(but `durationUs` also exists).

The test that catches this was only added in https://github.com/google/ExoPlayer/commit/45013ece1e3fe054ff8960355a89559241eeb288 (and
therefore configured with the wrong expected output data).

issue:#6833
PiperOrigin-RevId: 288274197

committed Jan 06, 2020

29df73e2

Remove getDequeueOutputBufferTimeoutUs · 1c1c0ed8

Remove unused method
MediaCodecRenderer#getDequeueOutputBufferTimeoutUs().

PiperOrigin-RevId: 288005572

committed Jan 06, 2020

1c1c0ed8 Browse Files

Use MIME types rather than PCM encodings for ALAW and MLAW · f1f0ff3a
```
PiperOrigin-RevId: 287999703
```
olly committed Jan 06, 2020
f1f0ff3a Browse Files

Remove WebvttCssStyle.cascadeFrom() · 88e70d7c

It's not used. I was trying to work out how to correctly cascade my
text-combine-upright styling, but deleting the method seemed easier...

PiperOrigin-RevId: 287989480

committed Jan 06, 2020

88e70d7c Browse Files

Make SpannedSubject more fluent · 0587180f

I decided the flags bit was a bit unclear so I played around with this

It's also needed for more 'complex' assertions like colors - I didn't
want to just chuck in a fourth int parameter to create:
hasForegroundColorSpan(int start, int end, int flags, int color)

PiperOrigin-RevId: 287989424

committed Jan 06, 2020

0587180f Browse Files

Clear existing Spans when applying CSS styles in WebvttCueParser · 1c0e6978

Relying on the precedence of spans seems risky - I can't find it
defined anywhere. It might have changed in Android 6.0?
https://stackoverflow.com/q/34631851

PiperOrigin-RevId: 287989365

committed Jan 06, 2020

1c0e6978 Browse Files

Add unit tests to FLAC extractor related classes · f76b4fe6
```
PiperOrigin-RevId: 287973192
```
kimvde committed Jan 06, 2020
f76b4fe6 Browse Files
Show ad markers after the window duration · b5fa3383
```
Issue: #6552
PiperOrigin-RevId: 287964221
```
andrewlewis committed Jan 06, 2020
b5fa3383 Browse Files

Optimize AC-4 code and add related test cases · a67394b2

-- Optimize Mp4Extractor for AC-4
-- Optimize FragmentedMp4Extractor for AC-4
-- Add test case for AC-4 in MP4
-- Add test case for AC-4 in Fragmented MP4

committed Jan 06, 2020

a67394b2 Browse Directory

Merge pull request #6 from google/dev-v2 · 781f8488
```
Dev v2
```
BAI Yanning committed Jan 06, 2020
781f8488 Browse Files

02 Jan, 2020 3 commits
- Add support for IMA ADPCM in WAV · 826083db
```
PiperOrigin-RevId: 287854701
```
  olly committed Jan 02, 2020
  826083db Browse Directory
- Support twos codec in MP4 · f0e0ee42
```
Issue: #5789
PiperOrigin-RevId: 287828559
```
  olly committed Jan 02, 2020
  f0e0ee42 Browse Directory
- Document overriding of drawables for PlayerControlView · 2380f937
```
Issue: #6779
PiperOrigin-RevId: 287828273
```
  olly committed Jan 02, 2020
  2380f937 Browse Files