- 09 Apr, 2021 10 commits
-
-
This brings in another fix for `NullPointerExceptions` within `WebView` callbacks in the IMA SDK, related to companion ads. Issue: #8447 #minor-release PiperOrigin-RevId: 367591047
andrewlewis committed -
Move AdsLoader inner classes that are also required by the UI module into common. PiperOrigin-RevId: 367414679
olly committed -
The main change here is that VideoDecoderGLSurfaceView now implements VideoDecoderOutputBufferRenderer directly. This avoids SimpleExoPlayer having to cast to VideoDecoderGLSurfaceView, which will be necessary if VideoDecoderGLSurfaceView is moved to the UI module. Instead, the player can cast directly to VideoDecoderOutputBufferRenderer, which could be moved to the Common module. The renderer is also moved to be an inner class, since it's not used anywhere else and since doing this makes it a little easier to move things around. PiperOrigin-RevId: 367398147
olly committed -
PiperOrigin-RevId: 367238434
gyumin committed -
This means there are fewer changes required when exporting these tests as part of the GTS suite run by device manufacturers. PiperOrigin-RevId: 367230977
ibaker committed -
Move CaptionStyleCompat to the UI module, where it's used PiperOrigin-RevId: 367223891
olly committed -
PiperOrigin-RevId: 367204382
jaewan committed -
We added a source that allows mixed placeholder and non-placeholder periods, but have no way to denote that in the Timeline because the placeholder flag only exists on Window level. This causes a bug if the first item in a concatenation has a window-period offset and the player can't detect whether it's still a placeholder or not. Adding this flag to Period allows the player to detect this reliably. In addition we need to make sure that re-resolving pending positions only happens for the first placeholder period where the window-offset can actually change. As all subsequent periods have to start at position 0, so they don't need to be re-resolved (and shouldn't). PiperOrigin-RevId: 367171518
tonihei committed -
* @Nullable is not a TYPE_USE annotation, so should appear before any modifiers and after Javadocs. (see go/java-style#s4.8.5-annotations) This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Suggest a fix on the CL (go/how-to-suggest-fix). * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/exoplayer/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/exoplayer/METADATA. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth PiperOrigin-RevId: 367053059
olly committed -
PiperOrigin-RevId: 367020270
bachinger committed
-
- 06 Apr, 2021 8 commits
-
-
PiperOrigin-RevId: 366972832
olly committed -
- Take centerControls padding into account to prevent switching to minimal mode too soon - Disable clipping to padding to avoid the edges of controls from being clipped as the view gets smaller Issue: #8763 PiperOrigin-RevId: 366966298
olly committed -
This reverts <unknown commit> Which was a temporary workaround for Issue: #1874 Also add a loop to ensure we process as many metadata items as applicable in each render() call. PiperOrigin-RevId: 366965504
ibaker committed -
PiperOrigin-RevId: 366938045
jaewan committed -
LSC: go/checker-lsc Tested: Sample tests for this CL passed, but some tests failed during the TGP run. Test failures are believed to be unrelated to this CL PiperOrigin-RevId: 366804637olly committed -
PiperOrigin-RevId: 366272937
samrobinson committed -
Issue: #8783 #minor-release PiperOrigin-RevId: 366265419
olly committed -
Make BaseTrackSelection blacklist and isBlacklisted methods non-final. PiperOrigin-RevId: 366256521
olly committed
-
- 01 Apr, 2021 22 commits
-
-
PiperOrigin-RevId: 366255289
olly committed -
I've removed the "by default" statements, since this now depends on how the builder was configured. PiperOrigin-RevId: 366249995
olly committed -
This ensures BUFFER_FLAG_DECODE_ONLY is set on samples that are before the playback start position, in the case that the queue is created after the start position is set. #minor-release PiperOrigin-RevId: 366249188
olly committed -
When playing TrueHD streams, it's possible that the first decoded buffer is empty, and that the channel count and sample rate are still unknown. To correct for this, defer determining the format until a buffer that will actually be output from the decoder has been obtained, and only then query the channel count and sample rate. Issue: #8616 #minor-release PiperOrigin-RevId: 366246245
olly committed -
PiperOrigin-RevId: 366240390
samrobinson committed -
The condition is meant to be unblocked whenever the constructor is left. This should include unchecked exceptions (that may be thrown due to bugs in the dependent components, or user-inhected factories) PiperOrigin-RevId: 366235361
tonihei committed -
The buildscript entry is required by com.android.tools.build:gradle:4.0.1. For other projects, it appears that org.checkerframework is in jcenter. Without this change building with gradlew is broken, at least. #minor-release PiperOrigin-RevId: 366222799
andrewlewis committed -
PiperOrigin-RevId: 366131005
olly committed -
Issue: #8710 #minor-release PiperOrigin-RevId: 366051836
ibaker committed -
Currently they are only released when the timeline becomes non-empty again or the player is released. Issue: #8778 PiperOrigin-RevId: 366041625
tonihei committed -
Issue: #5246 #minor-release PiperOrigin-RevId: 366041182
andrewlewis committed -
Add an allowlist of Metadata.Entry implementations with stable toString overrides. PiperOrigin-RevId: 366037505
ibaker committed -
PiperOrigin-RevId: 366033200
olly committed -
The dumped output should include metadata, but doesn't because of Issue: #8710. The fix is in a follow-up change. PiperOrigin-RevId: 366028303
ibaker committed -
When playback transitions automatically, the timeline may have changed because the cast device learned about the duration of the next media item and includes this in the new media status that is sent to the CastPlayer. In such a case we need to make sure that we don't report a media item transition with reason PLAYLIST_CHANGED but for reason AUTO. PiperOrigin-RevId: 366025323
bachinger committed -
PiperOrigin-RevId: 366015326
jaewan committed -
PiperOrigin-RevId: 365998615
Oliver Woodman committed -
The new onPositionDiscontinuity callback contains sufficient information, so that this former workaround to obtain the position before a seek is no longer needed. PiperOrigin-RevId: 365993937
tonihei committed -
PiperOrigin-RevId: 365992439
olly committed -
Aims to achieve visibility parity with MediaCodecRenderer#onQueueInputBuffer. Allows measuring the time when the codec queue the first input buffer in the codec. Which means the Codec has been initialized and is about to start decoding. It also allows measuring how long it takes for the Codec to render its first frame. PiperOrigin-RevId: 365906756
olly committed -
This is generally not supported by our classes. A similar change for audio was made in https://github.com/google/ExoPlayer/commit/aa2beb080c6f621264527a6147a258bdd7f0fa27. PiperOrigin-RevId: 365795371
tonihei committed -
PiperOrigin-RevId: 365794941
ibaker committed
-