- 09 Jun, 2022 6 commits
-
-
Some Player implementations have no playlist capability but can still set a MediaItem for playback. Examples are a MediaController connected to a legacy MediaSession, ExoPlayer up to 2.12 or MediaPlayer. To indicate this capability, we need an allowed command in addition to COMMAND_CHANGE_MEDIA_ITEMS that just allows to set a single item that replaces everything that is currently played. #minor-release PiperOrigin-RevId: 453879626 (cherry picked from commit 5333c67d)
tonihei committed -
Use Collections.synchronizedSet() instead of creating a set from a ConcurrentHashMap because ConcurrentHashMap has a bug in APIs 21/22 that can result in lost updates. PiperOrigin-RevId: 453696565 (cherry picked from commit d506c709)
christosts committed -
With HLS chunkless preparation, audio formats may have no value for channel count. In this case, the DefaultAudioSink will either query the platform for a supported channel count (API 29+) or assume a max channel count based on the encoding spec in order to decide whether the audio format can be played with audio passthrough. Issue: google/ExoPlayer#10204 #minor-release PiperOrigin-RevId: 453644548 (cherry picked from commit 86973382)
christosts committed -
These legacy callbacks are currently forwarded to onSetMediaUri which will be removed in the future. Also make sure to only call player.prepare/play after the items have been set. The calls to onAddQueueItem are also forwarded to onAddMediaItems to actually allow a session to resolve these items to playable media, which wasn't possible so far. PiperOrigin-RevId: 453625204 (cherry picked from commit bd126ec5)
tonihei committed -
PiperOrigin-RevId: 453490088 (cherry picked from commit a2a45043)
Marc Baechinger committed
-
- 07 Jun, 2022 6 commits
-
-
#minor-release PiperOrigin-RevId: 453408087 (cherry picked from commit 62497f23)
christosts committed -
The current setup with distinct, private `keyForField` implementations, leaves open the (theoretical) possibility of a clash in the `Bundle` keys used by the superclass and subclass. This change brings consistency with our only other extensible `Bundleable` type (`PlaybackException`). #minor-release PiperOrigin-RevId: 453385875 (cherry picked from commit 814e43db)
ibaker committed -
We generally nest the `Builder` for `Foo` inside `Foo`. In this case, there's already a `DefaultTrackSelector.Parameters.Builder` type visible to a developer, it just happens to be the 'common' `TrackSelectorParameters.Builder`, so using it is a bit weird. For example this code snippet doesn't compile because `DefaultTrackSelector.Parameters.Builder#build()` returns `TrackSelectionParameters`. This CL fixes that problem and the code snippet now compiles. ```java DefaultTrackSelector.Parameters params = new DefaultTrackSelector.Parameters.Builder(context).build() ``` #minor-release PiperOrigin-RevId: 453215702 (cherry picked from commit 247c2d84)
ibaker committed
-
- 31 May, 2022 7 commits
-
-
This should fix running `./gradlew clean test` if MediaPipe hasn't been built, for example. PiperOrigin-RevId: 452033698 (cherry picked from commit 208a9114)
andrewlewis committed -
This reinstates the permissive behaviour removed by https://github.com/androidx/media/commit/fe7e5b8181333683fda7869c3d9cffc0bdefcccb Test file created by opening bear.opus in a hex editor and naively duplicating the two header packets, starting at (and including) the first `OggS` in the file and ending just before the third `OggS`. #minor-release Issue: google/ExoPlayer#10038 PiperOrigin-RevId: 452015662 (cherry picked from commit 12821758)
ibaker committed -
This ensures the 'use X instead' message is easily visible in the generated HTML for the overriding method. Currently it's not, e.g.: https://exoplayer.dev/doc/reference/com/google/android/exoplayer2/BasePlayer.html#getCurrentWindowIndex() #minor-release PiperOrigin-RevId: 452002224 (cherry picked from commit b8ca5b89)
ibaker committed
- 30 May, 2022 21 commits
-
-
The current verion of AGP warns it doesn't support Android API 32 [1]. The wrapper was upgraded with ([instructions](https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:upgrading_wrapper)): ```shell $ ./gradlew wrapper --gradle-version 7.4.2 --distribution-type all ``` [1] ``` WARNING:We recommend using a newer Android Gradle plugin to use compileSdk = 32 This Android Gradle plugin (7.0.3) was tested up to compileSdk = 31 This warning can be suppressed by adding android.suppressUnsupportedCompileSdk=32 to this project's gradle.properties The build will continue, but you are strongly encouraged to update your project to use a newer Android Gradle Plugin that has been tested with compileSdk = 32 ``` #minor-release PiperOrigin-RevId: 451893214 (cherry picked from commit 3ba9d7e1)
ibaker committed -
Marc Baechinger committed
-
Gives a bit more information upon failures PiperOrigin-RevId: 451882968
aquilescanta committed -
PiperOrigin-RevId: 451875964
bachinger committed -
The classes were renamed to `PlaceholderXXX` in https://github.com/androidx/media/commit/33373d0d0a159ad9c9c3590c838098c4c1530910 #minor-release PiperOrigin-RevId: 451872006
ibaker committed -
This provides an (unstable) API for apps to broadcast session extras Bundle to all connected controllers and set the extras in the legacy session. Similar to the custom layout, the extras Bundle is not part of the Media3 session state. This means that when a Media3 controller connects to the session after the broadcast, the extras needs to be sent to that controller in `MediaSession.Callback.onPostConnect(MediaSession session, ControllerInfo controller)`. PiperOrigin-RevId: 451871731
bachinger committed -
Add bitrate check to the "can encode" criteria. PiperOrigin-RevId: 451868042
claincly committed -
PiperOrigin-RevId: 451859199
bachinger committed -
PiperOrigin-RevId: 451857459
bachinger committed -
This value only existed to allow setting media URLs from external sources (e.g. in a MediaController) so that a player can start playing this item. Now that we have MediaItem.RequestMetadata.mediaUrl we can remove this value from MediaMetadata because it's request metadata, not media metadata. PiperOrigin-RevId: 451857413
tonihei committed -
The MediaItemFiller is not flexible enough for most realworld usages because: - it doesn't allow asynchronous resolution of MediaItems (e.g. to look up URIs from a database) - it doesn't allow to batch updates for multiple items or do more advanced customizations (e.g. expanding a mediaId representing a playlist to multiple items). Both issues can be solved by passing in a list of items and returning a ListenableFuture. The callback itself can also move into MediaSession.Callback for consistency with the other callbacks. PiperOrigin-RevId: 451857319
tonihei committed -
The MockPlayer currently: - uses separate fields for single mediaItem vs multiple mediaItems - replaces all items on addMediaItem operations - does nothing on remove/move operations. Fix all of this by using a single field that replicates the player operations directly. Some tests also need to be updated to make them more realistic (for example only removing items from a playlist that have previously been added). PiperOrigin-RevId: 451857271
tonihei committed -
In some cases it's helpful to have access to the session (e.g. to get the PlayerWrapper) from within the PostSessionTask implementations. This change forwards the existing sessionImpl instance to all these callbacks. PiperOrigin-RevId: 451857191
tonihei committed -
These fields can be used to transport additional request properties when the requester doesn't know the details needed for the actual playback (i.e. the LocalConfiguration). PiperOrigin-RevId: 451857093
tonihei committed -
ExoPlayer applies a large time offset to buffers so that, if the input has negative timestamps, generally buffers seen by the decoders should have positive timestamps. Modify how the offset is handled in `Transformer` so that decoders and encoders generally see positive timestamps, by leaving the offset on samples when reading them in the base renderer (remove the code that removed the offset), and then removing the offset when muxing. Also update the frame processor chain and slow motion flattening code to retain the existing behavior after this change (these both need original media presentation timestamps) Tested via existing end-to-end tests and manually verified that the overlay frame processor shows the expected original media timestamps. Aside: we don't need the same logic as ExoPlayer to track stream offsets across the decoder yet, because we don't try to handle stream changes during playback in single asset editing. (There is an edge case of multi-period DASH that may not work but I doubt anyone will use that as input to `Transformer` before we change the code to handle multi-asset properly.) In future we should try to refactor interaction with the decoder to use the same code for Transformer and ExoPlayer. PiperOrigin-RevId: 451846055
andrewlewis committed -
PiperOrigin-RevId: 451831531
ibaker committed -
PiperOrigin-RevId: 451824740
bachinger committed -
PiperOrigin-RevId: 451428202
samrobinson committed -
Most devices won't support 8k decoding, so they'll skip this test entirely. As the video is quite short, this test shouldn't be any longer than the nearby, long-running 4k60 test. PiperOrigin-RevId: 451423368
huangdarwin committed -
PiperOrigin-RevId: 451410714
bachinger committed -
PiperOrigin-RevId: 451392021
samrobinson committed
-