- 10 May, 2022 1 commit
-
-
This constant is used for https://docs.gl/es2/glVertexAttribPointer which takes the number of components per generic vertex attribute (meaning the size of the individual coordinate vectors here) not the number of attributes (the number of vertices that the old constant name referred to). PiperOrigin-RevId: 447427241
hschlueter committed
-
- 09 May, 2022 39 commits
-
-
As defined in Kush Amerasinghe's paper 'H.264 For the rest of us'. PiperOrigin-RevId: 446988272
samrobinson committed -
Before this change, we list the formats for which we don't want transcoding. This change disables transcoding altogether. This was tested by checking that transcoding takes place on a short camera recording only when the added flag is not present (and AndroidManifest does not declare support for HEVC). PiperOrigin-RevId: 446986580
aquilescanta committed -
We won't try to provide/rethrow helpful error messages that are already provided by GL, as this sort of task would expand into writing a GL verifier. A Gl verifier is unnecessarily complex for minimal payoff, especially as Apps expected to read GL error messages would mostly be those writing custom GlFrameProcessors, who should be already be familiar with reading GL error messages anyways. PiperOrigin-RevId: 446950837
huangdarwin committed -
RawCC is a Google-internal subtitle format, and is no longer used with ExoPlayer. PiperOrigin-RevId: 446950691
ibaker committed -
The texture coordinates can be derived from the frame coordinates. PiperOrigin-RevId: 446770538
hschlueter committed -
Remove PlayerNotificationManager and DefaultMediaDescriptionAdapter which are unused in session. The functionality is covered by the MediaNotification.Provider. PiperOrigin-RevId: 446687875
christosts committed -
Relates to https://github.com/square/okhttp/issues/3146. This was from https://github.com/androidx/media/pull/71. There is a draft PR https://github.com/square/okhttp/pull/7185/files which documents OkHttp's ideal handling of cancellation including interrupts. But a few key points 1) This is a target state, and OkHttp does not currently handle interrupts correctly. In the past this has been identified, and the advice is to avoid interrupts on Http threads, see discussion on https://github.com/square/okhttp/issues/1902. Also an attempt at a fix here https://github.com/square/okhttp/pull/7023 which wasn't in a form to land. 2) Even with this fixed, it is likely to never be optimal, because of OkHttp sharing a socket connection for multiple inflight requests. From https://github.com/square/okhttp/pull/7185 ``` Thread.interrupt() is Clumsy ---------------------------- `Thread.interrupt()` is Java's built-in mechanism to cancel an in-flight `Thread`, regardless of what work it's currently performing. We recommend against using `Thread.interrupt()` with OkHttp because it may disrupt shared resources including HTTP/2 connections and cache files. In particular, calling `Thread.interrupt()` may cause unrelated threads' call to fail with an `IOException`. ``` This PR leaves the Loader/DataSource thread parked on a countdown latch, while this may seem wasteful and an additional context switch. However in practice the response isn't returned until the Http2Connection and Http2Reader have a response from the server and these means effectively parking in a `wait()` statement here https://github.com/square/okhttp/blob/9e039e94123defbfd5f11dc64ae146c46b7230eb/okhttp/src/jvmMain/kotlin/okhttp3/internal/http2/Http2Stream.kt#L140 PiperOrigin-RevId: 446652468
yschimke committed -
ScaleToFitFrameProcessor, PresentationFrameProcessor, and EncoderCompatibilityFrameProcessor now each implement MatrixTransformation instead of wrapping MatrixTransformationFrameProcessor. PiperOrigin-RevId: 446480286
hschlueter committed -
Refactoring change only. PiperOrigin-RevId: 446475708
huangdarwin committed -
The TrackSelector is released when the player is released. The TrackSelector can be reused if TrackSelector.init() is called again. PiperOrigin-RevId: 446439717
christosts committed -
PiperOrigin-RevId: 446432695
andrewlewis committed -
PiperOrigin-RevId: 446425897
bachinger committed -
PiperOrigin-RevId: 446423017
olly committed -
PiperOrigin-RevId: 446400371
ibaker committed -
PiperOrigin-RevId: 446400192
ibaker committed -
This change splits AdvancedFrameProcessor into 4 files: - MatrixTransformationFrameProcessor for the GlFrameProcessor implementation - MatrixTransformation and GlMatrixTransformation for the GlEffect specification - MatrixUtils for the static matrix helpers PiperOrigin-RevId: 446236384
hschlueter committed -
PiperOrigin-RevId: 446181877
christosts committed -
https://github.com/androidx/media/commit/0f80d5a9f0643937d6b578c33e30004c917f0a0c
*** Original commit *** Upgrade Robolectric dependency to 4.8 *** PiperOrigin-RevId: 446175705
christosts committed -
Some APIs from Android 12L were used either via reflection or constants values were hard-coded. We can now use these APIs directly since we upgraded the compile SDK version to 32. PiperOrigin-RevId: 446167543
christosts committed -
PiperOrigin-RevId: 446161354
ibaker committed -
It's reasonable to serialize this type to support backgrounding use-cases, as demonstrated by the main demo app. PiperOrigin-RevId: 446161300
ibaker committed -
PiperOrigin-RevId: 446156308
ibaker committed -
PiperOrigin-RevId: 446143537
hschlueter committed -
PiperOrigin-RevId: 445973162
olly committed -
PiperOrigin-RevId: 445445952
olly committed -
These listeners cover controller visibility and fullscreen button clicks. PiperOrigin-RevId: 445420757
ibaker committed -
This is used from the main demo app. PiperOrigin-RevId: 445420580
ibaker committed -
Overriding any methods of AnalyticsListener requires using the unstable API. In future we can incrementally add AnalyticsListener methods to the stable API. PiperOrigin-RevId: 445420361
ibaker committed -
This ensures that both content and licenses are requested using the same HTTP stack. #minor-release PiperOrigin-RevId: 445378940
ibaker committed -
Also add warning for what can happen if this is ignored. Previously the return value was overridden by setOutputSurface, now setOutputSurface only overrides the values using internally. PiperOrigin-RevId: 445377036
hschlueter committed -
These are used by the main demo app and would be reasonably used by other relatively simple media playback apps. PiperOrigin-RevId: 445371266
ibaker committed -
These are used in the main demo app PiperOrigin-RevId: 445369540
ibaker committed -
Developers are expected to (eventually) only use methods on PlayerView (and not PlayerControlView) to interact with the UI controller. PiperOrigin-RevId: 445361488
ibaker committed -
PiperOrigin-RevId: 445356625
ibaker committed -
This is consistent with the IntDef name, and frees up the CONTENT_TYPE_ prefix for the @ContentType values (which are currently just TYPE_*, and therefore ambiguous with lots of other 'type' values in C). PiperOrigin-RevId: 445356476
ibaker committed -
PiperOrigin-RevId: 445219759
bachinger committed -
PiperOrigin-RevId: 445217294
ibaker committed -
This method was introduced in https://github.com/androidx/media/commit/e414f0d2ac02a0414bb3bd56743874ed014fb3fa as a replacement for Util.inferContentType(String) but it incorrectly didn't return TYPE_SS when passed "ism" or "isml". PiperOrigin-RevId: 445217167
ibaker committed -
PiperOrigin-RevId: 445196313
olly committed
-