- 26 Apr, 2021 4 commits
-
-
PiperOrigin-RevId: 370407108
Andrew Lewis committed -
* @Nullable is not a TYPE_USE annotation, so should appear before any modifiers and after Javadocs. (see go/java-style#s4.8.5-annotations) This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Suggest a fix on the CL (go/how-to-suggest-fix). * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/exoplayer/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth PiperOrigin-RevId: 370377751
olly committed -
Add method getAvailableCommands() in Player interface to return the available commands. Method isCommandAvailable() moved to BasePlayer since it can be implelented by calling getAvailableCommands(). PiperOrigin-RevId: 370059328
christosts committed -
* @Encoding is not a TYPE_USE annotation, so should appear before any modifiers and after Javadocs. (see go/java-style#s4.8.5-annotations) (2 times) * @Nullable is not a TYPE_USE annotation, so should appear before any modifiers and after Javadocs. (see go/java-style#s4.8.5-annotations) (2 times) This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Suggest a fix on the CL (go/how-to-suggest-fix). * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/exoplayer/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth PiperOrigin-RevId: 370048160
olly committed
-
- 23 Apr, 2021 1 commit
-
-
PiperOrigin-RevId: 369934240
olly committed
-
- 22 Apr, 2021 1 commit
-
-
Abel Jimenez committed
-
- 21 Apr, 2021 20 commits
-
-
Issue: #8845 PiperOrigin-RevId: 369685031
olly committed -
PiperOrigin-RevId: 369671127
samrobinson committed -
Also consolidate the threading warning info with the same info on the hello world page and update the version that the setThrowsWhenUsingWrongThread() method will be removed in. PiperOrigin-RevId: 369657759
ibaker committed -
Remove spurious blank lines introduced in https://github.com/google/ExoPlayer/commit/dafea4e40fb5eba91597cf16cab06140ebaaaff4 PiperOrigin-RevId: 369648457
ibaker committed -
PiperOrigin-RevId: 369642047
ibaker committed -
PiperOrigin-RevId: 369635363
olly committed -
A subsequent change will make the UI module access SphericalGLSurfaceView and VideoDecoderGLSurfaceView using reflection, now we're at the point where we only need to reflect the constructors. PiperOrigin-RevId: 369630102
olly committed -
PiperOrigin-RevId: 369626542
olly committed -
PiperOrigin-RevId: 369615413
olly committed -
andrewlewis committed
-
PiperOrigin-RevId: 369609585
andrewlewis committed -
https://github.com/google/ExoPlayer/commit/09096d6fbf5532728ab675d2d1ccefc3daa0bb03
*** Original commit *** Rollback of https://github.com/google/ExoPlayer/commit/e60609e34447553474cdfc86b2dee5462316b10c *** Original commit *** Prevent creation of new sessions if the Timeline is empty. We currently create sessions based on the placeholder window index. This shouldn't be needed as we now set a non-empty timeline as soon as the first MediaItem... *** PiperOrigin-RevId: 369609523
tonihei committed -
See go/media-apis-codebase-google3. PiperOrigin-RevId: 369603286
andrewlewis committed -
Issue: #8804 PiperOrigin-RevId: 369484117
olly committed -
The protected visibility causes problems in Kotlin (Issue: #8830) and also prevents a subclass of AdaptiveTrackSelection.Factory that isn't nested inside a subclass of AdaptiveTrackSelection (in both Java and Kotlin). #minor-release PiperOrigin-RevId: 369468841
ibaker committed -
https://github.com/google/ExoPlayer/commit/e60609e34447553474cdfc86b2dee5462316b10c
*** Original commit *** Prevent creation of new sessions if the Timeline is empty. We currently create sessions based on the placeholder window index. This shouldn't be needed as we now set a non-empty timeline as soon as the first MediaItem is added to the playlist. Once this check is part of the session manager, we can also remove the equivalent workarounds from the various code integrations. *** PiperOrigin-RevId: 369452067
olly committed -
PiperOrigin-RevId: 369444747
olly committed -
PiperOrigin-RevId: 369443204
andrewlewis committed -
PiperOrigin-RevId: 369442687
olly committed -
This method shouldn't be used anymore since the thread enforcement is the default already. We still keep it for now to ease the transition for apps that use ExoPlayer on multiple threads and want to temporarily disable the enforcement while the threading problems are fixed. PiperOrigin-RevId: 369440789
tonihei committed
-
- 20 Apr, 2021 7 commits
-
-
PiperOrigin-RevId: 369433627
olly committed -
We currently create sessions based on the placeholder window index. This shouldn't be needed as we now set a non-empty timeline as soon as the first MediaItem is added to the playlist. Once this check is part of the session manager, we can also remove the equivalent workarounds from the various code integrations. PiperOrigin-RevId: 369432853
tonihei committed -
See go/media-apis-codebase-google3. PiperOrigin-RevId: 369425137
andrewlewis committed -
Oliver Woodman committed
-
PiperOrigin-RevId: 369425007
Oliver Woodman committed -
The original cl has been fixed by not implementing VideoListener but Player.Listener in StyledPlayerView. VideoFrameMetadataListener and CameraMotionListener are still part of the Player interface as a good way to break the UI dependency on them has not yet been finalised. PiperOrigin-RevId: 369417682
krocard committed -
PlayerView is not affected. PiperOrigin-RevId: 369401563
krocard committed
-
- 19 Apr, 2021 7 commits
-
-
PiperOrigin-RevId: 369315524
olly committed -
This change moves the responsibility of creating, configuring and starting the MediaCodec from the MediaCodecRender to the MediaCodecAdapter.Factory. This move allows ExoPlayer's client to decide how and when codecs are created and/or reused. To allow the move, this CL replaces MediaCodecRenderer.ConfigureCodec with MediaCodecRenderer.getCodecConfiguration PiperOrigin-RevId: 369273887
olly committed -
PiperOrigin-RevId: 369215083
Oliver Woodman committed -
This was likely an oversight when first importing #4930. PiperOrigin-RevId: 369199775
tonihei committed -
https://github.com/google/ExoPlayer/commit/cdebf6c68b0f76360d78114dcb47c58e63b354a7
*** Original commit *** Move VideoComponent in ExoPlayer VideoFrameMetadataListener and CameraMotionListener are still part of the Player interface as a good way to break the UI dependency on them has not yet been finalised. *** PiperOrigin-RevId: 369194309
ibaker committed -
* Prefer instanceof to getClass when implementing Object#equals. (see http://go/bugpattern/EqualsGetClass) This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Suggest a fix on the CL (go/how-to-suggest-fix). * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/error-prone-bug for category ErrorProneFragileCode if the change looks generally problematic. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/exoplayer/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/exoplayer/METADATA. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth PiperOrigin-RevId: 369180513
olly committed -
VideoFrameMetadataListener and CameraMotionListener are still part of the Player interface as a good way to break the UI dependency on them has not yet been finalised. PiperOrigin-RevId: 368863829
krocard committed
-