Commits · 242a0053c96afdccd4654786e299b4df168f0ef0 · SDK / exoplayer

05 Nov, 2019 21 commits
- Add method to read more than 32 bits in ParsableBitArray · 242a0053
```
PiperOrigin-RevId: 277766372
```
  kimvde committed Nov 05, 2019
  242a0053
- Improve ParsableBitArray unit tests · 32dcd80b
```
PiperOrigin-RevId: 277744735
```
  kimvde committed Nov 05, 2019
  32dcd80b Browse Files
- Fix field-can-be-local warnings · 981008f7
```
PiperOrigin-RevId: 277732159
```
  olly committed Nov 05, 2019
  981008f7 Browse Files
- Minor DRM documentation tweaks · f55083ab
```
PiperOrigin-RevId: 277729887
```
  olly committed Nov 05, 2019
  f55083ab Browse Files
- Increase 2 timeouts to reduce test flakiness · f554dc4e
```
PiperOrigin-RevId: 277710160
```
  ibaker committed Nov 05, 2019
  f554dc4e Browse Files
- Remove unnecessary warning suppressions · d596fcd9
```
PiperOrigin-RevId: 277709114
```
  olly committed Nov 05, 2019
  d596fcd9 Browse Files
- Fix subtitle parsing regex suggestions · a7b24299
```
Suggested by Android Studio's Inspect Code

SO seems to think there's a performance difference for the | change:
https://stackoverflow.com/questions/22132450/why-is-a-character-class-faster-than-alternation

PiperOrigin-RevId: 277707341
```
  ibaker committed Nov 05, 2019
  a7b24299 Browse Files
- Remove pointless arithmetic · 5ff7f3a1
```
PiperOrigin-RevId: 277706810
```
  olly committed Nov 05, 2019
  5ff7f3a1
- Forward suppression state to new playback stats sessions. · f960f8a5
```
The value is stateful and new sessions need to be informed of the current state

PiperOrigin-RevId: 277701955
```
  tonihei committed Nov 05, 2019
  f960f8a5 Browse Files
- add default methods isSingleWindow and getInitialTimeline to MediaSource interface · 01a4cf98
```
PiperOrigin-RevId: 277695826
```
  bachinger committed Nov 05, 2019
  01a4cf98
- Add tests for SampleQueue isReady · df251ad1
```
PiperOrigin-RevId: 277691935
```
  aquilescanta committed Nov 05, 2019
  df251ad1 Browse Files
- Make FormatHolder be entirely populated by SampleMetadataQueue · 2d530478
```
This should not introduce any functional changes.

PiperOrigin-RevId: 277691550
```
  aquilescanta committed Nov 05, 2019
  2d530478 Browse Files
- Fix detection of Dolby Atmos in HLS · fbea71b0
```
E-AC3 with JOC is signaled using the CHANNELS attribute for HLS:
https://developer.apple.com/documentation/http_live_streaming/hls_authoring_specification_for_apple_devices/hls_authoring_specification_for_apple_devices_appendices

PiperOrigin-RevId: 277680300
```
  andrewlewis committed Nov 05, 2019
  fbea71b0 Browse Files
- Fix throws in DashStreamingTest · 149ea905
```
Some methods marked as throwing DecoderQueryException actually
did not throw it. Switch to marking throws Exception
everywhere.

PiperOrigin-RevId: 277674401
```
  andrewlewis committed Nov 05, 2019
  149ea905
- Encode WebVTT size computation in WebvttCue.java · f5377d9b
```
Relevant part of the spec:
https://www.w3.org/TR/webvtt1/#processing-cue-settings

PiperOrigin-RevId: 277523694
```
  ibaker committed Nov 05, 2019
  f5377d9b Browse Files
- Switch (Mp4)WebvttDecoderTest to use Truth's Expect · d29d4526
```
This means multiple failures are all logged, instead of the test
stopping when the first assertion fails. Makes tests like this with
lots of independent assertions much easier to work with.

I limited the expect to a single assertCues() call, otherwise
the error message gets very long and is hard to read, but I
still think this is an improvement.

PiperOrigin-RevId: 277523300
```
  ibaker committed Nov 05, 2019
  d29d4526 Browse Files
- Update WebvttCue to use defaults from the spec · b3f94e37
```
Cue's UNSET and null values should be used when the source data
doesn't specify *and* the spec doesn't provide a clear default.
In the WebVTT case, the defaults are clear, so we use them
explicitly.

PiperOrigin-RevId: 277522899
```
  ibaker committed Nov 05, 2019
  b3f94e37
- Add @Documented and JavaDoc to HlsMetadataType. · 0c633622
```
PiperOrigin-RevId: 277519718
```
  tonihei committed Nov 05, 2019
  0c633622 Browse Files
- Add new MIME types to EnumerateDecodersTest · 7701c883
```
PiperOrigin-RevId: 277489763
```
  andrewlewis committed Nov 05, 2019
  7701c883 Browse Files
- Rename the option allowPlaceholderSessions to preferSecureDecoders · 18e1c3eb
```
PiperOrigin-RevId: 277477784
```
  aquilescanta committed Nov 05, 2019
  18e1c3eb Browse Files
- Fix MediaCodecUtil nullability annotations · aeefb79a
```
PiperOrigin-RevId: 277462799
```
  andrewlewis committed Nov 05, 2019
  aeefb79a Browse Files
30 Oct, 2019 19 commits

Recreate Opus decoder for stream change · d3933e5c

The framework opus decoder discards some samples after a call to
flush(). Because we flush a decoder that is being retained across an
input format change, this means that the start of audio gets truncated
when transitioning to a new opus stream. See also
https://android.googlesource.com/platform/frameworks/av/+/refs/heads/android10-release/media/libstagefright/codecs/opus/dec/SoftOpus.cpp.

Avoid this by recreating opus decoders instead of flushing them. It
seems fine to do this for all opus decoders as reinitialization should
be cheap, OEM-provided implementations may also discard samples and
playback shouldn't be interrupted on reinitialization due to the
downstream AudioTrack buffer.

PiperOrigin-RevId: 277458759

committed Oct 30, 2019

d3933e5c Browse Files

Change nested ternary to switch in SubtitlePainter · e922f834

The nested ternary is quite hard to read imo, and I believe this is a
no-op change that captures the intent more clearly.

PiperOrigin-RevId: 277320461

committed Oct 30, 2019

e922f834 Browse Files

Add explicit dependency on appcompat for demo app · a3d1ab69

The demo app was using this via its dependency on the material library,
but it's preferable to list dependencies explicitly (otherwise the build
would break if we removed the material dependency).

PiperOrigin-RevId: 277316175

committed Oct 30, 2019

a3d1ab69

Replace usages of SampleQueue.hasNextSample with isReady · 8138424d
```
PiperOrigin-RevId: 277259448
```
aquilescanta committed Oct 30, 2019
8138424d Browse Files
Add shuffle and repeat modes to media session playback state invalidation · 0f312561
```
Which ensures both get updated when the MediaSessionConnector player
changes.

Issue:#6582
PiperOrigin-RevId: 277254889
```
aquilescanta committed Oct 30, 2019
0f312561 Browse Files
Move peek result constants into SampleMetadataQueue · 81b8396b
```
PiperOrigin-RevId: 277253308
```
aquilescanta committed Oct 30, 2019
81b8396b Browse Files
Add uncontroversial HLS nullness annotations · 817772fc
```
This helps get HlsMediaPeriod off the blacklist.

PiperOrigin-RevId: 277076633
```
ibaker committed Oct 30, 2019
817772fc Browse Files

Change HlsPlaylistParser.LineIterator#next() · 87c30c0b

Update it to throw if hasNext() is false, to match Java's Iterator
interface.

This also simplifies the null-checking annotations required

PiperOrigin-RevId: 277059766

committed Oct 30, 2019

87c30c0b Browse Files

Add tests for playWhenReady masking · bae2b1e4
```
PiperOrigin-RevId: 277057328
```
aquilescanta committed Oct 30, 2019
bae2b1e4 Browse Files
Fix a bunch of typos · 9eb93a35
```
PiperOrigin-RevId: 277056574
```
aquilescanta committed Oct 30, 2019
9eb93a35 Browse Files

Fix incorrect anamorphic handling in Leanback extension · 8ec6cf15

The leanback library doesn't know about non-square pixels. So if
we're playing content that uses non-square pixels, we need to adjust
the video dimensions that we provide to leanback such that it
renders the video with the correct aspect ratio.

PiperOrigin-RevId: 277042560

committed Oct 30, 2019

8ec6cf15

Remove @NonNull where it's implied by @NonNullApi · 7277df35

Also remove it from all tests, these aren't covered by the null-checker

Covered by the following package-info.java files:
- j/c/g/a/exoplayer2/ext/mediasession/package-info.java
- j/c/g/a/exoplayer2/package-info.java
- j/c/g/a/exoplayer2/offline/package-info.java
- j/c/g/a/exoplayer2/video/package-info.java
- j/c/g/a/exoplayer2/ui/package-info.java

PiperOrigin-RevId: 277038916

committed Oct 30, 2019

7277df35

Make SampleQueue populate FormatHolder.drmSession · b68a6988
```
Also add unit tests for SampleQueue read for samples with
DRM requirements.

PiperOrigin-RevId: 277037826
```
aquilescanta committed Oct 30, 2019
b68a6988 Browse Files
Fix memory leak and calling listener when disabled in AudioBecomingNoisyManager. · e0253714
```
PiperOrigin-RevId: 277030401
```
samrobinson committed Oct 30, 2019
e0253714 Browse Files
Add player release check to enabling audio focus & audio becoming noisy handling. · ff82a132
```
PiperOrigin-RevId: 276679790
```
samrobinson committed Oct 30, 2019
ff82a132 Browse Files

Rollback of https://github.com/google/ExoPlayer/commit/665627c3843ebf7a83e62e2f01f9e663a1dad32e · 719a704d

*** Original commit ***

Rollback of https://github.com/google/ExoPlayer/commit/bf01ff0f60930427cb8a31e88fcad009d89132cc

*** Original commit ***

Use Float.NaN for Cue#DIMEN_UNSET

Float.MIN_VALUE is very close to zero:
"A constant holding the smallest positive nonzero value of type float"
https://developer.android.com/reference/java/lang/Float.html#MIN_VALUE

Float.NaN more clearly conveys this is an invalid number,
and will also more clearly carry over if we do maths on it a...

***

PiperOrigin-RevId: 276674142

committed Oct 30, 2019

719a704d Browse Files

Clarify naming & comments for distinction between Format and MediaFormat. · ea77defd
```
PiperOrigin-RevId: 276673410
```
samrobinson committed Oct 30, 2019
ea77defd Browse Files
Remove HlsPlaylistParser from null-checking blacklist · ac722a7a
```
PiperOrigin-RevId: 276671167
```
ibaker committed Oct 30, 2019
ac722a7a Browse Files
Document error handling in the Extractor interface · 620b9110
```
PiperOrigin-RevId: 276660235
```
aquilescanta committed Oct 30, 2019
620b9110 Browse Files