- 14 Oct, 2022 4 commits
-
-
PiperOrigin-RevId: 481143798 (cherry picked from commit f9724e9f)
huangdarwin committed
- 17 Oct, 2022 1 commit
-
-
PiperOrigin-RevId: 481115402 (cherry picked from commit 172cae47)
Marc Baechinger committed
-
- 13 Oct, 2022 4 commits
-
-
We already have logic to end all session except the current one if the current one doesn't have a MediaPeriodId yet. This is assuming that this only happens after a seek on the app side where the player doesn't have detailled knowledge about the MediaPeriodIds yet. Currently this logic isn't triggered if the window we are coming from doesn't have its MediaPeriodId either as we run into another check that keeps sessions around until we have a valid windowSequenceNumber. Swapping both conditions fixes this case without breaking any of the other known transition scenarios. Issue: androidx/media#180 PiperOrigin-RevId: 480866465 (cherry picked from commit 409c9f87)
tonihei committed
-
- 12 Oct, 2022 3 commits
-
-
When debugging and fixing Issue: google/ExoPlayer#10666 I wanted to write a regression test, but needed to add a test first... This is just a small bit of coverage to start with. It checks the field/channel filtering works correctly, but doesn't check any styling info. It also doesn't test 'pop on' subtitles (i.e. when the subtitle isn't shown until a 'end of subtitle' signal is received). PiperOrigin-RevId: 480644568 (cherry picked from commit 706b1299)
ibaker committed -
Most demo videos aren't very long, and the default demo video is only 10 seconds. Shorten the maximum trim duration to 10 seconds, to demonstrate transformer functionality more easily, and allow this to be used more easily when trimming short sections of a longer video (ex. to make test clips) PiperOrigin-RevId: 480602037 (cherry picked from commit f35bda35)
huangdarwin committed -
Player controls are somewhat distracting when showing the difference between the input and output video, as they obscure and darken the video players. PiperOrigin-RevId: 480597804 (cherry picked from commit 51edb329)
huangdarwin committed
-
- 11 Oct, 2022 2 commits
-
-
Before, slider values were read as `floor()`'ed `longValue()`s, so that trimming to intervals less than one second would be interpreted as a request for a zero- duration trim. Also, rename `radiusRange` references here to `trimRange`, since this is not a radius range. PiperOrigin-RevId: 480401556 (cherry picked from commit fb5cd18d)
huangdarwin committed
-
- 10 Oct, 2022 6 commits
-
-
Fix a race condition making test flaky. PiperOrigin-RevId: 480104467 (cherry picked from commit cb3a6725)
christosts committed -
We currently use the literal -1 (=NO_VALUE) when adding up the total. Tracks without known bitrate can be ignored in the calculation, but we should use an explicit value of 0. #minor-release Issue: google/ExoPlayer#10664 PiperOrigin-RevId: 480048126 (cherry picked from commit b0daae72)
tonihei committed -
PiperOrigin-RevId: 480041937 (cherry picked from commit 6f8863fc)
christosts committed -
If the sample type is Dolby Vision and the display does not support Dolby Vision, then the capabilities DecoderSupport flag is set to DECODER_SUPPORT_FALLBACK_MIMETYPE. This denotes that the renderer will use a decoder for a fallback mimetype if possible. This alters track selection as tracks with DecoderSupport DECODER_SUPPORT_PRIMARY are preferred. UnitTests included -DefaultTrackSelector test that checks track selection reordering with DECODER_SUPPORT_FALLBACK_MIMETYPE -MediaCodecVideoRenderer test that checks setting of DecoderSupport flag based on Display's Dolby Vision support Issue: google/ExoPlayer#8944 PiperOrigin-RevId: 480040876 (cherry picked from commit 266de1b2)
michaelkatz committed -
Replace the instance-field MediaController with a local instance created in each test. PiperOrigin-RevId: 480039768 (cherry picked from commit ba1ecafb)
christosts committed -
PlayableFolderActivity currently uses two seperate commands to set the playlist and then seek to the requested item. This is slightly inefficient and also causes analytics listeners to believe the first item in the playlist was briefly active. #minor-release Issue: androidx/media#180 PiperOrigin-RevId: 480031682 (cherry picked from commit 5d6d069e)
tonihei committed
-
- 07 Oct, 2022 5 commits
-
-
Currently, a frame is dropped if it's requested release time is in the past. This mode was added to support previewing. However, in normal ExoPlayer playback, slightly late frames (<30ms late) are also rendered. On MediaCodec side, this means calling `releaseOutputBuffer` with a release time in the past. PiperOrigin-RevId: 479615291 (cherry picked from commit a426cb27)
claincly committed -
Remove static imports to constants and imports to intdefs, to make the code more readable. PiperOrigin-RevId: 479594144 (cherry picked from commit 36e12fba)
christosts committed -
PiperOrigin-RevId: 479579252 (cherry picked from commit 49bfca54)
christosts committed -
Also, update tests to allow AnyOf error codes, and no longer check exception messages, which caused quite a bit of churn. PiperOrigin-RevId: 479570861 (cherry picked from commit 8548e351)
huangdarwin committed
-
- 06 Oct, 2022 3 commits
-
-
PiperOrigin-RevId: 479268879 (cherry picked from commit 0beccb6e)
aquilescanta committed -
* Add `setOutputStreamOffsetUs(long)` method in `AudioSink`. * Add private methods `setOutputStreamOffsetUs(long)` method in `MediaCodecRenderer` and `DecoderAudioRenderer`. * Add protected method `onOutputStreamOffsetUs(long)` method in `MediaCodecRenderer`, in which: * `MediaCodecRenderer` itself will be no-op for this method. * `MediaCodecAudioRenderer` will propagate this value to its `audioSink`. * Add logics in `DecoderAudioRenderer` to calculate `outputStreamOffsetUs`. PiperOrigin-RevId: 479265429 (cherry picked from commit 5bff8623)
tianyifeng committed
- 05 Oct, 2022 4 commits
-
-
PiperOrigin-RevId: 479079184 (cherry picked from commit bf948db6)
christosts committed -
Currently `FrameProcessor.releaseOutputFrame()` method supports Release at a specific system time Drops the frame This API is not that convenient to use when the caller wants to release a frame, now, regardless of the release time. A use case is to release (present) a frame when no frame is shown for a while, and it's thus better to just release the frame, now. Currently if MCVR wants a frame to be rendered now, MCVR calls release frame with a set offset like 10us: `releaseOutputFrame(System.nanoTime() + 10_000)`. The 10us offset is to prevent the frame processor dropping the frame, due to thread hopping delays. To make the API better usable, consider adding a mode for releasing the frame now, like (bold marks the new mode) - Use C.TIME_UNSET to drop - **Use -1 to release the frame immediately, or** - Use an actual release time. PiperOrigin-RevId: 479044215 (cherry picked from commit 139a6e8d)
claincly committed
-
- 04 Oct, 2022 2 commits
-
-
Assert that tone mapping is applied when an HDR edit cannot be HDR, but is successfully tone mapped. Meanwhile, assert that fallback, which is applied after codec configuration (which throws the "Tone-mapping requested but not supported by the decoder" error) is not applied when that error is called. PiperOrigin-RevId: 478762951 (cherry picked from commit 253486d4)
huangdarwin committed -
When a media service currently produces multiple media sessions, the notification of the second session overwrites the notification of the first one, because all sessions use the same notification ID. When we use different notification IDs for different sessions, multiple media notifications can be up at the same time, which means that they can both be controlled at the same time. PiperOrigin-RevId: 478709069 (cherry picked from commit 7783c6e4)
Googler committed
-
- 03 Oct, 2022 1 commit
-
- 30 Sep, 2022 3 commits
-
-
PiperOrigin-RevId: 478019046 (cherry picked from commit 6e5a4c05)
huangdarwin committed -
"Final" was likely added to reference the FinalMatrixTextureProcessorWrapper, which is a package-private class. However, I think more clear to express that this is the input size, which then has all effects applied, to get the output size. PiperOrigin-RevId: 477975358 (cherry picked from commit de82a2be)
huangdarwin committed -
Per go/java-practices/imports#static No functional changes intended. PiperOrigin-RevId: 477974779 (cherry picked from commit d5c272fd)
huangdarwin committed
-
- 29 Sep, 2022 1 commit
-
-
Rename test files to avoid substrings that can be implied by the directory name, like "Transformation" and "Test" No functional changes. Renaming-only. PiperOrigin-RevId: 477724724 (cherry picked from commit 62b95a71)
huangdarwin committed
-
- 28 Sep, 2022 1 commit
-
-
PiperOrigin-RevId: 477524540 (cherry picked from commit 1cfe18cd)
samrobinson committed
-