- 18 Oct, 2018 13 commits
-
-
*** Reason for rollback *** Photos regression is resolved by [] *** Original change description *** Automated g4 rollback of changelist 217189082. *** Reason for rollback *** Broke photos (b/117818304) *** Original change description *** Add ExoPlayer.setForegroundMode Issue: #2826 *** *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217773278
olly committed -
I don't think there's any particular reason for releasing dummySurface when we release the codec. It seems to make more sense to decouple the two, and treat a dummySurface as a resource that should be released on reset. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217711788
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217708323
aquilescanta committed -
Issue:#4960 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217707957
aquilescanta committed -
setSurface only sets the output surface on the codec if the renderer is enabled or started. This was fine in the past because the codec was always null in other states, however the recent codec reuse work means this is no longer the case. The output surface should always be set if the codec is non-null. If setting the surface requires releasing the codec instance, we should only instantiate the new instance if enabled or started. This is in line with what onDisabled does if flushing requires releasing the codec ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217676434
olly committed -
Just not doing it seems simplier and more obviously correct than suppressing the warnings in our proguard file. Issue: #4890 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217675527
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217505571
eguven committed -
*** Reason for rollback *** Broke photos (b/117818304) *** Original change description *** Add ExoPlayer.setForegroundMode Issue: #2826 *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217356705
falhassen committed -
Renamed to stop collision between the ExoV1 and ExoV2 implementation. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217348150
cpaulino committed -
Issue: #3241 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217252254
andrewlewis committed -
Issue: #2826 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217189082
olly committed -
1. Remove option to pass null context to Util.getNetworkType. IMO it's clearer for the caller to just not call the method in this case. 2. Stop using deprecated DefaultBandwidthMeter.Builder constructor in all but one place. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217147091
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217139869
olly committed
-
- 15 Oct, 2018 15 commits
-
-
The assertion was so weak it probably wouldn't detect genuine misuse of the DefaultAllocator API, so it seems fine just to remove it. We don't really know what happens when the player is allowed to continue on the affected devices, but hopefully it either "just works" or fails in a more graceful way. Issue: #4532 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217113060
olly committed -
Robustness fix to make sure we ignore tags with known names, but which are nested inside of unknown tags. For example we don't want to parse the third period in: <Period>...</Period> <Period>...</Period> <CustomTag> <Period>...</Period> </CustomTag> ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217101630
olly committed -
Issue: #2826 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=216852679
olly committed -
For decoder reuse, we want disable() to flush the decoder. However, if the flush needs to release the decoder for some reason, it seems non-ideal to immediately re-initialize it. Re-initialization can also throw ExoPlaybackException, which we don't want for disabling. This change allows a variant of flush that wont re-initialize the decoder if it has to be released, which will be used from disable(). Issue: #2826 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=216834862
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=216704331
andrewlewis committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=216675981
andrewlewis committed -
reloading frmo snapshots. b/117347850. This is a no-op change as the current default == _fullboot. When we globally flip and make snapshots the default, these tests would fail and we are moving them over so that when we flip your tests still pass. https://groups.google.com[]forum/#!topic/mobile-ninjas/Y69PTAT5GyY ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=216634430
vsethia committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215904019
tonihei committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215868785
andrewlewis committed -
- Always clip to period duration for the last chunk. We previously did this only when the last chunk explicitly exceeded the period end time. We now also do it when the chunk claims to end at the period boundary, but still contains samples that exceed it. - If pendingResetPositionUs == chunk.startTimeUs == 0 but the chunk still contains samples with negative timestamps, we now clip them by setting the decode only flag. Previously we only clipped such samples if the first chunk explicitly preceeded the start of the period. Issue: #4899 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215763467
olly committed -
Apps need to set the target compatibility to VERSION_1_8 to enable the automatic desugaring if they haven't done so already. Issue:#4907 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215733070
tonihei committed -
- It's a no-op for now - Renderers that want to support retaining resources will move some functionality from their disable() implementations into reset() - ExoPlayerImplInternal will be updated to not always call reset() immediately after disable(), which is what will enable resources to actually be retained. Issue: #2826 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215729783
olly committed -
This makes the following changes to improve consistency among the PlaybackInfo values: 1. Update buffered position and total buffered duration after loading period is set as both values are affected by a loading period update. 2. Add copyWithPosition to allow updating the position without resetting the loading period. 3. Forward the total buffered duration to playing position updates as it may have changed with the new playing position. Issue:#4899 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215712328tonihei committed -
This allows to wait until loading started or finished. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215704424
tonihei committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215704344
tonihei committed
-
- 03 Oct, 2018 12 commits
-
-
Oliver Woodman committed
-
#4306 - Extract tags from SubRip subtitles, add support for alignment
ojw28 committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215562599
eguven committed -
DownloadService isn't designed to be bound. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215552423
eguven committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215541062
eguven committed -
When SubtitlePainter positions the cues centred in the given box, it must add the left offset of the box to get the correct position. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215535289
tonihei committed -
SubtitleView forwards the cue box position to SubtitlePainter. This should be the position relative to the canvas of the SubtitleView. Currently, however, we forward the position relative to the parent of SubtitleView. That causes problems if SubtitleView has a non-zero offset position to its parent. Issue:#4788 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215535281
tonihei committed -
This removes the experimental bandwidth meter and uses it as the new default. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215404065
tonihei committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215389291
aquilescanta committed -
A lot of methods just forward to other methods and there is no conceivable way a player should implement it another way. Moving these methods to a base player class allows to remove duplicated code across our player implementations. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215374192
tonihei committed -
For example, using ExoPlayer.STATE_IDLE falls back to the Player.STATE_IDLE automatically and thus there is no need to keep the deprecated members. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215363841
tonihei committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=215261807
olly committed
-
