- 17 Jan, 2020 40 commits
-
-
PiperOrigin-RevId: 287973192
kimvde committed -
PiperOrigin-RevId: 287999703
olly committed -
Issue: #6552 PiperOrigin-RevId: 287964221
andrewlewis committed -
PiperOrigin-RevId: 287854701
olly committed -
Issue: #5789 PiperOrigin-RevId: 287828559
olly committed -
Issue: #6779 PiperOrigin-RevId: 287828273
olly committed -
Issue: #6266 PiperOrigin-RevId: 287821640
olly committed -
Issue: #6602 PiperOrigin-RevId: 287816831
andrewlewis committed -
It's unreliable for at least one IMA ADPCM file I've found. Calculating the blockIndex to seek to using exact properties also seems more robust. Note this doesn't change anything for the existing PCM test, since averageBytesPerSecond is set correctly. It does make a difference for an upcoming IMA ADPCM test though. PiperOrigin-RevId: 287814947
olly committed -
PiperOrigin-RevId: 287810018
andrewlewis committed -
Issue: #6733 PiperOrigin-RevId: 286621715
olly committed -
PiperOrigin-RevId: 286197990
olly committed -
Add support for MP3 as an encoding format for passthrough. This change does not change the observable behavior of Exoplayer. Also name the magics. #exo-offload PiperOrigin-RevId: 286146539
krocard committed -
PiperOrigin-RevId: 285823771
kimvde committed -
Fix the FlacExtractor constructor for the case where seek(0,0) is not called before reading. PiperOrigin-RevId: 285811161
kimvde committed -
PiperOrigin-RevId: 285799995
kimvde committed -
- Make extractor output samples that are uniformly distributed with respect to time, with a target of ~10 samples per second. The old approach could in theory put every frame into its own sample, which would be very inefficient downstream because we'd need to pass them individually to MediaCodec. It could also put data corresponding to a long duration of time into a single sample (e.g. if the sample rate of the content is low), which is bad downstream because we decide whether to set the decodeOnly flag on a per sample basis. More generally, the new approach is more predictable :). - Stop using the WavSeekMap to get sample timestamps, and instead calculate them directly from the number of frames output. It's more obviously correct, particularly for data formats like IMA ADPCM where we'll need to adjust the data prior to output. PiperOrigin-RevId: 285750010
olly committed -
PiperOrigin-RevId: 285716982
andrewlewis committed -
PiperOrigin-RevId: 285407744
olly committed -
PiperOrigin-RevId: 285405910
olly committed -
Also change IcyInfo.rawMetatadata from String to byte[] ICY doesn't specify the character encoding, and there are streams not using UTF-8 (issue:#6753). It seems the default of at least one server is ISO-8859-1 so let's support that as a fallback: https://github.com/savonet/liquidsoap/issues/411#issuecomment-288759200 Also update IcyDecoder to skip strings it doesn't recognise at all instead of decoding invalid characters. The feed from issue:#6753 now decodes accents correctly: EventLogger: ICY: title="D Pai - Le temps de la rentrée", url="null" PiperOrigin-RevId: 285388522
ibaker committed -
We previously used Locale.fromLanguageTag and then toLanguageTag to automatically filter out invalid tags and to replace deprecated tags. However, this only works for API 21+. This change does no longer rely on the platform methods and instead: 1. Keeps invalid tags as they are. This may help if developers rely on non-spec-complaint language tags (for example, #6681). 2. Adds a list of deprcated tags and their modern replacements to our code 3. Normalizes some short codes that have been superseded by macrolanguage codes by their macrolanguage equivalent. Issue:#6681 PiperOrigin-RevId: 285384841tonihei committed -
Retrieve the sample number in the extractor instead of passing a holder to FlacBinarySearchSeeker. This change makes the code easier to understand and is required to implement the seeking from the seek table. PiperOrigin-RevId: 285241862
kimvde committed -
- Create PcmOutputWriter for PCM. - In a future change an ImaAdPcmOutputWriter will be introduced for IMA ADPCM support. PiperOrigin-RevId: 285238246
olly committed -
- WavHeader is now immutable and contains only values parsed out of the WAVE FMT chunk. It no longer contains a C.PcmEncoding encoding, or mutable data bounds. - WavHeaderReader now parses the WAVE header chunks without any additional logic (e.g. validating the block alignment value, which is format type dependent). - The SeekMap part of WavHeader is split out into WavSeekMap. PiperOrigin-RevId: 285232498
olly committed -
PiperOrigin-RevId: 284961417
olly committed -
PiperOrigin-RevId: 284952647
kimvde committed -
PiperOrigin-RevId: 284814594
kimvde committed -
PiperOrigin-RevId: 284776943
ibaker committed -
PiperOrigin-RevId: 284537150
kimvde committed -
Flac streams exist but are not commonly used. Also, they are not supported by the FLAC extension extractor. PiperOrigin-RevId: 284514327
kimvde committed -
This makes the format metadata null (instead of an empty Metadata object) when it is not provided, and is therefore consistent with the other extractors behavior. PiperOrigin-RevId: 284171148
kimvde committed -
Also remove getRendererCapabilities arg that's now always null. PiperOrigin-RevId: 283966795
olly committed -
PiperOrigin-RevId: 283960017
andrewlewis committed -
Also remove redundant line PiperOrigin-RevId: 283956203
aquilescanta committed -
Saves around 200 lines of code. High level overview: - Rename SampleQueue to SampleDataQueue. - Rename SampleMetadataQueue to SampleQueue. This CL should not introduce behavior changes. The only significant changes in synchronization should be: + Add synchronized keyword to isReady. - Seems to be necessary. + Add synchronized keyword to SampleQueue.sampleMetadata. - Before this change, SampleQueue.sampleMetadata could acquire the SampleMetadataQueue lock three times in a single method call. Other miscellaneous improvements: + Put all private methods at the bottom. + Move release() to the right category. PiperOrigin-RevId: 283795844aquilescanta committed -
PiperOrigin-RevId: 283795201
aquilescanta committed -
PiperOrigin-RevId: 283551324
andrewlewis committed -
PiperOrigin-RevId: 283544187
kimvde committed -
I wrote this myself PiperOrigin-RevId: 281942685
ibaker committed
-