- 31 Oct, 2018 14 commits
-
-
Before this change, the player state would be STATE_ENDED then STATE_BUFFERING (when the postroll ad was marked as played) then STATE_ENDED again. Queueing a final content media period with start point equal to the content duration after a postroll ensures that the player state doesn't change to STATE_ENDED transiently. Switch from using C.TIME_END_OF_SOURCE to C.TIME_UNSET for media periods that should not have an end point and are not followed by an ad. Content media periods before postrolls have end position C.TIME_END_OF_SOURCE. If the postroll ad loads, its content position is set to the content duration, which should be known at the point of loading the postroll, then a final 'empty' content media period with start position equal to its duration is queued. If the postroll fails to load, this empty content media period is queued up directly after the preceding content media period. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=219443683
andrewlewis committed -
Issue: #5019 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=219267048
andrewlewis committed -
- Handling EVENT_PROVISION_REQUIRED is unnecessary because we handle it via NotProvisionedException, which was thrown on all API levels. - Handling EVENT_KEY_EXPIRED during playback is unnecessary. All it does is cause an error to be thrown, but an error will be thrown anyway out of the MediaCodec when it tries to use the expired keys. It's currently a race condition where the error gets thrown from, where-as having it always be thrown from one place is preferable. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=219172021
olly committed -
Issue: #3314 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=219158729
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=219139356
olly committed -
Issue: #2826 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=219130576
olly committed -
This paves the way to cleanly fix the first two issues listed in [] onDisabled will null inputFormat, but nulling of codecFormat will remain tied to the codec being released. Issue: #2826 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=219125458
olly committed -
RELNOTES=true ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=219119888
eguven committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=219109829
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218877191
eguven committed -
ExoCastMessage contains all player management messages that the sender app can send to the receiver app. ExoCastMessages can be serialized as JSON strings. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218846977
aquilescanta committed -
- Only use bitrate when comparing two tracks if their bitrates are actually different. - For audio, prefer to use bitrate over selection flags. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218660886
olly committed -
- Improve variable naming - In the edge case that bytes are transferred in a sample that has 0 elapsed time, carry the bytes forward into the next sample. If we don't do this then the estimate will be calculated as though those bytes were never transferred. In practice I suspect this very rarely occurs. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218551208
olly committed -
Issue: #2826 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218540967
olly committed
-
- 24 Oct, 2018 21 commits
-
-
Issue: #4954 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218357113
andrewlewis committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218347641
olly committed -
Issue: #2826 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218346327
olly committed -
Issue: #2826 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218332277
olly committed -
If EventDispatcher.removeListener is called to remove a listener, and if the call is made from the same thread that said listener handles events on, then it should be guaranteed that the listener will not be subsequently invoked on that thread. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218331427
olly committed -
This seems to be more stable in case Bintray has issues updating the ExoPlayer sources. Issue:#4997 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218327350
tonihei committed -
Turn on flag to enable fast loop filtering. This improves multi-threaded decode performance by starting loop filtering early if there are free threads available to do so. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218239442
vigneshv committed -
Makes it consistent with MediaItem.media. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218217648
aquilescanta committed -
In ConcatenatingMediaSource, the source may be removed before it started preparing (this may happen if lazyPreparation=true). In this case, we shouldn't call releaseSource as the preparation didn't start. Issue:#4986 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218141658
tonihei committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218137830
eguven committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218058185
andrewlewis committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218003875
olly committed -
There are multiple subtle issues with the current implementation: 1. setOperatingRate can cause a codec initialization even if the renderer is disabled. This is not supposed to happen. 2. If the codec is released whilst the renderer is disabled, the renderer can instantiate a new codec using the old format when it's enabled again, only to immediately have to reconfigure or release it if the actual format to be played is different. 3. Codec reuse does not take into account renderer configuration. The specific case where this is problematic is if the video renderer is re-enabled with a different tunneling session id. The reused codec is then not configured correctly. Also moved availableCodecInfos reset into releaseCodec for sanity. Issue: #2826 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217924592
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217907544
andrewlewis committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217897796
olly committed -
Mimics the ExoV1 behavior. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217893212
cpaulino committed -
This is a no-op change as the respective values are not used so far but the change makes the current state cleaner and is less error-prone. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217892421
tonihei committed -
- Added ability to override the DefaultBandwidthMeter network type. - These methods currently only work properly if called before the meter is used, but the plan is for them to be handled in the same way as internally detected network changes. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217887019
olly committed -
This method only ensured backward compatibility while the new version was not public yet. Now ExoPlayer 2.9.0. is public, this workaround can be removed. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217881691
tonihei committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217874381
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217846755
eguven committed
-
- 18 Oct, 2018 5 commits
-
-
*** Reason for rollback *** Photos regression is resolved by [] *** Original change description *** Automated g4 rollback of changelist 217189082. *** Reason for rollback *** Broke photos (b/117818304) *** Original change description *** Add ExoPlayer.setForegroundMode Issue: #2826 *** *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217773278
olly committed -
I don't think there's any particular reason for releasing dummySurface when we release the codec. It seems to make more sense to decouple the two, and treat a dummySurface as a resource that should be released on reset. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217711788
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217708323
aquilescanta committed -
Issue:#4960 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217707957
aquilescanta committed -
setSurface only sets the output surface on the codec if the renderer is enabled or started. This was fine in the past because the codec was always null in other states, however the recent codec reuse work means this is no longer the case. The output surface should always be set if the codec is non-null. If setting the surface requires releasing the codec instance, we should only instantiate the new instance if enabled or started. This is in line with what onDisabled does if flushing requires releasing the codec ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217676434
olly committed
-