Commits · 0e1e4ad737cafa3a166815d34ee81c3d8d2e23d4 · SDK / exoplayer

13 Dec, 2019 2 commits

Remove MediaCodec.stop() call before MediaCodec.release() · 0e1e4ad7
```
This was verified as a no-op change in a prod experiment.

PiperOrigin-RevId: 285167972
```
olly committed Dec 13, 2019
0e1e4ad7 Browse Files

Make Cue final and change 2 subclasses to delegate-pattern · e8fa9a55

This avoids needing to jump through type paremeter hoops to create a
sub-classable Cue.Builder.

Cue should have a standard set of fields, because it will be
consumed by renderers that don't know what type it is. The
existing subclass fields are only used inside their respective
packages, so can be part of a wrapper object instead.

This lays the groundwork for converting Cue's multiple constructors
into a Builder pattern.

PiperOrigin-RevId: 284992135

committed Dec 13, 2019

e8fa9a55

11 Dec, 2019 22 commits
- Merge branch 'release-v2' into dev-v2 · 5bbabbc1
  Oliver Woodman committed Dec 11, 2019
  
  5bbabbc1 Browse Files
- Merge pull request #6752 from google/dev-v2-r2.11.0 · 76962d50
```
r2.11.0
```
  Oliver Woodman committed Dec 11, 2019
  76962d50 Browse Files
- Merge branch 'release-v2' into dev-v2-r2.11.0 · 4a4aa16d
  Oliver Woodman committed Dec 11, 2019
  
  4a4aa16d Browse Files
- Suppress rawtypes warning when instantiating generic array · a4a9cc9f
```
Change FakeAdaptiveMediaPeriod back to this style for consistency.

PiperOrigin-RevId: 284967667
```
  olly committed Dec 11, 2019
  a4a9cc9f Browse Files
- Fix generics warning in FakeAdaptiveMediaPeriod. · 6ebc9f96
```
Remove all generic arrays from this class.

FakeAdaptiveMediaPeriod.java:171: warning: [rawtypes] found raw type: ChunkSampleStream
    return new ChunkSampleStream[length];
               ^
  missing type arguments for generic class ChunkSampleStream<T>
  where T is a type-variable:
    T extends ChunkSource declared in class ChunkSampleStream

PiperOrigin-RevId: 284761750
```
  ibaker committed Dec 11, 2019
  6ebc9f96 Browse Files
- Fix an issue where a keyframe was not skipped. · 03b02f98
```
Keyframe was rendered rather than skipped when performing
an exact seek to a non-zero position close to the start of
the stream.

PiperOrigin-RevId: 284798460
```
  samrobinson committed Dec 11, 2019
  03b02f98 Browse Files
- Add missing release note entry · b8eafea1
```
PiperOrigin-RevId: 284792946
```
  christosts committed Dec 11, 2019
  b8eafea1 Browse Files
- Suppress rawtypes warning when instantiating generic array · 59083c9f
```
Change FakeAdaptiveMediaPeriod back to this style for consistency.

PiperOrigin-RevId: 284967667
```
  olly committed Dec 11, 2019
  59083c9f
- Remove nullness suppression that's no longer required · a00e7dfe
```
PiperOrigin-RevId: 284965120
```
  ibaker committed Dec 11, 2019
  a00e7dfe Browse File
- Add WavHeader.samplesPerBlock (currently always == 1) · a97b09d7
```
PiperOrigin-RevId: 284961417
```
  olly committed Dec 11, 2019
  a97b09d7 Browse Files
- Remove duplicated logic in FlacReader · 039ce8a9
```
PiperOrigin-RevId: 284952647
```
  kimvde committed Dec 11, 2019
  039ce8a9 Browse Files
- Update robolectric version to 4.3.1. · 483e3a67
```
PiperOrigin-RevId: 284951651
```
  samrobinson committed Dec 11, 2019
  483e3a67 Browse Files
- Inline ENABLE_PRELOADING · 4c72ab94
```
ImaAdsLoader relies on preloading being enabled (it doesn't
work without it) so we may as well remove the constant to
avoid potential confusion.

PiperOrigin-RevId: 284951356
```
  andrewlewis committed Dec 11, 2019
  4c72ab94
- Implement binary search seeking for FLAC extractor · a95c28a9
```
PiperOrigin-RevId: 284814594
```
  kimvde committed Dec 11, 2019
  a95c28a9
- Fix an issue where a keyframe was not skipped. · 65adcdae
```
Keyframe was rendered rather than skipped when performing
an exact seek to a non-zero position close to the start of
the stream.

PiperOrigin-RevId: 284798460
```
  samrobinson committed Dec 11, 2019
  65adcdae Browse Files
- Add missing release note entry · 272858f6
```
PiperOrigin-RevId: 284792946
```
  christosts committed Dec 11, 2019
  272858f6 Browse Files
- Add NonNull annotations to source.ads · bb466adb
```
PiperOrigin-RevId: 284787807
```
  olly committed Dec 11, 2019
  bb466adb Browse Files
- Create Truth SpannedSubject for style assertions · 7263699c
```
This will be used in subtitle decoding tests

I followed this guide: https://truth.dev/extension.html

PiperOrigin-RevId: 284787298
```
  ibaker committed Dec 11, 2019
  7263699c
- Fix javadoc warnings exposed by -Xdoclint · c1573106
```
PiperOrigin-RevId: 284776943
```
  ibaker committed Dec 11, 2019
  c1573106 Browse Files
- Fix javadoc errors exposed by -Xdoclint · 614a92b6
```
PiperOrigin-RevId: 284776790
```
  ibaker committed Dec 11, 2019
  614a92b6 Browse Files
- Add NonNull annotations to upstream · 5cee5cba
```
PiperOrigin-RevId: 284771928
```
  olly committed Dec 11, 2019
  5cee5cba Browse File
- Fix generics warning in FakeAdaptiveMediaPeriod. · 5da510cf
```
Remove all generic arrays from this class.

FakeAdaptiveMediaPeriod.java:171: warning: [rawtypes] found raw type: ChunkSampleStream
    return new ChunkSampleStream[length];
               ^
  missing type arguments for generic class ChunkSampleStream<T>
  where T is a type-variable:
    T extends ChunkSource declared in class ChunkSampleStream

PiperOrigin-RevId: 284761750
```
  ibaker committed Dec 11, 2019
  5da510cf Browse Files
10 Dec, 2019 10 commits

Fix bug removing entries from CacheFileMetadataIndex · 1de7ec2c
```
Issue: #6621
PiperOrigin-RevId: 284743414
```
olly committed Dec 10, 2019
1de7ec2c Browse Files
Fix bug removing entries from CacheFileMetadataIndex · 006418ab
```
Issue: #6621
PiperOrigin-RevId: 284743414
```
olly committed Dec 10, 2019
006418ab Browse Files

Rollback of https://github.com/google/ExoPlayer/commit/355ed11a3cd6d90eb02d9f773a546561884324b3 · 9ec524a7

*** Original commit ***

Suppress warnings emitted by Checker Framework version 2.11.1

More information:
https://docs.google.com/document/d/16tpK6aXqN68PvTyvt4siM-m7f0NXi_8xEeitLDzr8xY/edit?usp=sharing

Tested:
    TAP --sample ran all affected tests and none failed
    http://test/OCL:278915274:BASE:278884711:1573074344615:a6701677

***

PiperOrigin-RevId: 284741721

committed Dec 10, 2019

9ec524a7

Rollback of https://github.com/google/ExoPlayer/commit/4fd881a5516a04409cc0f54d4e6be6c059519f79 · 32339954

*** Original commit ***

Suppress warnings emitted by Checker Framework version 3.0.0

More information:
https://docs.google.com/document/d/16tpK6aXqN68PvTyvt4siM-m7f0NXi_8xEeitLDzr8xY/edit?usp=sharing
Tested:
    TAP --sample ran all affected tests and none failed
    http://test/OCL:279845168:BASE:279870402:1573537714395:80ca701c

***

PiperOrigin-RevId: 284740695

committed Dec 10, 2019

32339954 Browse Files

(partial) Rollback of… · 4c4cabdf

(partial) Rollback of https://github.com/google/ExoPlayer/commit/880b879e8c55b1e709fd3ed6a48005737d26e75a

*** Original commit ***

Suppress warnings emitted by Checker Framework version 2.11.1

More information:
https://docs.google.com/document/d/16tpK6aXqN68PvTyvt4siM-m7f0NXi_8xEeitLDzr8xY/edit?usp=sharing

Tested:
    TAP train for global presubmit queue
    http://test/OCL:278152710:BASE:278144052:1572760370662:22459c12

***

PiperOrigin-RevId: 284738438

committed Dec 10, 2019

4c4cabdf Browse Files

Make DefaultTimeBar exclude itself for gestures · 90329a14
```
Issue: #6685
PiperOrigin-RevId: 284736041
```
olly committed Dec 10, 2019
90329a14 Browse Files

Turn on nullness checker for playback stats · c027b4e7

The nullness checker complains about Integers with @IntDef annotations
so replace pairs with custom pair types for the timed event records in
PlaybackStats.

PiperOrigin-RevId: 284731834

committed Dec 10, 2019

c027b4e7 Browse Files

Add peek() method to ExtractorInput · 70ba4b19
```
PiperOrigin-RevId: 284586799
```
kimvde committed Dec 10, 2019
70ba4b19 Browse Files
Move matroska lacing into 2.11 · bcb51ec1
```
PiperOrigin-RevId: 284576903
```
olly committed Dec 10, 2019
bcb51ec1 Browse Files
Partial nullness annotations for AtomParsers · 539a1ac2
```
PiperOrigin-RevId: 284558886
```
olly committed Dec 10, 2019
539a1ac2 Browse Files

09 Dec, 2019 6 commits

MatroskaExtractor: Support lacing in full blocks · 914a8df0

Caveats:

- Block additional data is ignored if the block is laced
  and contains multiple samples. Note that this is not
  a loss of functionality (SimpleBlock cannot have block
  additional data, and lacing was previously completely
  unsupported for Block)

- Subrip and ASS samples are dropped if they're in laced
  blocks with multiple samples (I don't think this is
  valid anyway)

Issue: #3026
PiperOrigin-RevId: 284545197

committed Dec 09, 2019

914a8df0 Browse Files

MatroskaExtractor: Constrain use of sample state member variables · 0065f63f

This change constrains the use of sample state member variables to
writeSampleData, finishWriteSampleData and resetWriteSampleData.
Using them elsewhere gets increasingly confusing when considering
features like lacing in full blocks. For example sampleBytesWritten
cannot be used when calling commitSampleToOutput in this case
because we need to write the sample data for multiple samples
before we commit any of them.

Issue: #3026
PiperOrigin-RevId: 284541942

committed Dec 09, 2019

0065f63f Browse Files

Fix Javadoc issues · 567f2a65
```
PiperOrigin-RevId: 284509437
```
olly committed Dec 09, 2019
567f2a65 Browse Files
Clean `WakeLockManager.updateWakeLock` logic. · 4b281cec
```
PiperOrigin-RevId: 284552723
```
samrobinson committed Dec 09, 2019
4b281cec Browse Files
Add NonNull annotations to upstream.cache and upstream.crypto · c90c10c9
```
PiperOrigin-RevId: 284548019
```
olly committed Dec 09, 2019
c90c10c9 Browse Files

MatroskaExtractor: Support lacing in full blocks · 0b7f93a5

Caveats:

- Block additional data is ignored if the block is laced
  and contains multiple samples. Note that this is not
  a loss of functionality (SimpleBlock cannot have block
  additional data, and lacing was previously completely
  unsupported for Block)

- Subrip and ASS samples are dropped if they're in laced
  blocks with multiple samples (I don't think this is
  valid anyway)

Issue: #3026
PiperOrigin-RevId: 284545197

committed Dec 09, 2019

0b7f93a5 Browse Files