- 18 Apr, 2019 26 commits
-
-
- We had buildAddRequest and sendNewDownload. Converged to buildAddDownload and sendAddDownload. - Also fixed a few more inconsistencies, and brought the action constants into line as well. PiperOrigin-RevId: 244274041
olly committed -
PiperOrigin-RevId: 244268855
olly committed -
PiperOrigin-RevId: 244267255
olly committed -
- Listener based reporting of progress allows the content length to be persisted into the download index (and notified via a download state change) as soon as it's available. - Moved contentLength back into Download proper. It should only ever change once, so I'm not sure it belongs in the mutable part of Download. - Made a DownloadProgress class, for naming sanity. PiperOrigin-RevId: 244242487
olly committed -
PiperOrigin-RevId: 244226680
olly committed -
PiperOrigin-RevId: 244223870
olly committed -
PiperOrigin-RevId: 244216620
olly committed -
PiperOrigin-RevId: 244210737
olly committed -
PiperOrigin-RevId: 244196081
eguven committed -
Assuming there is no text language preference. PiperOrigin-RevId: 244176667
aquilescanta committed -
PiperOrigin-RevId: 244170179
eguven committed -
PiperOrigin-RevId: 244168713
aquilescanta committed -
PiperOrigin-RevId: 244139959
andrewlewis committed -
PiperOrigin-RevId: 244094942
olly committed -
1. customCacheKey for DASH/HLS/SS is now asserted against in DownloadRequest 2. Merging of event delivery in DownloadManager is very tricky to get right and probably not a good idea PiperOrigin-RevId: 244048392
olly committed -
PiperOrigin-RevId: 244009343
eguven committed -
Currently SimpleCache will touch cache spans whenever it reads from them. With legacy SimpleCache setups this involves a potentially expensive file rename. With new SimpleCache setups it involves a more efficient but still non-free database write. For offline use cases, and more generally any use case where the eviction policy doesn't use last access timestamps, touching is not useful. This change allows the evictor to specify whether it needs cache spans to be touched or not. SimpleCache will only touch spans if the evictor requires it. Note: There is a potential change in behavior in cases where a cache uses an evictor that doesn't need cache spans to be touched, but then later switches to an evictor that does. The new evictor may temporarily make sub-optimal eviction decisions as a result. I think this is a very fair trade-off, since this scenario is unlikely to occur much, if at all, in practice, and even if it does occur the result isn't that bad. PiperOrigin-RevId: 244005682
olly committed -
PiperOrigin-RevId: 244003817
olly committed -
PiperOrigin-RevId: 243988105
andrewlewis committed -
Issue: #5772 PiperOrigin-RevId: 243987497
olly committed -
One goal we forgot about a little bit was to allow applications to provide their own index implementation. This requires the writable side to also be defined by an interface. PiperOrigin-RevId: 243979660
olly committed -
ImaAdsLoader gets the player position after the app releases the player to support resuming ads at their current position if the same ads loader is reused. PiperOrigin-RevId: 243969916
andrewlewis committed -
PiperOrigin-RevId: 243954989
eguven committed -
PiperOrigin-RevId: 243821394
olly committed -
We currently do manual position tracking while the player is in error mode. This is to allow an initial seek to the new position when trying to re-prepare. Instead, we can just use our player.retry method and remove the tracking code. PiperOrigin-RevId: 243819580
tonihei committed -
The removed condition only applies when prepare fails and no timeline was or is known. We should keep a pending seek position in such a case. The internal player does the same thing already. PiperOrigin-RevId: 243819466
tonihei committed
-
- 16 Apr, 2019 14 commits
-
-
Issue: #5767 PiperOrigin-RevId: 243811443
olly committed -
PiperOrigin-RevId: 243807109
borrelli committed -
PiperOrigin-RevId: 243806888
eguven committed -
PiperOrigin-RevId: 243799572
borrelli committed -
PiperOrigin-RevId: 243781000
eguven committed -
- It can work with any DownloadIndex - Also simplify things to not require that it's registered as a DownloadManager listener by someone else PiperOrigin-RevId: 243697352
olly committed -
- Expose constructors that take DatabaseProvider. Deprecate those that do not. - Expose Cache.getUid. This will likely be used for naming of the tables accessed by DefaultDownloadIndex . PiperOrigin-RevId: 243637786
olly committed -
PiperOrigin-RevId: 243636923
andrewlewis committed -
PiperOrigin-RevId: 243632134
aquilescanta committed -
- Allows enforcing immutability, which in a future CL will allow avoiding allocating a new array/list on every call. - Also some left over doc cleanup from the DownloadState rename. PiperOrigin-RevId: 243627352
olly committed -
PiperOrigin-RevId: 243624081
aquilescanta committed -
PiperOrigin-RevId: 243618907
aquilescanta committed -
ISSUE: #4563 PiperOrigin-RevId: 243616444
eguven committed -
PiperOrigin-RevId: 243592790
olly committed
-