- 08 Nov, 2022 16 commits
-
-
Remove static imports to Player constants to make the code more readable. #minor-release PiperOrigin-RevId: 486619911
christosts committed -
The method getCurrentPosition() may return a lesser position during pause than the previous retrieved value due to ipc call delay in playerInfo update. Users see track position jump backwards at pause. Fixed to return last estimated position while paused if have not received updated playerInfo. Code is deduped to point getContentPosition() to getCurrentPosition() when !isPlayingAd. PiperOrigin-RevId: 486617341
michaelkatz committed -
LSC: https://docs.google.com/document/d/16tpK6aXqN68PvTyvt4siM-m7f0NXi_8xEeitLDzr8xY/edit?usp=sharing TESTED=NA BEGIN_PUBLIC/END_PUBLIC PiperOrigin-RevId: 486180995
Googler committed -
From https://github.com/androidx/media/pull/127/files PiperOrigin-RevId: 485921271
yschimke committed -
PiperOrigin-RevId: 485890141
huangdarwin committed -
on which the video is rendered. Design Doc: go/aaos-mu-media-dd PiperOrigin-RevId: 485884772
Googler committed -
Notification buttons for next/previous should change based on the new index of the currently played media item after another media item is added or removed from a playlist. Issue: androidx/media#130 PiperOrigin-RevId: 485869144
rohks committed -
If there's an @param javadoc tag in a supertype then all overrides of this method that don't also override the javadoc must use the same parameter name. PiperOrigin-RevId: 485857711
ibaker committed -
Remove static imports to constants and imports to intdefs, to make the code more readable. PiperOrigin-RevId: 485592288
christosts committed -
Public methods may only refer to public types in their signature. This change ensures that by switching to a public supertype everywhere. PiperOrigin-RevId: 485568625
ibaker committed -
Not sure what BUILD.ID the fix will first be applied on though. PiperOrigin-RevId: 485389618
huangdarwin committed -
* Add `Listener` in `MediaSession` with method `onNotificationRefreshRequired(MediaSession)`. * Add `MediaSessionService` as the listener of the `MediaSession` when `MediaSession` is added to `MediaSessionService` * Load bitmap when update metadata in `MediaSessionLegacyStub` and call `onNotificationRefreshRequired` when bitmap asynchronously arrives. PiperOrigin-RevId: 485376145
tianyifeng committed -
PiperOrigin-RevId: 485366659
huangdarwin committed -
If an app sets a compileSdkVersion that is lower than the one used to create AARs of its dependencies, the build process may produce invalid outputs, for example by stripping methods from the APK that are only called when the app is running on a new API version. To avoid this issue, we can enforce that the compileSdk of apps or libraries depending on ExoPlayer/Media3 is at least the same as the one we used for compilation when creating the AAR. Issue: google/ExoPlayer#10684 PiperOrigin-RevId: 485100067
tonihei committed -
PiperOrigin-RevId: 485061783
rohks committed -
PiperOrigin-RevId: 485036120
rohks committed
-
- 31 Oct, 2022 19 commits
-
-
#minor-release PiperOrigin-RevId: 484514123
bachinger committed -
PiperOrigin-RevId: 484512661
samrobinson committed -
#minor-release PiperOrigin-RevId: 484483080
andrewlewis committed -
PiperOrigin-RevId: 484298261
kimvde committed -
This root extra needs to be set by apps manually in media1 and we can do that automatically in Media3 based on the available session commands. #minor-release PiperOrigin-RevId: 484286833
bachinger committed -
In Media3 there is the useful concept of connection hints that a client can set when building the session and that are sent to the service and passed to the `Callback.onConnect()` method when the browser connects. These connection hints are then included in the `ControllerInfo` object that later will be passed to every callback method and the implementor can then take decisions specific to these connection hints. These connection hints are not available in media1. However, when an app creates a `MediaBrowserCompat` object, the constructor takes a rootHint object that is sent to `MediaBrowserServiceCompat.onGetRoot()`. This change uses the browser rootHints as the connection hints when creating the `ControllerInfo` for legacy browsers and makes them available to the `MediaLibrarySession.Callback` domain methods in the same way as connection hints of a Media3 browser. PiperOrigin-RevId: 484220748
bachinger committed -
This change makes adding ad events in live streams more robust by allowing ad groups to grow in number of ads if more ad events are received than initially announced by the SDK. With the IMA prefetch feature, an AdPod can grow in size in certain conditions like from initially 2 ads to 4 ads being part of the ad group. With this change, if an additional ad event arrives while the ad group is still being played, the ad group is expanded. If the event arrives late and the ad group is already completed, a new group is created for the remaining ads. This also covers the case where we join the live stream while an ad is being played and we missed at least one LOADED event from the SDK. Ads of the group before the first LOADED event are ignored in such a case. PiperOrigin-RevId: 484214760
bachinger committed -
This allows to throw when the Transformer is stuck or is too slow. PiperOrigin-RevId: 484179037
kimvde committed -
PiperOrigin-RevId: 483983486
samrobinson committed -
PiperOrigin-RevId: 483969411
tofunmi committed -
From ANSI-CTA-608-E R-2014 section 8.4: > When closed captioning is used on line 21, field 2, it shall conform > to all of the applicable specifications and recommended practices as > defined for field 1 services with the following differences: > 1. The non-printing character of the miscellaneous control-character > pairs that fall in the range of 0x14, 0x20 to 0x14, 0x2F in field 1, > shall be replaced with 0x15, 0x20 to 0x15, 0x2F when used in field > 2. > 2. The non-printing character of the miscellaneous control-character > pairs that fall in the range of 0x1C, 0x20 to 0x1C, 0x2F in field > 1, shall be replaced with 0x1D, 0x20 to 0x1D, 0x2F when used in > field 2. This basically means that `cc1=0x15` in field 2 should be interpreted as `cc1=0x14` in field 1, and same for `0x1D -> 0x1C`. The `isMiscCode` method above already handles this by ignoring the LSB (the only difference between `0x14` and `0x15`, and `0x1C` and `0x1D`) by AND-ing with `0xF6` instead of `0xF7`. This change uses the same trick in `isServiceSwitchCommand`. Issue: google/ExoPlayer#10666 #minor-release PiperOrigin-RevId: 483927506
ibaker committed -
Split inner interface into separate file, which will go in common module. The old interface will be deprecated and extends the new. #cleanup PiperOrigin-RevId: 483732226
samrobinson committed -
PiperOrigin-RevId: 483699606
samrobinson committed -
PiperOrigin-RevId: 483671580
claincly committed -
* Add `BitmapLoader` in `MediaSession.Builder` and `MediaLibrarySession.Builder`. * Pass `BitmapLoader` into the constructor of `MediaSession`, `MediaSessionImpl`, `MediaLibrarySession` and `MediaLibrarySessionImpl`. * Add an interface method `loadBitmapFromMetadata(MediaMetadata)` in `BitmapLoader`. * Remove the reference of `BitmapLoader` in `DefaultMediaNotificationProvider`. PiperOrigin-RevId: 483654596
tianyifeng committed -
The inner class avoids a verification failure, which can lead to slower execution at runtime. PiperOrigin-RevId: 483639417
ibaker committed -
This is a no-op, but it's more 'correct' because it avoids any potential sign mix-ups that come from storing an unsigned byte (with a potentially set MSB) in a signed java byte variable. PiperOrigin-RevId: 483409798
ibaker committed -
Although it can be useful to check the output format, it's not required or needed. For some AudioProcessor implementations, it is stated/obvious that the output format will match the input, in which case there is no a need to check the return value. #cleanup PiperOrigin-RevId: 483403679
samrobinson committed -
PiperOrigin-RevId: 483395026
microkatz committed
-
- 24 Oct, 2022 5 commits
-
-
Also used all-caps consistently PiperOrigin-RevId: 483317405
ibaker committed -
PiperOrigin-RevId: 482805730
bachinger committed -
* Add `CacheBitmapLoader`. * Add `CacheBitmapLoaderTest`. * Remove the `BitmapLoadRequest` and some bitmap caching logic in `DefaultMediaNotificationProvider` since we moved all of them in `CacheBitmapLoader`. * Modify `DefaultMediaNotificationProviderTest`. PiperOrigin-RevId: 482787445
tianyifeng committed -
PiperOrigin-RevId: 482755468
bachinger committed -
PiperOrigin-RevId: 482490230
Rohit Singh committed
-