- 12 Feb, 2015 5 commits
-
-
- Remove TsExtractor's knowledge of Sample. - Push handling of Sample objects into SampleQueue as much as possible. This is a precursor to replacing Sample objects with a different type of backing memory. Ideally, the individual readers shouldn't know how the sample data is stored. This is true after this CL, with the except of the TODO in H264Reader. - Avoid double-scanning every H264 sample for NAL units, by moving the scan for SEI units from SeiReader into H264Reader. Issue: #278
Oliver Woodman committed -
The complexity around not enabling the video renderer before it has a valid surface is because MediaCodecTrackRenderer supports a "discard" mode where it pulls through and discards samples without a decoder. This mode means that if the demo app were to enable the renderer before supplying the surface, the renderer could discard the first few frames prior to getting the surface, meaning video rendering wouldn't happen until the following sync frame. To get a handle on complexity, I think we're better off just removing support for this mode, which nicely decouples how the demo app handles surfaces v.s. how it handles enabling/disabling renderers.
Oliver Woodman committed -
Reordering in the extractor isn't going to work well with the optimizations I'm making there. This change moves sorting back to the renderer, although keeps all of the renderer simplifications. It's basically just moving where the sort happens from one place to another.
Oliver Woodman committed -
I'm not really a fan of micro-optimizations, but given this method scans through every H264 frame in the HLS case, it seems worthwhile. The trick here is to examine the first 7 bits of the third byte first. If they're not all 0s, then we know that we haven't found a NAL unit, and also that we wont find one at the next two positions. This allows the loop to increment 3 bytes at a time. Speedup is around 60% on Art according to some ad-hoc benchmarking.
Oliver Woodman committed -
There's no code change here at all, except for how TsExtractor's getLargestSampleTimestamp method works.
Oliver Woodman committed
-
- 11 Feb, 2015 1 commit
-
-
1. AdtsReader would previously copy all data through an intermediate adtsBuffer. This change eliminates the additional copy step, and instead copies directly into Sample objects. 2. PesReader would previously accumulate a whole packet by copying multiple TS packets into an intermediate buffer. This change eliminates this copy step. After the change, TS packet buffers are propagated directly to PesPayloadReaders, which are required to handle partial payload data correctly. The copy steps in the extractor are simplified from: DataSource->Ts_BitArray->Pes_BitArray->Sample->SampleHolder To: DataSource->Ts_BitArray->Sample->SampleHolder Issue: #278
Oliver Woodman committed
-
- 10 Feb, 2015 2 commits
-
-
- TsExtractor is now based on ParsableByteArray rather than BitArray. This makes is much clearer that, for the most part, data is byte aligned. It will allow us to optimize TsExtractor without worrying about arbitrary bit offsets. - BitArray is renamed ParsableBitArray for consistency, and is now exclusively for bit-stream level reading. - There are some temporary methods in ParsableByteArray that should be cleared up once the optimizations are in place. Issue: #278
Oliver Woodman committed -
This is the start of a sequence of changes to fix the ref'd github issue. Currently TsExtractor involves multiple memory copy steps: DataSource->Ts_BitArray->Pes_BitArray->Sample->SampleHolder This is inefficient, but more importantly, the copy into Sample is problematic, because Samples are of dynamically varying size. The way we end up expanding Sample objects to be large enough to hold the data being written means that we end up gradually expanding all Sample objects in the pool (which wastes memory), and that we generate a lot of GC churn, particularly when switching to a higher quality which can trigger all Sample objects to expand. The fix will be to reduce the copy steps to: DataSource->TsPacket->SampleHolder We will track Pes and Sample data with lists of pointers into TsPackets, rather than actually copying the data. We will recycle these pointers. The following steps are approximately how the refactor will progress: 1. Start reducing use of BitArray. It's going to be way too complicated to track bit-granularity offsets into multiple packets, and allow reading across packet boundaries. In practice reads from Ts packets are all byte aligned except for small sections, so we'll move over to using ParsableByteArray instead, so we only need to track byte offsets. 2. Move TsExtractor to use ParsableByteArray except for small sections where we really need bit-granularity offsets. 3. Do the actual optimization. Issue: #278
Oliver Woodman committed
-
- 09 Feb, 2015 2 commits
-
-
- Also make text renderers respect the decodeOnly flag. - Also fix AC3 passthrough to always allocate direct buffers.
Oliver Woodman committed -
Oliver Woodman committed
-
- 06 Feb, 2015 5 commits
-
-
- Remove simple variant. Maintaining both simple + full is unnecessary effort. - Remove need to specify content id in Sample definition, except where it's actually required (for DRM requests in the Widevine GTS samples)
Oliver Woodman committed -
Also add parseMp4vFromParent and return the track's duration in parseTrak. This is in preparation for adding a non-fragmented MP4 extractor.
Oliver Woodman committed -
If the timesource track renderer ends, but other track renderers haven't finished, the player would get stuck in a pending state. This change enables automatic switching to the media clock in the case that the timesource renderer has ended, which allows other renderers to continue to play.
Oliver Woodman committed -
Oliver Woodman committed
-
Oliver Woodman committed
-
- 03 Feb, 2015 3 commits
-
-
Add a utility for converting named atom types to integers. Add atom types for non-fragmented MP4 parsing.
Oliver Woodman committed -
Oliver Woodman committed
-
Issue: #268
Oliver Woodman committed
-
- 02 Feb, 2015 4 commits
-
-
Oliver Woodman committed
-
These may occur in VOD streams where a representation's data is small enough not to require segmentation or an index. For example subtitle files. Issue: #268
Oliver Woodman committed -
SampleExtractor will initially only be implemented by FrameworkSampleExtractor which delegates to a MediaExtractor, but eventually it will also be implemented by additional extractors. The sample extractor can be used as a source of samples via DefaultSampleSource.
Oliver Woodman committed -
Issue: #268
Oliver Woodman committed
-
- 27 Jan, 2015 5 commits
-
-
This may be painful in terms of applications having to change their imports. Sorry about that.
Oliver Woodman committed -
Merge dev-hls -> dev
Andrey Udovenko committed -
Oliver Woodman committed
-
Oliver Woodman committed
-
dev -> dev-hls
ojw28 committed
-
- 26 Jan, 2015 8 commits
-
-
Oliver Woodman committed
-
Oliver Woodman committed
-
Oliver Woodman committed
-
Oliver Woodman committed
-
Oliver Woodman committed
-
Also added clamping to getSegmentNum in one case where it was not already implemented, and defined this behavior property in the getSegmentNum javadoc. Issue: #262
Oliver Woodman committed -
This makes the calculation correct for the case where periodDurationMs does not divide exactly into durationMs.
Oliver Woodman committed -
Fixed wrong calculation of last segment number when using segment templa...
ojw28 committed
-
- 25 Jan, 2015 1 commit
-
-
Fixed wrong calculation of last segment number when using segment template without segment timeline.
Ihor Zakhozhyi committed
-
- 23 Jan, 2015 4 commits
-
-
dev -> dev-hls
ojw28 committed -
Oliver Woodman committed
-
Oliver Woodman committed
-
Oliver Woodman committed
-