Skip to content

SDK / exoplayer

Go to a project
Commit faa796d7 by huangdarwin Committed by Marc Baechinger
Options

HDR: Disable tone mapping on unsupported pixel build ID. 

Also, update tests to allow AnyOf error codes, and no longer check exception messages, which caused quite a bit of churn.

PiperOrigin-RevId: 479570861
parent 7c68b8d4
Inline Side-by-side
Showing with 24 additions and 55 deletions
library/common/src/main/java/com/google/android/exoplayer2/util/Util.java
...@@ -124,8 +124,8 @@ import org.checkerframework.checker.nullness.qual.PolyNull; ...@@ -124,8 +124,8 @@ import org.checkerframework.checker.nullness.qual.PolyNull;
public final class Util { public final class Util {
/** /**
* Like {@link android.os.Build.VERSION#SDK_INT}, but in a place where it can be conveniently * Like {@link Build.VERSION#SDK_INT}, but in a place where it can be conveniently overridden for
* overridden for local testing. * local testing.
*/ */
public static final int SDK_INT = Build.VERSION.SDK_INT; public static final int SDK_INT = Build.VERSION.SDK_INT;
......
library/transformer/src/androidTest/java/com/google/android/exoplayer2/transformer/mh/SetHdrEditingTest.java
...@@ -77,10 +77,6 @@ public class SetHdrEditingTest { ...@@ -77,10 +77,6 @@ public class SetHdrEditingTest {
assertThat(exception).hasCauseThat().isInstanceOf(IllegalArgumentException.class); assertThat(exception).hasCauseThat().isInstanceOf(IllegalArgumentException.class);
assertThat(exception.errorCode) assertThat(exception.errorCode)
.isEqualTo(TransformationException.ERROR_CODE_HDR_EDITING_UNSUPPORTED); .isEqualTo(TransformationException.ERROR_CODE_HDR_EDITING_UNSUPPORTED);
assertThat(exception)
.hasCauseThat()
.hasMessageThat()
.isEqualTo("HDR editing and tone mapping not supported under API 31.");
} }
} }
...@@ -155,22 +151,11 @@ public class SetHdrEditingTest { ...@@ -155,22 +151,11 @@ public class SetHdrEditingTest {
} catch (TransformationException exception) { } catch (TransformationException exception) {
Log.i(TAG, checkNotNull(exception.getCause()).toString()); Log.i(TAG, checkNotNull(exception.getCause()).toString());
assertThat(exception).hasCauseThat().isInstanceOf(IllegalArgumentException.class); assertThat(exception).hasCauseThat().isInstanceOf(IllegalArgumentException.class);
if (Util.SDK_INT < 31) { assertThat(exception.errorCode)
assertThat(exception.errorCode) .isAnyOf(
.isEqualTo(TransformationException.ERROR_CODE_HDR_EDITING_UNSUPPORTED); TransformationException.ERROR_CODE_HDR_EDITING_UNSUPPORTED,
assertThat(exception) TransformationException.ERROR_CODE_DECODING_FORMAT_UNSUPPORTED);
.hasCauseThat() assertThat(isFallbackListenerInvoked.get()).isFalse();
.hasMessageThat()
.isEqualTo("HDR editing and tone mapping not supported under API 31.");
} else {
assertThat(exception.errorCode)
.isEqualTo(TransformationException.ERROR_CODE_DECODING_FORMAT_UNSUPPORTED);
assertThat(exception)
.hasCauseThat()
.hasMessageThat()
.isEqualTo("Tone-mapping requested but not supported by the decoder.");
assertThat(isFallbackListenerInvoked.get()).isFalse();
}
return; return;
} }
} }
......
library/transformer/src/androidTest/java/com/google/android/exoplayer2/transformer/mh/SetHdrToSdrToneMapTest.java
...@@ -32,7 +32,6 @@ import com.google.android.exoplayer2.transformer.TransformationTestResult; ...@@ -32,7 +32,6 @@ import com.google.android.exoplayer2.transformer.TransformationTestResult;
import com.google.android.exoplayer2.transformer.Transformer; import com.google.android.exoplayer2.transformer.Transformer;
import com.google.android.exoplayer2.transformer.TransformerAndroidTestRunner; import com.google.android.exoplayer2.transformer.TransformerAndroidTestRunner;
import com.google.android.exoplayer2.util.Log; import com.google.android.exoplayer2.util.Log;
import com.google.android.exoplayer2.util.Util;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
...@@ -76,21 +75,10 @@ public class SetHdrToSdrToneMapTest { ...@@ -76,21 +75,10 @@ public class SetHdrToSdrToneMapTest {
} catch (TransformationException exception) { } catch (TransformationException exception) {
Log.i(TAG, checkNotNull(exception.getCause()).toString()); Log.i(TAG, checkNotNull(exception.getCause()).toString());
assertThat(exception).hasCauseThat().isInstanceOf(IllegalArgumentException.class); assertThat(exception).hasCauseThat().isInstanceOf(IllegalArgumentException.class);
if (Util.SDK_INT < 31) { assertThat(exception.errorCode)
assertThat(exception.errorCode) .isAnyOf(
.isEqualTo(TransformationException.ERROR_CODE_HDR_EDITING_UNSUPPORTED); TransformationException.ERROR_CODE_HDR_EDITING_UNSUPPORTED,
assertThat(exception) TransformationException.ERROR_CODE_DECODING_FORMAT_UNSUPPORTED);
.hasCauseThat()
.hasMessageThat()
.isEqualTo("HDR editing and tone mapping not supported under API 31.");
} else {
assertThat(exception.errorCode)
.isEqualTo(TransformationException.ERROR_CODE_DECODING_FORMAT_UNSUPPORTED);
assertThat(exception)
.hasCauseThat()
.hasMessageThat()
.isEqualTo("Tone-mapping requested but not supported by the decoder.");
}
return; return;
} }
} }
...@@ -133,21 +121,10 @@ public class SetHdrToSdrToneMapTest { ...@@ -133,21 +121,10 @@ public class SetHdrToSdrToneMapTest {
} catch (TransformationException exception) { } catch (TransformationException exception) {
Log.i(TAG, checkNotNull(exception.getCause()).toString()); Log.i(TAG, checkNotNull(exception.getCause()).toString());
assertThat(exception).hasCauseThat().isInstanceOf(IllegalArgumentException.class); assertThat(exception).hasCauseThat().isInstanceOf(IllegalArgumentException.class);
if (Util.SDK_INT < 31) { assertThat(exception.errorCode)
assertThat(exception.errorCode) .isAnyOf(
.isEqualTo(TransformationException.ERROR_CODE_HDR_EDITING_UNSUPPORTED); TransformationException.ERROR_CODE_HDR_EDITING_UNSUPPORTED,
assertThat(exception) TransformationException.ERROR_CODE_DECODING_FORMAT_UNSUPPORTED);
.hasCauseThat()
.hasMessageThat()
.isEqualTo("HDR editing and tone mapping not supported under API 31.");
} else {
assertThat(exception.errorCode)
.isEqualTo(TransformationException.ERROR_CODE_DECODING_FORMAT_UNSUPPORTED);
assertThat(exception)
.hasCauseThat()
.hasMessageThat()
.isEqualTo("Tone-mapping requested but not supported by the decoder.");
}
return; return;
} }
} }
......
library/transformer/src/main/java/com/google/android/exoplayer2/transformer/VideoTranscodingSamplePipeline.java
...@@ -22,6 +22,7 @@ import static com.google.android.exoplayer2.util.Util.SDK_INT; ...@@ -22,6 +22,7 @@ import static com.google.android.exoplayer2.util.Util.SDK_INT;
import android.content.Context; import android.content.Context;
import android.media.MediaCodec; import android.media.MediaCodec;
import android.os.Build;
import android.view.Surface; import android.view.Surface;
import androidx.annotation.Nullable; import androidx.annotation.Nullable;
import androidx.annotation.VisibleForTesting; import androidx.annotation.VisibleForTesting;
...@@ -76,9 +77,10 @@ import org.checkerframework.dataflow.qual.Pure; ...@@ -76,9 +77,10 @@ import org.checkerframework.dataflow.qual.Pure;
Transformer.AsyncErrorListener asyncErrorListener, Transformer.AsyncErrorListener asyncErrorListener,
DebugViewProvider debugViewProvider) DebugViewProvider debugViewProvider)
throws TransformationException { throws TransformationException {
if (SDK_INT < 31 && ColorInfo.isTransferHdr(inputFormat.colorInfo)) { if (ColorInfo.isTransferHdr(inputFormat.colorInfo)
&& (SDK_INT < 31 || deviceNeedsNoToneMappingWorkaround())) {
throw TransformationException.createForCodec( throw TransformationException.createForCodec(
new IllegalArgumentException("HDR editing and tone mapping not supported under API 31."), new IllegalArgumentException("HDR editing and tone mapping not supported."),
/* isVideo= */ true, /* isVideo= */ true,
/* isDecoder= */ false, /* isDecoder= */ false,
inputFormat, inputFormat,
...@@ -290,6 +292,11 @@ import org.checkerframework.dataflow.qual.Pure; ...@@ -290,6 +292,11 @@ import org.checkerframework.dataflow.qual.Pure;
.build(); .build();
} }
private static boolean deviceNeedsNoToneMappingWorkaround() {
// Pixel build ID does not support tone mapping. See http://b/249297370#comment8.
return Build.ID.startsWith("TP1A.220905.004");
}
/** /**
* Feeds at most one decoder output frame to the next step of the pipeline. * Feeds at most one decoder output frame to the next step of the pipeline.
* *
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment