Commit e335022e by samrobinson Committed by bachinger

Fix mediaMetadata being reset when media is repeated.

Issue: #9458
PiperOrigin-RevId: 399901865
parent 410ddf45
...@@ -13,6 +13,8 @@ ...@@ -13,6 +13,8 @@
`GlUtil.glAssertionsEnabled` instead. `GlUtil.glAssertionsEnabled` instead.
* Move `Player.addListener(EventListener)` and * Move `Player.addListener(EventListener)` and
`Player.removeListener(EventListener)` out of `Player` into subclasses. `Player.removeListener(EventListener)` out of `Player` into subclasses.
* Fix `mediaMetadata` being reset when media is
repeated ([#9458](https://github.com/google/ExoPlayer/issues/9458)).
* Video: * Video:
* Fix bug in `MediaCodecVideoRenderer` that resulted in re-using a * Fix bug in `MediaCodecVideoRenderer` that resulted in re-using a
released `Surface` when playing without an app-provided `Surface` released `Surface` when playing without an app-provided `Surface`
......
...@@ -1219,7 +1219,8 @@ import java.util.concurrent.CopyOnWriteArraySet; ...@@ -1219,7 +1219,8 @@ import java.util.concurrent.CopyOnWriteArraySet;
} }
newMediaMetadata = mediaItem != null ? mediaItem.mediaMetadata : MediaMetadata.EMPTY; newMediaMetadata = mediaItem != null ? mediaItem.mediaMetadata : MediaMetadata.EMPTY;
} }
if (!previousPlaybackInfo.staticMetadata.equals(newPlaybackInfo.staticMetadata)) { if (mediaItemTransitioned
|| !previousPlaybackInfo.staticMetadata.equals(newPlaybackInfo.staticMetadata)) {
newMediaMetadata = newMediaMetadata =
newMediaMetadata.buildUpon().populateFromMetadata(newPlaybackInfo.staticMetadata).build(); newMediaMetadata.buildUpon().populateFromMetadata(newPlaybackInfo.staticMetadata).build();
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment