Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
e335022e
authored
Sep 30, 2021
by
samrobinson
Committed by
bachinger
Sep 30, 2021
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Fix mediaMetadata being reset when media is repeated.
Issue: #9458 PiperOrigin-RevId: 399901865
parent
410ddf45
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
1 deletions
RELEASENOTES.md
library/core/src/main/java/com/google/android/exoplayer2/ExoPlayerImpl.java
RELEASENOTES.md
View file @
e335022e
...
@@ -13,6 +13,8 @@
...
@@ -13,6 +13,8 @@
`GlUtil.glAssertionsEnabled`
instead.
`GlUtil.glAssertionsEnabled`
instead.
*
Move
`Player.addListener(EventListener)`
and
*
Move
`Player.addListener(EventListener)`
and
`Player.removeListener(EventListener)`
out of
`Player`
into subclasses.
`Player.removeListener(EventListener)`
out of
`Player`
into subclasses.
*
Fix
`mediaMetadata`
being reset when media is
repeated (
[
#9458
](
https://github.com/google/ExoPlayer/issues/9458
)
).
*
Video:
*
Video:
*
Fix bug in
`MediaCodecVideoRenderer`
that resulted in re-using a
*
Fix bug in
`MediaCodecVideoRenderer`
that resulted in re-using a
released
`Surface`
when playing without an app-provided
`Surface`
released
`Surface`
when playing without an app-provided
`Surface`
...
...
library/core/src/main/java/com/google/android/exoplayer2/ExoPlayerImpl.java
View file @
e335022e
...
@@ -1219,7 +1219,8 @@ import java.util.concurrent.CopyOnWriteArraySet;
...
@@ -1219,7 +1219,8 @@ import java.util.concurrent.CopyOnWriteArraySet;
}
}
newMediaMetadata
=
mediaItem
!=
null
?
mediaItem
.
mediaMetadata
:
MediaMetadata
.
EMPTY
;
newMediaMetadata
=
mediaItem
!=
null
?
mediaItem
.
mediaMetadata
:
MediaMetadata
.
EMPTY
;
}
}
if
(!
previousPlaybackInfo
.
staticMetadata
.
equals
(
newPlaybackInfo
.
staticMetadata
))
{
if
(
mediaItemTransitioned
||
!
previousPlaybackInfo
.
staticMetadata
.
equals
(
newPlaybackInfo
.
staticMetadata
))
{
newMediaMetadata
=
newMediaMetadata
=
newMediaMetadata
.
buildUpon
().
populateFromMetadata
(
newPlaybackInfo
.
staticMetadata
).
build
();
newMediaMetadata
.
buildUpon
().
populateFromMetadata
(
newPlaybackInfo
.
staticMetadata
).
build
();
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment