Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
e1eb8b6d
authored
Nov 16, 2022
by
bachinger
Committed by
microkatz
Nov 16, 2022
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Add pending sequence before sending the remote session task
#minor-release PiperOrigin-RevId: 488885069
parent
cfe36af8
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
6 deletions
libraries/session/src/main/java/androidx/media3/session/MediaBrowserImplBase.java
libraries/session/src/main/java/androidx/media3/session/MediaControllerImplBase.java
libraries/session/src/main/java/androidx/media3/session/MediaBrowserImplBase.java
View file @
e1eb8b6d
...
@@ -194,7 +194,8 @@ import org.checkerframework.checker.initialization.qual.UnderInitialization;
...
@@ -194,7 +194,8 @@ import org.checkerframework.checker.initialization.qual.UnderInitialization;
task
.
run
(
iSession
,
result
.
getSequenceNumber
());
task
.
run
(
iSession
,
result
.
getSequenceNumber
());
}
catch
(
RemoteException
e
)
{
}
catch
(
RemoteException
e
)
{
Log
.
w
(
TAG
,
"Cannot connect to the service or the session is gone"
,
e
);
Log
.
w
(
TAG
,
"Cannot connect to the service or the session is gone"
,
e
);
result
.
set
(
LibraryResult
.
ofError
(
RESULT_ERROR_SESSION_DISCONNECTED
));
sequencedFutureManager
.
setFutureResult
(
result
.
getSequenceNumber
(),
LibraryResult
.
ofError
(
RESULT_ERROR_SESSION_DISCONNECTED
));
}
}
return
result
;
return
result
;
}
else
{
}
else
{
...
...
libraries/session/src/main/java/androidx/media3/session/MediaControllerImplBase.java
View file @
e1eb8b6d
...
@@ -340,15 +340,17 @@ import org.checkerframework.checker.nullness.qual.NonNull;
...
@@ -340,15 +340,17 @@ import org.checkerframework.checker.nullness.qual.NonNull;
SequencedFutureManager
.
SequencedFuture
<
SessionResult
>
result
=
SequencedFutureManager
.
SequencedFuture
<
SessionResult
>
result
=
sequencedFutureManager
.
createSequencedFuture
(
sequencedFutureManager
.
createSequencedFuture
(
new
SessionResult
(
SessionResult
.
RESULT_INFO_SKIPPED
));
new
SessionResult
(
SessionResult
.
RESULT_INFO_SKIPPED
));
int
sequenceNumber
=
result
.
getSequenceNumber
();
if
(
addToPendingMaskingOperations
)
{
pendingMaskingSequencedFutureNumbers
.
add
(
sequenceNumber
);
}
try
{
try
{
int
sequenceNumber
=
result
.
getSequenceNumber
();
task
.
run
(
iSession
,
sequenceNumber
);
task
.
run
(
iSession
,
sequenceNumber
);
if
(
addToPendingMaskingOperations
)
{
pendingMaskingSequencedFutureNumbers
.
add
(
sequenceNumber
);
}
}
catch
(
RemoteException
e
)
{
}
catch
(
RemoteException
e
)
{
Log
.
w
(
TAG
,
"Cannot connect to the service or the session is gone"
,
e
);
Log
.
w
(
TAG
,
"Cannot connect to the service or the session is gone"
,
e
);
result
.
set
(
new
SessionResult
(
SessionResult
.
RESULT_ERROR_SESSION_DISCONNECTED
));
pendingMaskingSequencedFutureNumbers
.
remove
(
sequenceNumber
);
sequencedFutureManager
.
setFutureResult
(
sequenceNumber
,
new
SessionResult
(
SessionResult
.
RESULT_ERROR_SESSION_DISCONNECTED
));
}
}
return
result
;
return
result
;
}
else
{
}
else
{
...
@@ -2173,6 +2175,13 @@ import org.checkerframework.checker.nullness.qual.NonNull;
...
@@ -2173,6 +2175,13 @@ import org.checkerframework.checker.nullness.qual.NonNull;
// Never happens because future.setException will not be called.
// Never happens because future.setException will not be called.
throw
new
IllegalStateException
(
e
);
throw
new
IllegalStateException
(
e
);
}
catch
(
TimeoutException
e
)
{
}
catch
(
TimeoutException
e
)
{
if
(
future
instanceof
SequencedFutureManager
.
SequencedFuture
)
{
int
sequenceNumber
=
((
SequencedFutureManager
.
SequencedFuture
<
SessionResult
>)
future
).
getSequenceNumber
();
pendingMaskingSequencedFutureNumbers
.
remove
(
sequenceNumber
);
sequencedFutureManager
.
setFutureResult
(
sequenceNumber
,
new
SessionResult
(
SessionResult
.
RESULT_ERROR_UNKNOWN
));
}
Log
.
w
(
TAG
,
"set/clearVideoSurface takes too long on the session side."
,
e
);
Log
.
w
(
TAG
,
"set/clearVideoSurface takes too long on the session side."
,
e
);
// TODO(b/188888693): Let developers know the failure in their code.
// TODO(b/188888693): Let developers know the failure in their code.
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment