split and deprecate PlaybackParameters in AudioSink

This change deprecates PlaybackParameter in AudioSink and splits it into playbackSpeed and skipSilenceEnabled. These properties are set separately in a future CL. The playback speed will be set through the MediaClock, while skipSilenceEnabled will be set by sending a message to the audio renderer.

PiperOrigin-RevId: 296457043

library/core/src/main/java/com/google/android/exoplayer2/audio/AudioSink.java

@@ -263,18 +263,28 @@ public interface AudioSink {
   boolean hasPendingData();
 
   /**
-   * Attempts to set the playback parameters. The audio sink may override these parameters if they
-   * are not supported.
-   *
-   * @param playbackParameters The new playback parameters to attempt to set.
+   * @deprecated Use {@link #setPlaybackSpeed(float)} and {@link #setSkipSilenceEnabled(boolean)}
+   *     instead.
    */
+  @Deprecated
   void setPlaybackParameters(PlaybackParameters playbackParameters);
 
-  /**
-   * Gets the active {@link PlaybackParameters}.
-   */
+  /** @deprecated Use {@link #getPlaybackSpeed()} and {@link #getSkipSilenceEnabled()} instead. */
+  @Deprecated
   PlaybackParameters getPlaybackParameters();
 
+  /** Sets the playback speed. */
+  void setPlaybackSpeed(float playbackSpeed);
+
+  /** Gets the playback speed. */
+  float getPlaybackSpeed();
+
+  /** Sets whether silences should be skipped in the audio stream. */
+  void setSkipSilenceEnabled(boolean skipSilenceEnabled);
+
+  /** Gets whether silences are skipped in the audio stream. */
+  boolean getSkipSilenceEnabled();
+
   /**
    * Sets attributes for audio playback. If the attributes have changed and if the sink is not
    * configured for use with tunneling, then it is reset and the audio session id is cleared.

library/core/src/main/java/com/google/android/exoplayer2/audio/ForwardingAudioSink.java

@@ -95,14 +95,42 @@ public class ForwardingAudioSink implements AudioSink {
     return sink.hasPendingData();
   }
 
+  /**
+   * @deprecated Use {@link #setPlaybackSpeed(float)} and {@link #setSkipSilenceEnabled(boolean)}
+   *     instead.
+   */
+  @Deprecated
   @Override
   public void setPlaybackParameters(PlaybackParameters playbackParameters) {
-    sink.setPlaybackParameters(playbackParameters);
+    sink.setPlaybackSpeed(playbackParameters.speed);
+    sink.setSkipSilenceEnabled(playbackParameters.skipSilence);
   }
 
+  /** @deprecated Use {@link #getPlaybackSpeed()} and {@link #getSkipSilenceEnabled()} instead. */
+  @Deprecated
   @Override
   public PlaybackParameters getPlaybackParameters() {
-    return sink.getPlaybackParameters();
+    return new PlaybackParameters(sink.getPlaybackSpeed(), sink.getSkipSilenceEnabled());
+  }
+
+  @Override
+  public void setPlaybackSpeed(float playbackSpeed) {
+    sink.setPlaybackSpeed(playbackSpeed);
+  }
+
+  @Override
+  public float getPlaybackSpeed() {
+    return sink.getPlaybackSpeed();
+  }
+
+  @Override
+  public void setSkipSilenceEnabled(boolean skipSilenceEnabled) {
+    sink.setSkipSilenceEnabled(skipSilenceEnabled);
+  }
+
+  @Override
+  public boolean getSkipSilenceEnabled() {
+    return sink.getSkipSilenceEnabled();
   }
 
   @Override

library/core/src/test/java/com/google/android/exoplayer2/audio/DefaultAudioSinkTest.java

@@ -21,7 +21,6 @@ import static org.robolectric.annotation.Config.TARGET_SDK;
 
 import androidx.test.ext.junit.runners.AndroidJUnit4;
 import com.google.android.exoplayer2.C;
-import com.google.android.exoplayer2.PlaybackParameters;
 import java.nio.ByteBuffer;
 import java.nio.ByteOrder;
 import java.util.Arrays;
@@ -89,8 +88,7 @@ public final class DefaultAudioSinkTest {
 
   @Test
   public void handlesBufferAfterReset_withPlaybackParameters() throws Exception {
-    PlaybackParameters playbackParameters = new PlaybackParameters(1.5f);
-    defaultAudioSink.setPlaybackParameters(playbackParameters);
+    defaultAudioSink.setPlaybackSpeed(/* playbackSpeed= */ 1.5f);
     configureDefaultAudioSink(CHANNEL_COUNT_STEREO);
     defaultAudioSink.handleBuffer(
         createDefaultSilenceBuffer(), /* presentationTimeUs= */ 0, /* encodedAccessUnitCount= */ 1);
@@ -100,7 +98,7 @@ public final class DefaultAudioSinkTest {
     configureDefaultAudioSink(CHANNEL_COUNT_STEREO);
     defaultAudioSink.handleBuffer(
         createDefaultSilenceBuffer(), /* presentationTimeUs= */ 0, /* encodedAccessUnitCount= */ 1);
-    assertThat(defaultAudioSink.getPlaybackParameters()).isEqualTo(playbackParameters);
+    assertThat(defaultAudioSink.getPlaybackSpeed()).isEqualTo(1.5f);
   }
 
   @Test
@@ -118,8 +116,7 @@ public final class DefaultAudioSinkTest {
 
   @Test
   public void handlesBufferAfterReset_withFormatChangeAndPlaybackParameters() throws Exception {
-    PlaybackParameters playbackParameters = new PlaybackParameters(1.5f);
-    defaultAudioSink.setPlaybackParameters(playbackParameters);
+    defaultAudioSink.setPlaybackSpeed(/* playbackSpeed= */ 1.5f);
     configureDefaultAudioSink(CHANNEL_COUNT_STEREO);
     defaultAudioSink.handleBuffer(
         createDefaultSilenceBuffer(), /* presentationTimeUs= */ 0, /* encodedAccessUnitCount= */ 1);
@@ -129,7 +126,7 @@ public final class DefaultAudioSinkTest {
     configureDefaultAudioSink(CHANNEL_COUNT_MONO);
     defaultAudioSink.handleBuffer(
         createDefaultSilenceBuffer(), /* presentationTimeUs= */ 0, /* encodedAccessUnitCount= */ 1);
-    assertThat(defaultAudioSink.getPlaybackParameters()).isEqualTo(playbackParameters);
+    assertThat(defaultAudioSink.getPlaybackSpeed()).isEqualTo(1.5f);
   }
 
   @Test