Commit 9a8026f2 by samrobinson Committed by Andrew Lewis

Only log list of removed encoders if not empty.

Logcat had the following lines, with no other information.
```
DefaultEncoderFactory: Encoders removed for resolution:
DefaultEncoderFactory: Encoders removed for bitrate:
DefaultEncoderFactory: Encoders removed for bitrate mode:
```
PiperOrigin-RevId: 511470231
parent 12a61833
...@@ -628,15 +628,9 @@ public final class DefaultEncoderFactory implements Codec.EncoderFactory { ...@@ -628,15 +628,9 @@ public final class DefaultEncoderFactory implements Codec.EncoderFactory {
} }
} }
List<MediaCodecInfo> removedEncoders = new ArrayList<>(encoders); if (filteredEncoders.size() != encoders.size()) {
removedEncoders.removeAll(filteredEncoders); logRemovedEncoders(encoders, filteredEncoders, filterName);
StringBuilder stringBuilder =
new StringBuilder("Encoders removed for ").append(filterName).append(":\n");
for (int i = 0; i < removedEncoders.size(); i++) {
MediaCodecInfo encoderInfo = removedEncoders.get(i);
stringBuilder.append(Util.formatInvariant(" %s\n", encoderInfo.getName()));
} }
Log.d(TAG, stringBuilder.toString());
return ImmutableList.copyOf(filteredEncoders); return ImmutableList.copyOf(filteredEncoders);
} }
...@@ -670,4 +664,17 @@ public final class DefaultEncoderFactory implements Codec.EncoderFactory { ...@@ -670,4 +664,17 @@ public final class DefaultEncoderFactory implements Codec.EncoderFactory {
/* isDecoder= */ false, /* isDecoder= */ false,
format); format);
} }
private static void logRemovedEncoders(
List<MediaCodecInfo> encoders, List<MediaCodecInfo> filteredEncoders, String filterName) {
List<MediaCodecInfo> removedEncoders = new ArrayList<>(encoders);
removedEncoders.removeAll(filteredEncoders);
StringBuilder stringBuilder =
new StringBuilder("Encoders removed for ").append(filterName).append(":\n");
for (int i = 0; i < removedEncoders.size(); i++) {
MediaCodecInfo encoderInfo = removedEncoders.get(i);
stringBuilder.append(Util.formatInvariant(" %s\n", encoderInfo.getName()));
}
Log.d(TAG, stringBuilder.toString());
}
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment