Commit 97a80ac6 by bachinger Committed by Oliver Woodman

Make ConcatentatingMediaSource provide a dummy media item

PiperOrigin-RevId: 314904897
parent b874b1d5
...@@ -15,12 +15,14 @@ ...@@ -15,12 +15,14 @@
*/ */
package com.google.android.exoplayer2.source; package com.google.android.exoplayer2.source;
import android.net.Uri;
import android.os.Handler; import android.os.Handler;
import android.os.Message; import android.os.Message;
import androidx.annotation.GuardedBy; import androidx.annotation.GuardedBy;
import androidx.annotation.Nullable; import androidx.annotation.Nullable;
import com.google.android.exoplayer2.AbstractConcatenatedTimeline; import com.google.android.exoplayer2.AbstractConcatenatedTimeline;
import com.google.android.exoplayer2.C; import com.google.android.exoplayer2.C;
import com.google.android.exoplayer2.MediaItem;
import com.google.android.exoplayer2.Timeline; import com.google.android.exoplayer2.Timeline;
import com.google.android.exoplayer2.source.ConcatenatingMediaSource.MediaSourceHolder; import com.google.android.exoplayer2.source.ConcatenatingMediaSource.MediaSourceHolder;
import com.google.android.exoplayer2.source.ShuffleOrder.DefaultShuffleOrder; import com.google.android.exoplayer2.source.ShuffleOrder.DefaultShuffleOrder;
...@@ -54,6 +56,9 @@ public final class ConcatenatingMediaSource extends CompositeMediaSource<MediaSo ...@@ -54,6 +56,9 @@ public final class ConcatenatingMediaSource extends CompositeMediaSource<MediaSo
private static final int MSG_UPDATE_TIMELINE = 4; private static final int MSG_UPDATE_TIMELINE = 4;
private static final int MSG_ON_COMPLETION = 5; private static final int MSG_ON_COMPLETION = 5;
private static final MediaItem DUMMY_MEDIA_ITEM =
new MediaItem.Builder().setUri(Uri.EMPTY).build();
// Accessed on any thread. // Accessed on any thread.
@GuardedBy("this") @GuardedBy("this")
private final List<MediaSourceHolder> mediaSourcesPublic; private final List<MediaSourceHolder> mediaSourcesPublic;
...@@ -437,10 +442,11 @@ public final class ConcatenatingMediaSource extends CompositeMediaSource<MediaSo ...@@ -437,10 +442,11 @@ public final class ConcatenatingMediaSource extends CompositeMediaSource<MediaSo
// CompositeMediaSource implementation. // CompositeMediaSource implementation.
@Override // TODO(bachinger): add @Override annotation once the method is defined by MediaSource.
@Nullable public MediaItem getMediaItem() {
public Object getTag() { // This method is actually never called because getInitialTimeline is implemented and hence the
return null; // MaskingMediaSource does not need to create a dummy timeline for this media source.
return DUMMY_MEDIA_ITEM;
} }
@Override @Override
...@@ -990,10 +996,9 @@ public final class ConcatenatingMediaSource extends CompositeMediaSource<MediaSo ...@@ -990,10 +996,9 @@ public final class ConcatenatingMediaSource extends CompositeMediaSource<MediaSo
// Do nothing. // Do nothing.
} }
@Override // TODO(bachinger): add @Override annotation once the method is defined by MediaSource.
@Nullable public MediaItem getMediaItem() {
public Object getTag() { return DUMMY_MEDIA_ITEM;
return null;
} }
@Override @Override
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment