Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
936a7789
authored
Aug 05, 2019
by
tonihei
Committed by
Oliver Woodman
Aug 05, 2019
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Check if controller is used when performing click directly.
Issue:#6260 PiperOrigin-RevId: 261647858
parent
b0c2b1a0
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
3 deletions
RELEASENOTES.md
library/ui/src/main/java/com/google/android/exoplayer2/ui/PlayerView.java
RELEASENOTES.md
View file @
936a7789
...
@@ -24,6 +24,9 @@
...
@@ -24,6 +24,9 @@
(
[
#6192
](
https://github.com/google/ExoPlayer/issues/6192
)
).
(
[
#6192
](
https://github.com/google/ExoPlayer/issues/6192
)
).
*
Fix Flac and ALAC playback on some LG devices
*
Fix Flac and ALAC playback on some LG devices
(
[
#5938
](
https://github.com/google/ExoPlayer/issues/5938
)
).
(
[
#5938
](
https://github.com/google/ExoPlayer/issues/5938
)
).
*
Fix issue when calling
`performClick`
on
`PlayerView`
without
`PlayerControlView`
(
[
#6260
](
https://github.com/google/ExoPlayer/issues/6260
)
).
### 2.10.3 ###
### 2.10.3 ###
...
...
library/ui/src/main/java/com/google/android/exoplayer2/ui/PlayerView.java
View file @
936a7789
...
@@ -1156,6 +1156,9 @@ public class PlayerView extends FrameLayout implements AdsLoader.AdViewProvider
...
@@ -1156,6 +1156,9 @@ public class PlayerView extends FrameLayout implements AdsLoader.AdViewProvider
// Internal methods.
// Internal methods.
private
boolean
toggleControllerVisibility
()
{
private
boolean
toggleControllerVisibility
()
{
if
(!
useController
||
player
==
null
)
{
return
false
;
}
if
(!
controller
.
isVisible
())
{
if
(!
controller
.
isVisible
())
{
maybeShowController
(
true
);
maybeShowController
(
true
);
}
else
if
(
controllerHideOnTouch
)
{
}
else
if
(
controllerHideOnTouch
)
{
...
@@ -1492,9 +1495,6 @@ public class PlayerView extends FrameLayout implements AdsLoader.AdViewProvider
...
@@ -1492,9 +1495,6 @@ public class PlayerView extends FrameLayout implements AdsLoader.AdViewProvider
@Override
@Override
public
boolean
onSingleTapUp
(
MotionEvent
e
)
{
public
boolean
onSingleTapUp
(
MotionEvent
e
)
{
if
(!
useController
||
player
==
null
)
{
return
false
;
}
return
toggleControllerVisibility
();
return
toggleControllerVisibility
();
}
}
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment