Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
89fe0d0c
authored
Jun 02, 2021
by
aquilescanta
Committed by
bachinger
Jun 03, 2021
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Make AnalyticsListener.onPlayerError take a PlaybackException
NO_EXTERNAL PiperOrigin-RevId: 377090819
parent
a8e96da1
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
9 additions
and
10 deletions
library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsListener.java
library/core/src/main/java/com/google/android/exoplayer2/util/EventLogger.java
library/core/src/test/java/com/google/android/exoplayer2/ExoPlayerTest.java
library/core/src/test/java/com/google/android/exoplayer2/analytics/AnalyticsCollectorTest.java
library/transformer/src/main/java/com/google/android/exoplayer2/transformer/Transformer.java
library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsListener.java
View file @
89fe0d0c
...
...
@@ -26,10 +26,10 @@ import android.view.Surface;
import
androidx.annotation.IntDef
;
import
androidx.annotation.Nullable
;
import
com.google.android.exoplayer2.C
;
import
com.google.android.exoplayer2.ExoPlaybackException
;
import
com.google.android.exoplayer2.Format
;
import
com.google.android.exoplayer2.MediaItem
;
import
com.google.android.exoplayer2.MediaMetadata
;
import
com.google.android.exoplayer2.PlaybackException
;
import
com.google.android.exoplayer2.PlaybackParameters
;
import
com.google.android.exoplayer2.Player
;
import
com.google.android.exoplayer2.Player.DiscontinuityReason
;
...
...
@@ -617,7 +617,7 @@ public interface AnalyticsListener {
* @param eventTime The event time.
* @param error The error.
*/
default
void
onPlayerError
(
EventTime
eventTime
,
Exo
PlaybackException
error
)
{}
default
void
onPlayerError
(
EventTime
eventTime
,
PlaybackException
error
)
{}
/**
* Called when the available or selected tracks for the renderers changed.
...
...
library/core/src/main/java/com/google/android/exoplayer2/util/EventLogger.java
View file @
89fe0d0c
...
...
@@ -21,7 +21,6 @@ import android.os.SystemClock;
import
android.text.TextUtils
;
import
androidx.annotation.Nullable
;
import
com.google.android.exoplayer2.C
;
import
com.google.android.exoplayer2.ExoPlaybackException
;
import
com.google.android.exoplayer2.Format
;
import
com.google.android.exoplayer2.MediaItem
;
import
com.google.android.exoplayer2.PlaybackException
;
...
...
@@ -245,7 +244,7 @@ public class EventLogger implements AnalyticsListener {
}
@Override
public
void
onPlayerError
(
EventTime
eventTime
,
Exo
PlaybackException
e
)
{
public
void
onPlayerError
(
EventTime
eventTime
,
PlaybackException
e
)
{
loge
(
eventTime
,
"playerFailed"
,
e
);
}
...
...
library/core/src/test/java/com/google/android/exoplayer2/ExoPlayerTest.java
View file @
89fe0d0c
...
...
@@ -7161,8 +7161,7 @@ public final class ExoPlayerTest {
player
.
addAnalyticsListener
(
new
AnalyticsListener
()
{
@Override
public
void
onPlayerError
(
EventTime
eventTime
,
ExoPlaybackException
error
)
{
public
void
onPlayerError
(
EventTime
eventTime
,
PlaybackException
error
)
{
timelineAfterError
.
set
(
player
.
getCurrentTimeline
());
trackGroupsAfterError
.
set
(
player
.
getCurrentTrackGroups
());
trackSelectionsAfterError
.
set
(
player
.
getCurrentTrackSelections
());
...
...
library/core/src/test/java/com/google/android/exoplayer2/analytics/AnalyticsCollectorTest.java
View file @
89fe0d0c
...
...
@@ -71,6 +71,7 @@ import com.google.android.exoplayer2.C;
import
com.google.android.exoplayer2.ExoPlaybackException
;
import
com.google.android.exoplayer2.Format
;
import
com.google.android.exoplayer2.MediaItem
;
import
com.google.android.exoplayer2.PlaybackException
;
import
com.google.android.exoplayer2.PlaybackParameters
;
import
com.google.android.exoplayer2.Player
;
import
com.google.android.exoplayer2.Renderer
;
...
...
@@ -1942,7 +1943,7 @@ public final class AnalyticsCollectorTest {
spy
(
new
AnalyticsListener
()
{
@Override
public
void
onPlayerError
(
EventTime
eventTime
,
Exo
PlaybackException
error
)
{
public
void
onPlayerError
(
EventTime
eventTime
,
PlaybackException
error
)
{
analyticsCollector
.
onSurfaceSizeChanged
(
/* width= */
0
,
/* height= */
0
);
}
});
...
...
@@ -2141,7 +2142,7 @@ public final class AnalyticsCollectorTest {
}
@Override
public
void
onPlayerError
(
EventTime
eventTime
,
Exo
PlaybackException
error
)
{
public
void
onPlayerError
(
EventTime
eventTime
,
PlaybackException
error
)
{
reportedEvents
.
add
(
new
ReportedEvent
(
EVENT_PLAYER_ERROR
,
eventTime
));
}
...
...
library/transformer/src/main/java/com/google/android/exoplayer2/transformer/Transformer.java
View file @
89fe0d0c
...
...
@@ -37,8 +37,8 @@ import androidx.annotation.RequiresApi;
import
androidx.annotation.VisibleForTesting
;
import
com.google.android.exoplayer2.C
;
import
com.google.android.exoplayer2.DefaultLoadControl
;
import
com.google.android.exoplayer2.ExoPlaybackException
;
import
com.google.android.exoplayer2.MediaItem
;
import
com.google.android.exoplayer2.PlaybackException
;
import
com.google.android.exoplayer2.Player
;
import
com.google.android.exoplayer2.Renderer
;
import
com.google.android.exoplayer2.RenderersFactory
;
...
...
@@ -639,7 +639,7 @@ public final class Transformer {
}
@Override
public
void
onPlayerError
(
EventTime
eventTime
,
Exo
PlaybackException
error
)
{
public
void
onPlayerError
(
EventTime
eventTime
,
PlaybackException
error
)
{
handleTransformationEnded
(
error
);
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment