Commit 845d2504 by andrewlewis Committed by Oliver Woodman

Restore renderer.isEnded check when updating the playback position.

If rendererMediaClock is non-null, the rendererMediaClockSource is enabled or
started, so remove the check in updatePositionUs.

When disabling renderers for track selection, renderers with changing track
selections always transition from started -> enabled.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=120819483
parent e88eeba8
...@@ -82,8 +82,8 @@ import java.util.concurrent.atomic.AtomicInteger; ...@@ -82,8 +82,8 @@ import java.util.concurrent.atomic.AtomicInteger;
private boolean playWhenReady; private boolean playWhenReady;
private boolean rebuffering; private boolean rebuffering;
private int state; private int state;
private int customMessagesSent = 0; private int customMessagesSent;
private int customMessagesProcessed = 0; private int customMessagesProcessed;
private long lastSeekPositionMs; private long lastSeekPositionMs;
private long elapsedRealtimeUs; private long elapsedRealtimeUs;
...@@ -322,8 +322,7 @@ import java.util.concurrent.atomic.AtomicInteger; ...@@ -322,8 +322,7 @@ import java.util.concurrent.atomic.AtomicInteger;
} }
private void updatePositionUs() { private void updatePositionUs() {
if (rendererMediaClock != null if (rendererMediaClockSource != null && !rendererMediaClockSource.isEnded()) {
&& rendererMediaClockSource.getState() != TrackRenderer.STATE_DISABLED) {
positionUs = rendererMediaClock.getPositionUs(); positionUs = rendererMediaClock.getPositionUs();
standaloneMediaClock.setPositionUs(positionUs); standaloneMediaClock.setPositionUs(positionUs);
} else { } else {
...@@ -582,10 +581,7 @@ import java.util.concurrent.atomic.AtomicInteger; ...@@ -582,10 +581,7 @@ import java.util.concurrent.atomic.AtomicInteger;
rendererMediaClockSource = null; rendererMediaClockSource = null;
} }
ensureStopped(renderer); ensureStopped(renderer);
if (renderer.getState() == TrackRenderer.STATE_ENABLED) { oldStreams.add(renderer.disable());
TrackStream trackStream = renderer.disable();
oldStreams.add(trackStream);
}
} }
if (newSelection != null) { if (newSelection != null) {
newSelections.add(newSelection); newSelections.add(newSelection);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment