Commit 7bc5fa85 by tonihei Committed by Oliver Woodman

Don't keep pending preferred queue size during cancelation.

Before loading a new chunk, the player will call reevaluateBuffer
anyway, so we don't have to do this directly after cancelation.

This simplifies some logic because we can remove the pending queue
size variable.

PiperOrigin-RevId: 314313268
parent ed7db116
...@@ -146,7 +146,6 @@ import org.checkerframework.checker.nullness.qual.RequiresNonNull; ...@@ -146,7 +146,6 @@ import org.checkerframework.checker.nullness.qual.RequiresNonNull;
private @MonotonicNonNull Format upstreamTrackFormat; private @MonotonicNonNull Format upstreamTrackFormat;
@Nullable private Format downstreamTrackFormat; @Nullable private Format downstreamTrackFormat;
private boolean released; private boolean released;
private int pendingDiscardUpstreamQueueSize;
// Tracks are complicated in HLS. See documentation of buildTracksFromSampleStreams for details. // Tracks are complicated in HLS. See documentation of buildTracksFromSampleStreams for details.
// Indexed by track (as exposed by this source). // Indexed by track (as exposed by this source).
...@@ -230,7 +229,6 @@ import org.checkerframework.checker.nullness.qual.RequiresNonNull; ...@@ -230,7 +229,6 @@ import org.checkerframework.checker.nullness.qual.RequiresNonNull;
handler = Util.createHandler(); handler = Util.createHandler();
lastSeekPositionUs = positionUs; lastSeekPositionUs = positionUs;
pendingResetPositionUs = positionUs; pendingResetPositionUs = positionUs;
pendingDiscardUpstreamQueueSize = C.LENGTH_UNSET;
} }
public void continuePreparing() { public void continuePreparing() {
...@@ -708,7 +706,6 @@ import org.checkerframework.checker.nullness.qual.RequiresNonNull; ...@@ -708,7 +706,6 @@ import org.checkerframework.checker.nullness.qual.RequiresNonNull;
return; return;
} }
if (loader.isLoading()) { if (loader.isLoading()) {
pendingDiscardUpstreamQueueSize = preferredQueueSize;
loader.cancelLoading(); loader.cancelLoading();
} else { } else {
discardUpstream(preferredQueueSize); discardUpstream(preferredQueueSize);
...@@ -769,10 +766,7 @@ import org.checkerframework.checker.nullness.qual.RequiresNonNull; ...@@ -769,10 +766,7 @@ import org.checkerframework.checker.nullness.qual.RequiresNonNull;
loadable.startTimeUs, loadable.startTimeUs,
loadable.endTimeUs); loadable.endTimeUs);
if (!released) { if (!released) {
if (pendingDiscardUpstreamQueueSize != C.LENGTH_UNSET) { if (isPendingReset() || enabledTrackGroupCount == 0) {
discardUpstream(pendingDiscardUpstreamQueueSize);
pendingDiscardUpstreamQueueSize = C.LENGTH_UNSET;
} else {
resetSampleQueues(); resetSampleQueues();
} }
if (enabledTrackGroupCount > 0) { if (enabledTrackGroupCount > 0) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment