Remove @NonNull where it's implied by @NonNullApi

Also remove it from all tests, these aren't covered by the null-checker

Covered by the following package-info.java files:
- j/c/g/a/exoplayer2/ext/mediasession/package-info.java
- j/c/g/a/exoplayer2/package-info.java
- j/c/g/a/exoplayer2/offline/package-info.java
- j/c/g/a/exoplayer2/video/package-info.java
- j/c/g/a/exoplayer2/ui/package-info.java

PiperOrigin-RevId: 277038916

extensions/mediasession/src/main/java/com/google/android/exoplayer2/ext/mediasession/MediaSessionConnector.java

@@ -31,7 +31,6 @@ import android.support.v4.media.session.MediaSessionCompat;
 import android.support.v4.media.session.PlaybackStateCompat;
 import android.support.v4.media.session.PlaybackStateCompat;
 import android.util.Pair;
 import android.util.Pair;
 import androidx.annotation.LongDef;
 import androidx.annotation.LongDef;
-import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.annotation.Nullable;
 import com.google.android.exoplayer2.C;
 import com.google.android.exoplayer2.C;
 import com.google.android.exoplayer2.ControlDispatcher;
 import com.google.android.exoplayer2.ControlDispatcher;
@@ -1225,7 +1224,7 @@ public final class MediaSessionConnector {
     }
     }
 
 
     @Override
     @Override
-    public void onCustomAction(@NonNull String action, @Nullable Bundle extras) {
+    public void onCustomAction(String action, @Nullable Bundle extras) {
       if (player != null && customActionMap.containsKey(action)) {
       if (player != null && customActionMap.containsKey(action)) {
         customActionMap.get(action).onCustomAction(player, controlDispatcher, action, extras);
         customActionMap.get(action).onCustomAction(player, controlDispatcher, action, extras);
         invalidateMediaSessionPlaybackState();
         invalidateMediaSessionPlaybackState();

extensions/mediasession/src/main/java/com/google/android/exoplayer2/ext/mediasession/TimelineQueueEditor.java

@@ -20,7 +20,6 @@ import android.os.ResultReceiver;
 import android.support.v4.media.MediaDescriptionCompat;
 import android.support.v4.media.MediaDescriptionCompat;
 import android.support.v4.media.session.MediaControllerCompat;
 import android.support.v4.media.session.MediaControllerCompat;
 import android.support.v4.media.session.MediaSessionCompat;
 import android.support.v4.media.session.MediaSessionCompat;
-import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.annotation.Nullable;
 import com.google.android.exoplayer2.C;
 import com.google.android.exoplayer2.C;
 import com.google.android.exoplayer2.ControlDispatcher;
 import com.google.android.exoplayer2.ControlDispatcher;
@@ -129,10 +128,10 @@ public final class TimelineQueueEditor
    * @param sourceFactory The {@link MediaSourceFactory} to build media sources.
    * @param sourceFactory The {@link MediaSourceFactory} to build media sources.
    */
    */
   public TimelineQueueEditor(
   public TimelineQueueEditor(
-      @NonNull MediaControllerCompat mediaController,
-      @NonNull ConcatenatingMediaSource queueMediaSource,
-      @NonNull QueueDataAdapter queueDataAdapter,
-      @NonNull MediaSourceFactory sourceFactory) {
+      MediaControllerCompat mediaController,
+      ConcatenatingMediaSource queueMediaSource,
+      QueueDataAdapter queueDataAdapter,
+      MediaSourceFactory sourceFactory) {
     this(mediaController, queueMediaSource, queueDataAdapter, sourceFactory,
     this(mediaController, queueMediaSource, queueDataAdapter, sourceFactory,
         new MediaIdEqualityChecker());
         new MediaIdEqualityChecker());
   }
   }
@@ -147,11 +146,11 @@ public final class TimelineQueueEditor
    * @param equalityChecker The {@link MediaDescriptionEqualityChecker} to match queue items.
    * @param equalityChecker The {@link MediaDescriptionEqualityChecker} to match queue items.
    */
    */
   public TimelineQueueEditor(
   public TimelineQueueEditor(
-      @NonNull MediaControllerCompat mediaController,
-      @NonNull ConcatenatingMediaSource queueMediaSource,
-      @NonNull QueueDataAdapter queueDataAdapter,
-      @NonNull MediaSourceFactory sourceFactory,
-      @NonNull MediaDescriptionEqualityChecker equalityChecker) {
+      MediaControllerCompat mediaController,
+      ConcatenatingMediaSource queueMediaSource,
+      QueueDataAdapter queueDataAdapter,
+      MediaSourceFactory sourceFactory,
+      MediaDescriptionEqualityChecker equalityChecker) {
     this.mediaController = mediaController;
     this.mediaController = mediaController;
     this.queueMediaSource = queueMediaSource;
     this.queueMediaSource = queueMediaSource;
     this.queueDataAdapter = queueDataAdapter;
     this.queueDataAdapter = queueDataAdapter;

library/core/src/androidTest/java/com/google/android/exoplayer2/upstream/ContentDataSourceTest.java

@@ -26,7 +26,6 @@ import android.database.Cursor;
 import android.net.Uri;
 import android.net.Uri;
 import android.os.Bundle;
 import android.os.Bundle;
 import android.os.ParcelFileDescriptor;
 import android.os.ParcelFileDescriptor;
-import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.annotation.Nullable;
 import androidx.test.InstrumentationRegistry;
 import androidx.test.InstrumentationRegistry;
 import androidx.test.ext.junit.runners.AndroidJUnit4;
 import androidx.test.ext.junit.runners.AndroidJUnit4;
@@ -134,14 +133,13 @@ public final class ContentDataSourceTest {
     }
     }
 
 
     @Override
     @Override
-    public Cursor query(@NonNull Uri uri, String[] projection, String selection,
-        String[] selectionArgs, String sortOrder) {
+    public Cursor query(
+        Uri uri, String[] projection, String selection, String[] selectionArgs, String sortOrder) {
       throw new UnsupportedOperationException();
       throw new UnsupportedOperationException();
     }
     }
 
 
     @Override
     @Override
-    public AssetFileDescriptor openAssetFile(@NonNull Uri uri, @NonNull String mode)
-        throws FileNotFoundException {
+    public AssetFileDescriptor openAssetFile(Uri uri, String mode) throws FileNotFoundException {
       if (uri.getPath() == null) {
       if (uri.getPath() == null) {
         return null;
         return null;
       }
       }
@@ -162,29 +160,32 @@ public final class ContentDataSourceTest {
     }
     }
 
 
     @Override
     @Override
-    public String getType(@NonNull Uri uri) {
+    public String getType(Uri uri) {
       throw new UnsupportedOperationException();
       throw new UnsupportedOperationException();
     }
     }
 
 
     @Override
     @Override
-    public Uri insert(@NonNull Uri uri, ContentValues values) {
+    public Uri insert(Uri uri, ContentValues values) {
       throw new UnsupportedOperationException();
       throw new UnsupportedOperationException();
     }
     }
 
 
     @Override
     @Override
-    public int delete(@NonNull Uri uri, String selection, String[] selectionArgs) {
+    public int delete(Uri uri, String selection, String[] selectionArgs) {
       throw new UnsupportedOperationException();
       throw new UnsupportedOperationException();
     }
     }
 
 
     @Override
     @Override
-    public int update(@NonNull Uri uri, ContentValues values, String selection,
-        String[] selectionArgs) {
+    public int update(Uri uri, ContentValues values, String selection, String[] selectionArgs) {
       throw new UnsupportedOperationException();
       throw new UnsupportedOperationException();
     }
     }
 
 
     @Override
     @Override
-    public void writeDataToPipe(@NonNull ParcelFileDescriptor output, @NonNull Uri uri,
-        @NonNull String mimeType, @Nullable Bundle opts, @Nullable Object args) {
+    public void writeDataToPipe(
+        ParcelFileDescriptor output,
+        Uri uri,
+        String mimeType,
+        @Nullable Bundle opts,
+        @Nullable Object args) {
       try {
       try {
         byte[] data = TestUtil.getByteArray(getContext(), getFileName(uri));
         byte[] data = TestUtil.getByteArray(getContext(), getFileName(uri));
         FileOutputStream outputStream = new FileOutputStream(output.getFileDescriptor());
         FileOutputStream outputStream = new FileOutputStream(output.getFileDescriptor());

library/core/src/main/java/com/google/android/exoplayer2/ExoPlayerImplInternal.java

@@ -22,7 +22,6 @@ import android.os.Message;
 import android.os.Process;
 import android.os.Process;
 import android.os.SystemClock;
 import android.os.SystemClock;
 import android.util.Pair;
 import android.util.Pair;
-import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.annotation.Nullable;
 import com.google.android.exoplayer2.DefaultMediaClock.PlaybackParameterListener;
 import com.google.android.exoplayer2.DefaultMediaClock.PlaybackParameterListener;
 import com.google.android.exoplayer2.Player.DiscontinuityReason;
 import com.google.android.exoplayer2.Player.DiscontinuityReason;
@@ -1964,7 +1963,7 @@ import java.util.concurrent.atomic.AtomicBoolean;
     }
     }
 
 
     @Override
     @Override
-    public int compareTo(@NonNull PendingMessageInfo other) {
+    public int compareTo(PendingMessageInfo other) {
       if ((resolvedPeriodUid == null) != (other.resolvedPeriodUid == null)) {
       if ((resolvedPeriodUid == null) != (other.resolvedPeriodUid == null)) {
         // PendingMessageInfos with a resolved period position are always smaller.
         // PendingMessageInfos with a resolved period position are always smaller.
         return resolvedPeriodUid != null ? -1 : 1;
         return resolvedPeriodUid != null ? -1 : 1;

library/core/src/main/java/com/google/android/exoplayer2/offline/SegmentDownloader.java

@@ -17,7 +17,6 @@ package com.google.android.exoplayer2.offline;
 
 
 import android.net.Uri;
 import android.net.Uri;
 import android.util.Pair;
 import android.util.Pair;
-import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.annotation.Nullable;
 import com.google.android.exoplayer2.C;
 import com.google.android.exoplayer2.C;
 import com.google.android.exoplayer2.upstream.DataSource;
 import com.google.android.exoplayer2.upstream.DataSource;
@@ -57,7 +56,7 @@ public abstract class SegmentDownloader<M extends FilterableManifest<M>> impleme
     }
     }
 
 
     @Override
     @Override
-    public int compareTo(@NonNull Segment other) {
+    public int compareTo(Segment other) {
       return Util.compareLong(startTimeUs, other.startTimeUs);
       return Util.compareLong(startTimeUs, other.startTimeUs);
     }
     }
   }
   }

library/core/src/main/java/com/google/android/exoplayer2/offline/StreamKey.java

@@ -17,7 +17,6 @@ package com.google.android.exoplayer2.offline;
 
 
 import android.os.Parcel;
 import android.os.Parcel;
 import android.os.Parcelable;
 import android.os.Parcelable;
-import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.annotation.Nullable;
 
 
 /**
 /**
@@ -92,7 +91,7 @@ public final class StreamKey implements Comparable<StreamKey>, Parcelable {
   // Comparable implementation.
   // Comparable implementation.
 
 
   @Override
   @Override
-  public int compareTo(@NonNull StreamKey o) {
+  public int compareTo(StreamKey o) {
     int result = periodIndex - o.periodIndex;
     int result = periodIndex - o.periodIndex;
     if (result == 0) {
     if (result == 0) {
       result = groupIndex - o.groupIndex;
       result = groupIndex - o.groupIndex;

library/core/src/main/java/com/google/android/exoplayer2/video/MediaCodecVideoRenderer.java

@@ -30,7 +30,6 @@ import android.os.SystemClock;
 import android.util.Pair;
 import android.util.Pair;
 import android.view.Surface;
 import android.view.Surface;
 import androidx.annotation.CallSuper;
 import androidx.annotation.CallSuper;
-import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.annotation.Nullable;
 import com.google.android.exoplayer2.C;
 import com.google.android.exoplayer2.C;
 import com.google.android.exoplayer2.ExoPlaybackException;
 import com.google.android.exoplayer2.ExoPlaybackException;
@@ -1746,7 +1745,7 @@ public class MediaCodecVideoRenderer extends MediaCodecRenderer {
     }
     }
 
 
     @Override
     @Override
-    public void onFrameRendered(@NonNull MediaCodec codec, long presentationTimeUs, long nanoTime) {
+    public void onFrameRendered(MediaCodec codec, long presentationTimeUs, long nanoTime) {
       if (this != tunnelingOnFrameRenderedListener) {
       if (this != tunnelingOnFrameRenderedListener) {
         // Stale event.
         // Stale event.
         return;
         return;

library/core/src/test/java/com/google/android/exoplayer2/extractor/amr/AmrExtractorTest.java

@@ -22,7 +22,6 @@ import static com.google.android.exoplayer2.extractor.amr.AmrExtractor.frameSize
 import static com.google.common.truth.Truth.assertThat;
 import static com.google.common.truth.Truth.assertThat;
 import static junit.framework.Assert.fail;
 import static junit.framework.Assert.fail;
 
 
-import androidx.annotation.NonNull;
 import androidx.test.ext.junit.runners.AndroidJUnit4;
 import androidx.test.ext.junit.runners.AndroidJUnit4;
 import com.google.android.exoplayer2.ParserException;
 import com.google.android.exoplayer2.ParserException;
 import com.google.android.exoplayer2.extractor.Extractor;
 import com.google.android.exoplayer2.extractor.Extractor;
@@ -235,7 +234,6 @@ public final class AmrExtractorTest {
     return result;
     return result;
   }
   }
 
 
-  @NonNull
   private static AmrExtractor setupAmrExtractorWithOutput() {
   private static AmrExtractor setupAmrExtractorWithOutput() {
     AmrExtractor amrExtractor = new AmrExtractor();
     AmrExtractor amrExtractor = new AmrExtractor();
     FakeExtractorOutput output = new FakeExtractorOutput();
     FakeExtractorOutput output = new FakeExtractorOutput();
@@ -243,12 +241,10 @@ public final class AmrExtractorTest {
     return amrExtractor;
     return amrExtractor;
   }
   }
 
 
-  @NonNull
   private static FakeExtractorInput fakeExtractorInputWithData(byte[] data) {
   private static FakeExtractorInput fakeExtractorInputWithData(byte[] data) {
     return new FakeExtractorInput.Builder().setData(data).build();
     return new FakeExtractorInput.Builder().setData(data).build();
   }
   }
 
 
-  @NonNull
   private static ExtractorAsserts.ExtractorFactory createAmrExtractorFactory(boolean withSeeking) {
   private static ExtractorAsserts.ExtractorFactory createAmrExtractorFactory(boolean withSeeking) {
     return () -> {
     return () -> {
       if (!withSeeking) {
       if (!withSeeking) {

library/ui/src/main/java/com/google/android/exoplayer2/ui/SimpleExoPlayerView.java

@@ -17,7 +17,6 @@ package com.google.android.exoplayer2.ui;
 
 
 import android.content.Context;
 import android.content.Context;
 import android.util.AttributeSet;
 import android.util.AttributeSet;
-import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.annotation.Nullable;
 import com.google.android.exoplayer2.Player;
 import com.google.android.exoplayer2.Player;
 import com.google.android.exoplayer2.SimpleExoPlayer;
 import com.google.android.exoplayer2.SimpleExoPlayer;
@@ -49,7 +48,7 @@ public final class SimpleExoPlayerView extends PlayerView {
   @Deprecated
   @Deprecated
   @SuppressWarnings("deprecation")
   @SuppressWarnings("deprecation")
   public static void switchTargetView(
   public static void switchTargetView(
-      @NonNull SimpleExoPlayer player,
+      SimpleExoPlayer player,
       @Nullable SimpleExoPlayerView oldPlayerView,
       @Nullable SimpleExoPlayerView oldPlayerView,
       @Nullable SimpleExoPlayerView newPlayerView) {
       @Nullable SimpleExoPlayerView newPlayerView) {
     PlayerView.switchTargetView(player, oldPlayerView, newPlayerView);
     PlayerView.switchTargetView(player, oldPlayerView, newPlayerView);