Render PQ to DebugSurface in transformer.

For HLG input in transformer, FinalWrapper is configured to only output HLG to
encoder. But since DebugPreview is configured to take PQ for HDR content, the
color will not look correct.

This CL allows overriding the MatrixTP output transfer function, so
that FinalWrapper can output

- HLG to encoder
- PQ to debug preview

PiperOrigin-RevId: 506022840

library/effect/src/main/java/com/google/android/exoplayer2/effect/FinalMatrixTextureProcessorWrapper.java

@@ -15,6 +15,7 @@
  */
  */
 package com.google.android.exoplayer2.effect;
 package com.google.android.exoplayer2.effect;
 
 
+import static com.google.android.exoplayer2.util.Assertions.checkNotNull;
 import static com.google.android.exoplayer2.util.Assertions.checkState;
 import static com.google.android.exoplayer2.util.Assertions.checkState;
 import static com.google.android.exoplayer2.util.Assertions.checkStateNotNull;
 import static com.google.android.exoplayer2.util.Assertions.checkStateNotNull;
 
 
@@ -422,7 +423,12 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
       debugSurfaceViewWrapper.maybeRenderToSurfaceView(
       debugSurfaceViewWrapper.maybeRenderToSurfaceView(
           () -> {
           () -> {
             GlUtil.clearOutputFrame();
             GlUtil.clearOutputFrame();
+            @C.ColorTransfer
+            int configuredColorTransfer = matrixTextureProcessor.getOutputColorTransfer();
+            matrixTextureProcessor.setOutputColorTransfer(
+                checkNotNull(debugSurfaceViewWrapper).outputColorTransfer);
             matrixTextureProcessor.drawFrame(inputTexture.texId, presentationTimeUs);
             matrixTextureProcessor.drawFrame(inputTexture.texId, presentationTimeUs);
+            matrixTextureProcessor.setOutputColorTransfer(configuredColorTransfer);
           });
           });
     } catch (FrameProcessingException | GlUtil.GlException e) {
     } catch (FrameProcessingException | GlUtil.GlException e) {
       Log.d(TAG, "Error rendering to debug preview", e);
       Log.d(TAG, "Error rendering to debug preview", e);
@@ -434,9 +440,9 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
    * and makes rendering a no-op if not.
    * and makes rendering a no-op if not.
    */
    */
   private static final class SurfaceViewWrapper implements SurfaceHolder.Callback {
   private static final class SurfaceViewWrapper implements SurfaceHolder.Callback {
+    public final @C.ColorTransfer int outputColorTransfer;
     private final EGLDisplay eglDisplay;
     private final EGLDisplay eglDisplay;
     private final EGLContext eglContext;
     private final EGLContext eglContext;
-    private final boolean useHdr;
 
 
     @GuardedBy("this")
     @GuardedBy("this")
     @Nullable
     @Nullable
@@ -453,7 +459,8 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
         EGLDisplay eglDisplay, EGLContext eglContext, boolean useHdr, SurfaceView surfaceView) {
         EGLDisplay eglDisplay, EGLContext eglContext, boolean useHdr, SurfaceView surfaceView) {
       this.eglDisplay = eglDisplay;
       this.eglDisplay = eglDisplay;
       this.eglContext = eglContext;
       this.eglContext = eglContext;
-      this.useHdr = useHdr;
+      // Screen output supports only BT.2020 PQ (ST2084) for HDR.
+      this.outputColorTransfer = useHdr ? C.COLOR_TRANSFER_ST2084 : C.COLOR_TRANSFER_SDR;
       surfaceView.getHolder().addCallback(this);
       surfaceView.getHolder().addCallback(this);
       surface = surfaceView.getHolder().getSurface();
       surface = surfaceView.getHolder().getSurface();
       width = surfaceView.getWidth();
       width = surfaceView.getWidth();
@@ -473,13 +480,9 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
       }
       }
 
 
       if (eglSurface == null) {
       if (eglSurface == null) {
-        // Screen output supports only BT.2020 PQ (ST2084).
         eglSurface =
         eglSurface =
             GlUtil.createEglSurface(
             GlUtil.createEglSurface(
-                eglDisplay,
-                surface,
-                useHdr ? C.COLOR_TRANSFER_ST2084 : C.COLOR_TRANSFER_SDR,
-                /* isEncoderInputSurface= */ false);
+                eglDisplay, surface, outputColorTransfer, /* isEncoderInputSurface= */ false);
       }
       }
       EGLSurface eglSurface = this.eglSurface;
       EGLSurface eglSurface = this.eglSurface;
       GlUtil.focusEglSurface(eglDisplay, eglContext, eglSurface, width, height);
       GlUtil.focusEglSurface(eglDisplay, eglContext, eglSurface, width, height);

library/effect/src/main/java/com/google/android/exoplayer2/effect/MatrixTextureProcessor.java

@@ -125,6 +125,7 @@ import java.util.List;
   private ImmutableList<float[]> visiblePolygon;
   private ImmutableList<float[]> visiblePolygon;
 
 
   private final GlProgram glProgram;
   private final GlProgram glProgram;
+  private @C.ColorTransfer int outputColorTransfer;
 
 
   /**
   /**
    * Creates a new instance.
    * Creates a new instance.
@@ -156,6 +157,7 @@ import java.util.List;
         glProgram,
         glProgram,
         ImmutableList.copyOf(matrixTransformations),
         ImmutableList.copyOf(matrixTransformations),
         ImmutableList.copyOf(rgbMatrices),
         ImmutableList.copyOf(rgbMatrices),
+        /* outputColorTransfer= */ C.COLOR_TRANSFER_LINEAR,
         useHdr);
         useHdr);
   }
   }
 
 
@@ -242,6 +244,7 @@ import java.util.List;
         glProgram,
         glProgram,
         ImmutableList.copyOf(matrixTransformations),
         ImmutableList.copyOf(matrixTransformations),
         ImmutableList.copyOf(rgbMatrices),
         ImmutableList.copyOf(rgbMatrices),
+        outputColorInfo.colorTransfer,
         isInputTransferHdr);
         isInputTransferHdr);
   }
   }
 
 
@@ -296,6 +299,7 @@ import java.util.List;
         glProgram,
         glProgram,
         ImmutableList.copyOf(matrixTransformations),
         ImmutableList.copyOf(matrixTransformations),
         ImmutableList.copyOf(rgbMatrices),
         ImmutableList.copyOf(rgbMatrices),
+        outputColorInfo.colorTransfer,
         outputIsHdr);
         outputIsHdr);
   }
   }
 
 
@@ -307,6 +311,7 @@ import java.util.List;
    *     apply to each frame in order. Can be empty to apply no vertex transformations.
    *     apply to each frame in order. Can be empty to apply no vertex transformations.
    * @param rgbMatrices The {@link RgbMatrix RgbMatrices} to apply to each frame in order. Can be
    * @param rgbMatrices The {@link RgbMatrix RgbMatrices} to apply to each frame in order. Can be
    *     empty to apply no color transformations.
    *     empty to apply no color transformations.
+   * @param outputColorTransfer The output {@link C.ColorTransfer}.
    * @param useHdr Whether to process the input as an HDR signal. Using HDR requires the {@code
    * @param useHdr Whether to process the input as an HDR signal. Using HDR requires the {@code
    *     EXT_YUV_target} OpenGL extension.
    *     EXT_YUV_target} OpenGL extension.
    */
    */
@@ -314,9 +319,11 @@ import java.util.List;
       GlProgram glProgram,
       GlProgram glProgram,
       ImmutableList<GlMatrixTransformation> matrixTransformations,
       ImmutableList<GlMatrixTransformation> matrixTransformations,
       ImmutableList<RgbMatrix> rgbMatrices,
       ImmutableList<RgbMatrix> rgbMatrices,
+      int outputColorTransfer,
       boolean useHdr) {
       boolean useHdr) {
     super(useHdr);
     super(useHdr);
     this.glProgram = glProgram;
     this.glProgram = glProgram;
+    this.outputColorTransfer = outputColorTransfer;
     this.matrixTransformations = matrixTransformations;
     this.matrixTransformations = matrixTransformations;
     this.rgbMatrices = rgbMatrices;
     this.rgbMatrices = rgbMatrices;
     this.useHdr = useHdr;
     this.useHdr = useHdr;
@@ -392,6 +399,23 @@ import java.util.List;
   }
   }
 
 
   /**
   /**
+   * Sets the output {@link C.ColorTransfer}.
+   *
+   * <p>This method must not be called on {@code MatrixTextureProcessor} instances that output
+   * {@linkplain C#COLOR_TRANSFER_LINEAR linear colors}.
+   */
+  public void setOutputColorTransfer(@C.ColorTransfer int colorTransfer) {
+    checkState(outputColorTransfer != C.COLOR_TRANSFER_LINEAR);
+    outputColorTransfer = colorTransfer;
+    glProgram.setIntUniform("uOutputColorTransfer", colorTransfer);
+  }
+
+  /** Returns the output {@link C.ColorTransfer}. */
+  public @C.ColorTransfer int getOutputColorTransfer() {
+    return outputColorTransfer;
+  }
+
+  /**
    * Updates {@link #compositeTransformationMatrixArray} and {@link #visiblePolygon} based on the
    * Updates {@link #compositeTransformationMatrixArray} and {@link #visiblePolygon} based on the
    * given frame timestamp.
    * given frame timestamp.
    */
    */