Commit 561998ab by claincly Committed by Ian Baker

Re-assign TODOs

PiperOrigin-RevId: 493281221
parent c006575d
...@@ -334,8 +334,8 @@ import org.checkerframework.dataflow.qual.Pure; ...@@ -334,8 +334,8 @@ import org.checkerframework.dataflow.qual.Pure;
@Pure @Pure
private static TransformationRequest createFallbackTransformationRequest( private static TransformationRequest createFallbackTransformationRequest(
TransformationRequest transformationRequest, Format requestedFormat, Format actualFormat) { TransformationRequest transformationRequest, Format requestedFormat, Format actualFormat) {
// TODO(b/210591626): Also update bitrate and other params once encoder configuration and // TODO(b/259570024): Consider including bitrate and other audio characteristics in the revised
// fallback are implemented. // fallback design.
if (Util.areEqual(requestedFormat.sampleMimeType, actualFormat.sampleMimeType)) { if (Util.areEqual(requestedFormat.sampleMimeType, actualFormat.sampleMimeType)) {
return transformationRequest; return transformationRequest;
} }
......
...@@ -173,7 +173,6 @@ public final class DefaultEncoderFactory implements Codec.EncoderFactory { ...@@ -173,7 +173,6 @@ public final class DefaultEncoderFactory implements Codec.EncoderFactory {
@Override @Override
public DefaultCodec createForAudioEncoding(Format format) throws TransformationException { public DefaultCodec createForAudioEncoding(Format format) throws TransformationException {
// TODO(b/210591626) Add encoder selection for audio.
checkNotNull(format.sampleMimeType); checkNotNull(format.sampleMimeType);
MediaFormat mediaFormat = MediaFormat mediaFormat =
MediaFormat.createAudioFormat( MediaFormat.createAudioFormat(
......
...@@ -325,8 +325,7 @@ import org.checkerframework.dataflow.qual.Pure; ...@@ -325,8 +325,7 @@ import org.checkerframework.dataflow.qual.Pure;
Format requestedFormat, Format requestedFormat,
Format supportedFormat, Format supportedFormat,
@TransformationRequest.HdrMode int supportedHdrMode) { @TransformationRequest.HdrMode int supportedHdrMode) {
// TODO(b/210591626): Also update bitrate etc. once encoder configuration and fallback are // TODO(b/259570024): Consider including bitrate in the revised fallback design.
// implemented.
if (transformationRequest.hdrMode == supportedHdrMode if (transformationRequest.hdrMode == supportedHdrMode
&& Util.areEqual(requestedFormat.sampleMimeType, supportedFormat.sampleMimeType) && Util.areEqual(requestedFormat.sampleMimeType, supportedFormat.sampleMimeType)
&& (hasOutputFormatRotation && (hasOutputFormatRotation
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment