Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
561998ab
authored
Dec 06, 2022
by
claincly
Committed by
Ian Baker
Dec 12, 2022
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Re-assign TODOs
PiperOrigin-RevId: 493281221
parent
c006575d
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
5 deletions
library/transformer/src/main/java/com/google/android/exoplayer2/transformer/AudioTranscodingSamplePipeline.java
library/transformer/src/main/java/com/google/android/exoplayer2/transformer/DefaultEncoderFactory.java
library/transformer/src/main/java/com/google/android/exoplayer2/transformer/VideoTranscodingSamplePipeline.java
library/transformer/src/main/java/com/google/android/exoplayer2/transformer/AudioTranscodingSamplePipeline.java
View file @
561998ab
...
...
@@ -334,8 +334,8 @@ import org.checkerframework.dataflow.qual.Pure;
@Pure
private
static
TransformationRequest
createFallbackTransformationRequest
(
TransformationRequest
transformationRequest
,
Format
requestedFormat
,
Format
actualFormat
)
{
// TODO(b/2
10591626): Also update bitrate and other params once encoder configuration an
d
//
fallback are implemented
.
// TODO(b/2
59570024): Consider including bitrate and other audio characteristics in the revise
d
//
fallback design
.
if
(
Util
.
areEqual
(
requestedFormat
.
sampleMimeType
,
actualFormat
.
sampleMimeType
))
{
return
transformationRequest
;
}
...
...
library/transformer/src/main/java/com/google/android/exoplayer2/transformer/DefaultEncoderFactory.java
View file @
561998ab
...
...
@@ -173,7 +173,6 @@ public final class DefaultEncoderFactory implements Codec.EncoderFactory {
@Override
public
DefaultCodec
createForAudioEncoding
(
Format
format
)
throws
TransformationException
{
// TODO(b/210591626) Add encoder selection for audio.
checkNotNull
(
format
.
sampleMimeType
);
MediaFormat
mediaFormat
=
MediaFormat
.
createAudioFormat
(
...
...
library/transformer/src/main/java/com/google/android/exoplayer2/transformer/VideoTranscodingSamplePipeline.java
View file @
561998ab
...
...
@@ -325,8 +325,7 @@ import org.checkerframework.dataflow.qual.Pure;
Format
requestedFormat
,
Format
supportedFormat
,
@TransformationRequest
.
HdrMode
int
supportedHdrMode
)
{
// TODO(b/210591626): Also update bitrate etc. once encoder configuration and fallback are
// implemented.
// TODO(b/259570024): Consider including bitrate in the revised fallback design.
if
(
transformationRequest
.
hdrMode
==
supportedHdrMode
&&
Util
.
areEqual
(
requestedFormat
.
sampleMimeType
,
supportedFormat
.
sampleMimeType
)
&&
(
hasOutputFormatRotation
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment