Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
50f5e345
authored
Feb 23, 2023
by
kimvde
Committed by
Andrew Lewis
Feb 24, 2023
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Improve shouldTranscode() logic
PiperOrigin-RevId: 511767953
parent
c5c171be
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
5 deletions
library/transformer/src/main/java/com/google/android/exoplayer2/transformer/TransformerInternal.java
library/transformer/src/main/java/com/google/android/exoplayer2/transformer/TransformerInternal.java
View file @
50f5e345
...
...
@@ -485,12 +485,9 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
if
(!
assetLoaderCanOutputEncoded
)
{
shouldTranscode
=
true
;
}
else
if
(
MimeTypes
.
isAudio
(
inputFormat
.
sampleMimeType
))
{
shouldTranscode
=
(
mediaItemCount
>
1
&&
!
transmuxAudio
)
||
shouldTranscodeAudio
(
inputFormat
);
shouldTranscode
=
shouldTranscodeAudio
(
inputFormat
);
}
else
if
(
MimeTypes
.
isVideo
(
inputFormat
.
sampleMimeType
))
{
shouldTranscode
=
(
mediaItemCount
>
1
&&
!
transmuxVideo
)
||
shouldTranscodeVideo
(
inputFormat
,
streamStartPositionUs
,
streamOffsetUs
);
shouldTranscode
=
shouldTranscodeVideo
(
inputFormat
,
streamStartPositionUs
,
streamOffsetUs
);
}
checkState
(!
shouldTranscode
||
assetLoaderCanOutputDecoded
);
...
...
@@ -499,6 +496,9 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
}
private
boolean
shouldTranscodeAudio
(
Format
inputFormat
)
{
if
(
mediaItemCount
>
1
&&
!
transmuxAudio
)
{
return
true
;
}
if
(
encoderFactory
.
audioNeedsEncoding
())
{
return
true
;
}
...
...
@@ -535,6 +535,9 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
private
boolean
shouldTranscodeVideo
(
Format
inputFormat
,
long
streamStartPositionUs
,
long
streamOffsetUs
)
{
if
(
mediaItemCount
>
1
&&
!
transmuxVideo
)
{
return
true
;
}
if
((
streamStartPositionUs
-
streamOffsetUs
)
!=
0
&&
!
firstEditedMediaItem
.
mediaItem
.
clippingConfiguration
.
startsAtKeyFrame
)
{
return
true
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment