Commit 4a38b2ca by olly Committed by Oliver Woodman

Fully reset state when displaying track selections.

When showing a track selection for a renderer, the override
variable could end up being retained from some previous call
to show a track selection for some other renderer.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=117557994
parent 03ed811c
...@@ -46,18 +46,17 @@ public class TrackSelectionHelper implements View.OnClickListener, DialogInterfa ...@@ -46,18 +46,17 @@ public class TrackSelectionHelper implements View.OnClickListener, DialogInterfa
private final DefaultTrackSelector selector; private final DefaultTrackSelector selector;
private CheckedTextView disableView;
private CheckedTextView defaultView;
private CheckedTextView[][] trackViews;
private TrackInfo trackInfo; private TrackInfo trackInfo;
private int rendererIndex; private int rendererIndex;
private TrackGroupArray trackGroups; private TrackGroupArray trackGroups;
private boolean[] trackGroupsAdaptive; private boolean[] trackGroupsAdaptive;
private boolean isDisabled; private boolean isDisabled;
private TrackSelection override; private TrackSelection override;
private CheckedTextView disableView;
private CheckedTextView defaultView;
private CheckedTextView[][] trackViews;
/** /**
* @param selector The track selector. * @param selector The track selector.
*/ */
...@@ -85,9 +84,8 @@ public class TrackSelectionHelper implements View.OnClickListener, DialogInterfa ...@@ -85,9 +84,8 @@ public class TrackSelectionHelper implements View.OnClickListener, DialogInterfa
!= TrackRenderer.ADAPTIVE_NOT_SUPPORTED; != TrackRenderer.ADAPTIVE_NOT_SUPPORTED;
} }
isDisabled = selector.getRendererDisabled(rendererIndex); isDisabled = selector.getRendererDisabled(rendererIndex);
if (selector.hasSelectionOverride(rendererIndex, trackGroups)) { override = selector.hasSelectionOverride(rendererIndex, trackGroups)
override = trackInfo.getTrackSelection(rendererIndex); ? trackInfo.getTrackSelection(rendererIndex) : null;
}
AlertDialog.Builder builder = new AlertDialog.Builder(activity); AlertDialog.Builder builder = new AlertDialog.Builder(activity);
builder.setTitle(titleId) builder.setTitle(titleId)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment