Commit 3e9a45b9 by olly Committed by Oliver Woodman

Fix DownloadManagerDashTest tests

Also re-enable two of them, although note that the fix here is
not related to the flakiness that caused them to be disabled.
I'm re-enabling them since much has changed in DownloadManager,
and the hope is that these tests are no longer flaky.

PiperOrigin-RevId: 244826225
parent 9725132e
...@@ -32,6 +32,7 @@ import com.google.android.exoplayer2.offline.DownloadManager; ...@@ -32,6 +32,7 @@ import com.google.android.exoplayer2.offline.DownloadManager;
import com.google.android.exoplayer2.offline.DownloadRequest; import com.google.android.exoplayer2.offline.DownloadRequest;
import com.google.android.exoplayer2.offline.DownloaderConstructorHelper; import com.google.android.exoplayer2.offline.DownloaderConstructorHelper;
import com.google.android.exoplayer2.offline.StreamKey; import com.google.android.exoplayer2.offline.StreamKey;
import com.google.android.exoplayer2.scheduler.Requirements;
import com.google.android.exoplayer2.testutil.DummyMainThread; import com.google.android.exoplayer2.testutil.DummyMainThread;
import com.google.android.exoplayer2.testutil.DummyMainThread.TestRunnable; import com.google.android.exoplayer2.testutil.DummyMainThread.TestRunnable;
import com.google.android.exoplayer2.testutil.FakeDataSet; import com.google.android.exoplayer2.testutil.FakeDataSet;
...@@ -190,8 +191,6 @@ public class DownloadManagerDashTest { ...@@ -190,8 +191,6 @@ public class DownloadManagerDashTest {
assertCacheEmpty(cache); assertCacheEmpty(cache);
} }
// Disabled due to flakiness.
@Ignore
@Test @Test
public void testHandleRemoveActionBeforeDownloadFinish() throws Throwable { public void testHandleRemoveActionBeforeDownloadFinish() throws Throwable {
handleDownloadRequest(fakeStreamKey1); handleDownloadRequest(fakeStreamKey1);
...@@ -202,8 +201,6 @@ public class DownloadManagerDashTest { ...@@ -202,8 +201,6 @@ public class DownloadManagerDashTest {
assertCacheEmpty(cache); assertCacheEmpty(cache);
} }
// Disabled due to flakiness [Internal: b/122290449].
@Ignore
@Test @Test
public void testHandleInterferingRemoveAction() throws Throwable { public void testHandleInterferingRemoveAction() throws Throwable {
final ConditionVariable downloadInProgressCondition = new ConditionVariable(); final ConditionVariable downloadInProgressCondition = new ConditionVariable();
...@@ -259,6 +256,7 @@ public class DownloadManagerDashTest { ...@@ -259,6 +256,7 @@ public class DownloadManagerDashTest {
downloadIndex, downloadIndex,
new DefaultDownloaderFactory( new DefaultDownloaderFactory(
new DownloaderConstructorHelper(cache, fakeDataSourceFactory))); new DownloaderConstructorHelper(cache, fakeDataSourceFactory)));
downloadManager.setRequirements(new Requirements(0));
downloadManagerListener = downloadManagerListener =
new TestDownloadManagerListener( new TestDownloadManagerListener(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment