Commit 3bd662eb by ibaker Committed by kim-vde

Don't propagate attrs into child SubtitleOutput from SubtitleView

#minor-release

PiperOrigin-RevId: 382763308
parent 5e4056eb
...@@ -69,6 +69,9 @@ ...@@ -69,6 +69,9 @@
* Fix `StyledPlayerView` and `StyledPlayerControlView` popup menu items * Fix `StyledPlayerView` and `StyledPlayerControlView` popup menu items
not expanding to occupy the full width of the popup not expanding to occupy the full width of the popup
([#9086](https://github.com/google/ExoPlayer/issues/9086)). ([#9086](https://github.com/google/ExoPlayer/issues/9086)).
* Don't propagate `AttributeSet` from `SubtitleView` constructor into
`CanvasSubtitleOutput`. Just passing the `Context` is enough, and
ensures programmatic changes to the `SubtitleView` will propagate down.
* Video: * Video:
* Fix `IncorrectContextUseViolation` strict mode warning on Android 11 * Fix `IncorrectContextUseViolation` strict mode warning on Android 11
([#8246](https://github.com/google/ExoPlayer/pull/8246)). ([#8246](https://github.com/google/ExoPlayer/pull/8246)).
......
...@@ -140,7 +140,7 @@ public final class SubtitleView extends FrameLayout implements TextOutput { ...@@ -140,7 +140,7 @@ public final class SubtitleView extends FrameLayout implements TextOutput {
applyEmbeddedStyles = true; applyEmbeddedStyles = true;
applyEmbeddedFontSizes = true; applyEmbeddedFontSizes = true;
CanvasSubtitleOutput canvasSubtitleOutput = new CanvasSubtitleOutput(context, attrs); CanvasSubtitleOutput canvasSubtitleOutput = new CanvasSubtitleOutput(context);
output = canvasSubtitleOutput; output = canvasSubtitleOutput;
innerSubtitleView = canvasSubtitleOutput; innerSubtitleView = canvasSubtitleOutput;
addView(innerSubtitleView); addView(innerSubtitleView);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment