Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
306b2e6d
authored
Jul 02, 2021
by
ibaker
Committed by
Ian Baker
Jul 16, 2021
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Don't propagate attrs into child SubtitleOutput from SubtitleView
PiperOrigin-RevId: 382763308
parent
34309125
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
1 deletions
RELEASENOTES.md
library/ui/src/main/java/com/google/android/exoplayer2/ui/SubtitleView.java
RELEASENOTES.md
View file @
306b2e6d
...
@@ -52,6 +52,9 @@
...
@@ -52,6 +52,9 @@
*
Fix
`StyledPlayerView`
and
`StyledPlayerControlView`
popup menu items
*
Fix
`StyledPlayerView`
and
`StyledPlayerControlView`
popup menu items
not expanding to occupy the full width of the popup
not expanding to occupy the full width of the popup
(
[
#9086
](
https://github.com/google/ExoPlayer/issues/9086
)
).
(
[
#9086
](
https://github.com/google/ExoPlayer/issues/9086
)
).
*
Don't propagate
`AttributeSet`
from
`SubtitleView`
constructor into
`CanvasSubtitleOutput`
. Just passing the
`Context`
is enough, and
ensures programmatic changes to the
`SubtitleView`
will propagate down.
*
RTSP
*
RTSP
*
Fix session description (SDP) parsing to use a HashMap-like behaviour
*
Fix session description (SDP) parsing to use a HashMap-like behaviour
for duplicated attributes.
for duplicated attributes.
...
...
library/ui/src/main/java/com/google/android/exoplayer2/ui/SubtitleView.java
View file @
306b2e6d
...
@@ -140,7 +140,7 @@ public final class SubtitleView extends FrameLayout implements TextOutput {
...
@@ -140,7 +140,7 @@ public final class SubtitleView extends FrameLayout implements TextOutput {
applyEmbeddedStyles
=
true
;
applyEmbeddedStyles
=
true
;
applyEmbeddedFontSizes
=
true
;
applyEmbeddedFontSizes
=
true
;
CanvasSubtitleOutput
canvasSubtitleOutput
=
new
CanvasSubtitleOutput
(
context
,
attrs
);
CanvasSubtitleOutput
canvasSubtitleOutput
=
new
CanvasSubtitleOutput
(
context
);
output
=
canvasSubtitleOutput
;
output
=
canvasSubtitleOutput
;
innerSubtitleView
=
canvasSubtitleOutput
;
innerSubtitleView
=
canvasSubtitleOutput
;
addView
(
innerSubtitleView
);
addView
(
innerSubtitleView
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment