Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
2d022a21
authored
Nov 02, 2020
by
andrewlewis
Committed by
Ian Baker
Nov 18, 2020
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Fix buildForAdsResponse
PiperOrigin-RevId: 340198099
parent
379cd8a0
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
1 deletions
RELEASENOTES.md
extensions/ima/src/main/java/com/google/android/exoplayer2/ext/ima/ImaAdsLoader.java
RELEASENOTES.md
View file @
2d022a21
...
...
@@ -15,6 +15,7 @@
(
[
#7832
](
https://github.com/google/ExoPlayer/issues/7832
)
).
*
Fix a bug that caused multiple ads in an ad pod to be skipped when one
ad in the ad pod was skipped.
*
Fix passing an ads response to the
`ImaAdsLoader`
builder.
### 2.12.1 (2020-10-23) ###
...
...
extensions/ima/src/main/java/com/google/android/exoplayer2/ext/ima/ImaAdsLoader.java
View file @
2d022a21
...
...
@@ -705,7 +705,9 @@ public final class ImaAdsLoader
if
(
adTagUri
!=
null
)
{
adTagDataSpec
=
new
DataSpec
(
adTagUri
);
}
else
if
(
adsResponse
!=
null
)
{
adTagDataSpec
=
new
DataSpec
(
Util
.
getDataUriForString
(
adsResponse
,
"text/xml"
));
adTagDataSpec
=
new
DataSpec
(
Util
.
getDataUriForString
(
/* mimeType= */
"text/xml"
,
/* data= */
adsResponse
));
}
else
{
throw
new
IllegalStateException
();
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment