Commit 0e1e4ad7 by olly Committed by Ian Baker

Remove MediaCodec.stop() call before MediaCodec.release()

This was verified as a no-op change in a prod experiment.

PiperOrigin-RevId: 285167972
parent e8fa9a55
...@@ -392,7 +392,6 @@ public abstract class MediaCodecRenderer extends BaseRenderer { ...@@ -392,7 +392,6 @@ public abstract class MediaCodecRenderer extends BaseRenderer {
private boolean waitingForKeys; private boolean waitingForKeys;
private boolean waitingForFirstSyncSample; private boolean waitingForFirstSyncSample;
private boolean waitingForFirstSampleInFormat; private boolean waitingForFirstSampleInFormat;
private boolean skipMediaCodecStopOnRelease;
private boolean pendingOutputEndOfStream; private boolean pendingOutputEndOfStream;
private @MediaCodecOperationMode int mediaCodecOperationMode; private @MediaCodecOperationMode int mediaCodecOperationMode;
...@@ -459,22 +458,6 @@ public abstract class MediaCodecRenderer extends BaseRenderer { ...@@ -459,22 +458,6 @@ public abstract class MediaCodecRenderer extends BaseRenderer {
} }
/** /**
* Skip calling {@link MediaCodec#stop()} when the underlying MediaCodec is going to be released.
*
* <p>By default, when the MediaCodecRenderer is releasing the underlying {@link MediaCodec}, it
* first calls {@link MediaCodec#stop()} and then calls {@link MediaCodec#release()}. If this
* feature is enabled, the MediaCodecRenderer will skip the call to {@link MediaCodec#stop()}.
*
* <p>This method is experimental, and will be renamed or removed in a future release. It should
* only be called before the renderer is used.
*
* @param enabled enable or disable the feature.
*/
public void experimental_setSkipMediaCodecStopOnRelease(boolean enabled) {
skipMediaCodecStopOnRelease = enabled;
}
/**
* Set the mode of operation of the underlying {@link MediaCodec}. * Set the mode of operation of the underlying {@link MediaCodec}.
* *
* <p>This method is experimental, and will be renamed or removed in a future release. It should * <p>This method is experimental, and will be renamed or removed in a future release. It should
...@@ -705,13 +688,7 @@ public abstract class MediaCodecRenderer extends BaseRenderer { ...@@ -705,13 +688,7 @@ public abstract class MediaCodecRenderer extends BaseRenderer {
try { try {
if (codec != null) { if (codec != null) {
decoderCounters.decoderReleaseCount++; decoderCounters.decoderReleaseCount++;
try { codec.release();
if (!skipMediaCodecStopOnRelease) {
codec.stop();
}
} finally {
codec.release();
}
} }
} finally { } finally {
codec = null; codec = null;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment