Commit 06230f19 by yschimke Committed by Marc Baechinger

Fix tracing under offload.

Currently doSomeWork is never closed and so tracing is deceiving.

See https://screenshot.googleplex.com/eZDzn5APpBNnhe5

PiperOrigin-RevId: 474755816
parent f55a5146
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
([#10458](https://github.com/google/ExoPlayer/issues/10458)). ([#10458](https://github.com/google/ExoPlayer/issues/10458)).
* Discard back buffer before playback gets stuck due to insufficient * Discard back buffer before playback gets stuck due to insufficient
available memory. available memory.
* Close the Tracing "doSomeWork" block when offload is enabled.
* Downloads: * Downloads:
* Fix potential infinite loop in `ProgressiveDownloader` caused by * Fix potential infinite loop in `ProgressiveDownloader` caused by
simultaneous download and playback with the same `PriorityTaskManager` simultaneous download and playback with the same `PriorityTaskManager`
......
...@@ -1092,7 +1092,6 @@ import java.util.concurrent.atomic.AtomicBoolean; ...@@ -1092,7 +1092,6 @@ import java.util.concurrent.atomic.AtomicBoolean;
if (sleepingForOffload || playbackInfo.playbackState == Player.STATE_ENDED) { if (sleepingForOffload || playbackInfo.playbackState == Player.STATE_ENDED) {
// No need to schedule next work. // No need to schedule next work.
return;
} else if (isPlaying || playbackInfo.playbackState == Player.STATE_BUFFERING) { } else if (isPlaying || playbackInfo.playbackState == Player.STATE_BUFFERING) {
// We are actively playing or waiting for data to be ready. Schedule next work quickly. // We are actively playing or waiting for data to be ready. Schedule next work quickly.
scheduleNextWork(operationStartTimeMs, ACTIVE_INTERVAL_MS); scheduleNextWork(operationStartTimeMs, ACTIVE_INTERVAL_MS);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment