Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
f39dba0c
authored
Sep 28, 2021
by
ibaker
Committed by
bachinger
Sep 29, 2021
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Migrate usages of MediaItem.ClippingProperties to ClippingConfiguration
PiperOrigin-RevId: 399471555
parent
8db6ea46
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
24 additions
and
22 deletions
demos/main/src/main/java/com/google/android/exoplayer2/demo/IntentUtil.java
extensions/media2/src/main/java/com/google/android/exoplayer2/ext/media2/DefaultMediaItemConverter.java
library/core/src/androidTest/java/com/google/android/exoplayer2/ClippedPlaybackTest.java
library/core/src/main/java/com/google/android/exoplayer2/source/DefaultMediaSourceFactory.java
demos/main/src/main/java/com/google/android/exoplayer2/demo/IntentUtil.java
View file @
f39dba0c
...
...
@@ -94,8 +94,8 @@ public class IntentUtil {
intent
.
putExtra
(
TITLE_EXTRA
,
mediaItem
.
mediaMetadata
.
title
);
}
addPlaybackPropertiesToIntent
(
localConfiguration
,
intent
,
/* extrasKeySuffix= */
""
);
addClipping
Properties
ToIntent
(
mediaItem
.
clipping
Properties
,
intent
,
/* extrasKeySuffix= */
""
);
addClipping
Configuration
ToIntent
(
mediaItem
.
clipping
Configuration
,
intent
,
/* extrasKeySuffix= */
""
);
}
else
{
intent
.
setAction
(
ACTION_VIEW_LIST
);
for
(
int
i
=
0
;
i
<
mediaItems
.
size
();
i
++)
{
...
...
@@ -104,8 +104,8 @@ public class IntentUtil {
checkNotNull
(
mediaItem
.
localConfiguration
);
intent
.
putExtra
(
URI_EXTRA
+
(
"_"
+
i
),
localConfiguration
.
uri
.
toString
());
addPlaybackPropertiesToIntent
(
localConfiguration
,
intent
,
/* extrasKeySuffix= */
"_"
+
i
);
addClipping
Properties
ToIntent
(
mediaItem
.
clipping
Properties
,
intent
,
/* extrasKeySuffix= */
"_"
+
i
);
addClipping
Configuration
ToIntent
(
mediaItem
.
clipping
Configuration
,
intent
,
/* extrasKeySuffix= */
"_"
+
i
);
if
(
mediaItem
.
mediaMetadata
.
title
!=
null
)
{
intent
.
putExtra
(
TITLE_EXTRA
+
(
"_"
+
i
),
mediaItem
.
mediaMetadata
.
title
);
}
...
...
@@ -236,15 +236,17 @@ public class IntentUtil {
}
}
private
static
void
addClippingPropertiesToIntent
(
MediaItem
.
ClippingProperties
clippingProperties
,
Intent
intent
,
String
extrasKeySuffix
)
{
if
(
clippingProperties
.
startPositionMs
!=
0
)
{
private
static
void
addClippingConfigurationToIntent
(
MediaItem
.
ClippingConfiguration
clippingConfiguration
,
Intent
intent
,
String
extrasKeySuffix
)
{
if
(
clippingConfiguration
.
startPositionMs
!=
0
)
{
intent
.
putExtra
(
CLIP_START_POSITION_MS_EXTRA
+
extrasKeySuffix
,
clipping
Properties
.
startPositionMs
);
CLIP_START_POSITION_MS_EXTRA
+
extrasKeySuffix
,
clipping
Configuration
.
startPositionMs
);
}
if
(
clipping
Properties
.
endPositionMs
!=
C
.
TIME_END_OF_SOURCE
)
{
if
(
clipping
Configuration
.
endPositionMs
!=
C
.
TIME_END_OF_SOURCE
)
{
intent
.
putExtra
(
CLIP_END_POSITION_MS_EXTRA
+
extrasKeySuffix
,
clipping
Properties
.
endPositionMs
);
CLIP_END_POSITION_MS_EXTRA
+
extrasKeySuffix
,
clipping
Configuration
.
endPositionMs
);
}
}
}
extensions/media2/src/main/java/com/google/android/exoplayer2/ext/media2/DefaultMediaItemConverter.java
View file @
f39dba0c
...
...
@@ -105,8 +105,8 @@ public class DefaultMediaItemConverter implements MediaItemConverter {
}
androidx
.
media2
.
common
.
MediaMetadata
metadata
=
getMetadata
(
exoPlayerMediaItem
);
long
startPositionMs
=
exoPlayerMediaItem
.
clipping
Properties
.
startPositionMs
;
long
endPositionMs
=
exoPlayerMediaItem
.
clipping
Properties
.
endPositionMs
;
long
startPositionMs
=
exoPlayerMediaItem
.
clipping
Configuration
.
startPositionMs
;
long
endPositionMs
=
exoPlayerMediaItem
.
clipping
Configuration
.
endPositionMs
;
if
(
endPositionMs
==
C
.
TIME_END_OF_SOURCE
)
{
endPositionMs
=
androidx
.
media2
.
common
.
MediaItem
.
POSITION_UNKNOWN
;
}
...
...
library/core/src/androidTest/java/com/google/android/exoplayer2/ClippedPlaybackTest.java
View file @
f39dba0c
...
...
@@ -33,8 +33,8 @@ import org.junit.Test;
import
org.junit.runner.RunWith
;
/**
* Instrumentation tests for playback of clipped items using {@link MediaItem#clipping
Properties} or
* {@link ClippingMediaSource} directly.
* Instrumentation tests for playback of clipped items using {@link MediaItem#clipping
Configuration}
*
or
{@link ClippingMediaSource} directly.
*/
@RunWith
(
AndroidJUnit4
.
class
)
public
final
class
ClippedPlaybackTest
{
...
...
library/core/src/main/java/com/google/android/exoplayer2/source/DefaultMediaSourceFactory.java
View file @
f39dba0c
...
...
@@ -419,18 +419,18 @@ public final class DefaultMediaSourceFactory implements MediaSourceFactory {
// internal methods
private
static
MediaSource
maybeClipMediaSource
(
MediaItem
mediaItem
,
MediaSource
mediaSource
)
{
if
(
mediaItem
.
clipping
Properties
.
startPositionMs
==
0
&&
mediaItem
.
clipping
Properties
.
endPositionMs
==
C
.
TIME_END_OF_SOURCE
&&
!
mediaItem
.
clipping
Properties
.
relativeToDefaultPosition
)
{
if
(
mediaItem
.
clipping
Configuration
.
startPositionMs
==
0
&&
mediaItem
.
clipping
Configuration
.
endPositionMs
==
C
.
TIME_END_OF_SOURCE
&&
!
mediaItem
.
clipping
Configuration
.
relativeToDefaultPosition
)
{
return
mediaSource
;
}
return
new
ClippingMediaSource
(
mediaSource
,
C
.
msToUs
(
mediaItem
.
clipping
Properties
.
startPositionMs
),
C
.
msToUs
(
mediaItem
.
clipping
Properties
.
endPositionMs
),
/* enableInitialDiscontinuity= */
!
mediaItem
.
clipping
Properties
.
startsAtKeyFrame
,
/* allowDynamicClippingUpdates= */
mediaItem
.
clipping
Properties
.
relativeToLiveWindow
,
mediaItem
.
clipping
Properties
.
relativeToDefaultPosition
);
C
.
msToUs
(
mediaItem
.
clipping
Configuration
.
startPositionMs
),
C
.
msToUs
(
mediaItem
.
clipping
Configuration
.
endPositionMs
),
/* enableInitialDiscontinuity= */
!
mediaItem
.
clipping
Configuration
.
startsAtKeyFrame
,
/* allowDynamicClippingUpdates= */
mediaItem
.
clipping
Configuration
.
relativeToLiveWindow
,
mediaItem
.
clipping
Configuration
.
relativeToDefaultPosition
);
}
private
MediaSource
maybeWrapWithAdsMediaSource
(
MediaItem
mediaItem
,
MediaSource
mediaSource
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment