Commit d64bbb44 by claincly Committed by Oliver Woodman

Fix TCP retry bug when some RTSP tracks are not selected.

The size of rtspLoaderWrappers must match the number of tracks exposed by the
RTSP session (a track is exposed if its media description entry appears in
DESCRIBE's SDP response).

When retrying with TCP, the old code will start loading all exposed RTSP
tracks, regardless of whether they are selected.
The fixed code will only start loading selected tracks.

#minor-release

PiperOrigin-RevId: 377931030
parent e1a071b3
...@@ -306,11 +306,13 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull; ...@@ -306,11 +306,13 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
@Nullable @Nullable
private RtpDataLoadable getLoadableByTrackUri(Uri trackUri) { private RtpDataLoadable getLoadableByTrackUri(Uri trackUri) {
for (int i = 0; i < rtspLoaderWrappers.size(); i++) { for (int i = 0; i < rtspLoaderWrappers.size(); i++) {
if (!rtspLoaderWrappers.get(i).canceled) {
RtpLoadInfo loadInfo = rtspLoaderWrappers.get(i).loadInfo; RtpLoadInfo loadInfo = rtspLoaderWrappers.get(i).loadInfo;
if (loadInfo.getTrackUri().equals(trackUri)) { if (loadInfo.getTrackUri().equals(trackUri)) {
return loadInfo.loadable; return loadInfo.loadable;
} }
} }
}
return null; return null;
} }
...@@ -543,18 +545,22 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull; ...@@ -543,18 +545,22 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
ArrayList<RtspLoaderWrapper> newLoaderWrappers = new ArrayList<>(rtspLoaderWrappers.size()); ArrayList<RtspLoaderWrapper> newLoaderWrappers = new ArrayList<>(rtspLoaderWrappers.size());
ArrayList<RtpLoadInfo> newSelectedLoadInfos = new ArrayList<>(selectedLoadInfos.size()); ArrayList<RtpLoadInfo> newSelectedLoadInfos = new ArrayList<>(selectedLoadInfos.size());
// newLoaderWrappers' elements and orders must match those of rtspLoaderWrappers'.
for (int i = 0; i < rtspLoaderWrappers.size(); i++) { for (int i = 0; i < rtspLoaderWrappers.size(); i++) {
RtspLoaderWrapper loaderWrapper = rtspLoaderWrappers.get(i); RtspLoaderWrapper loaderWrapper = rtspLoaderWrappers.get(i);
if (!loaderWrapper.canceled) {
RtspLoaderWrapper newLoaderWrapper = RtspLoaderWrapper newLoaderWrapper =
new RtspLoaderWrapper( new RtspLoaderWrapper(
loaderWrapper.loadInfo.mediaTrack, /* trackId= */ i, rtpDataChannelFactory); loaderWrapper.loadInfo.mediaTrack, /* trackId= */ i, rtpDataChannelFactory);
newLoaderWrappers.add(newLoaderWrapper); newLoaderWrappers.add(newLoaderWrapper);
newLoaderWrapper.startLoading(); newLoaderWrapper.startLoading();
if (selectedLoadInfos.contains(loaderWrapper.loadInfo)) { if (selectedLoadInfos.contains(loaderWrapper.loadInfo)) {
newSelectedLoadInfos.add(newLoaderWrapper.loadInfo); newSelectedLoadInfos.add(newLoaderWrapper.loadInfo);
} }
} else {
newLoaderWrappers.add(loaderWrapper);
}
} }
// Switch to new LoaderWrappers. // Switch to new LoaderWrappers.
...@@ -644,22 +650,23 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull; ...@@ -644,22 +650,23 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
/** Cancels loading. */ /** Cancels loading. */
public void cancelLoad() { public void cancelLoad() {
if (canceled) { if (!canceled) {
return;
}
loadInfo.loadable.cancelLoad(); loadInfo.loadable.cancelLoad();
canceled = true; canceled = true;
// Update loadingFinished every time loading is canceled. // Update loadingFinished every time loading is canceled.
updateLoadingFinished(); updateLoadingFinished();
} }
}
/** Resets the {@link Loadable} and {@link SampleQueue} to prepare for an RTSP seek. */ /** Resets the {@link Loadable} and {@link SampleQueue} to prepare for an RTSP seek. */
public void seekTo(long positionUs) { public void seekTo(long positionUs) {
if (!canceled) {
loadInfo.loadable.resetForSeek(); loadInfo.loadable.resetForSeek();
sampleQueue.reset(); sampleQueue.reset();
sampleQueue.setStartTimeUs(positionUs); sampleQueue.setStartTimeUs(positionUs);
} }
}
/** Releases the instance. */ /** Releases the instance. */
public void release() { public void release() {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment