#1583 - Modify in event time generation of TtmlNode

Look for "div" tags when generating the set of times.

library/core/src/main/java/com/google/android/exoplayer2/text/ttml/TtmlDecoder.java

@@ -479,7 +479,7 @@ public final class TtmlDecoder extends SimpleSubtitleDecoder {
     long startTime = C.TIME_UNSET;
     long startTime = C.TIME_UNSET;
     long endTime = C.TIME_UNSET;
     long endTime = C.TIME_UNSET;
     String regionId = TtmlNode.ANONYMOUS_REGION_ID;
     String regionId = TtmlNode.ANONYMOUS_REGION_ID;
-    String imageId = "";
+    String imageId = null;
     String[] styleIds = null;
     String[] styleIds = null;
     int attributeCount = parser.getAttributeCount();
     int attributeCount = parser.getAttributeCount();
     TtmlStyle style = parseStyleAttributes(parser, null);
     TtmlStyle style = parseStyleAttributes(parser, null);
@@ -511,7 +511,11 @@ public final class TtmlDecoder extends SimpleSubtitleDecoder {
           }
           }
           break;
           break;
         case ATTR_IMAGE:
         case ATTR_IMAGE:
+          // Parse URI reference only if refers to an element in the same document (it must start with '#')
+          // Resolving URIs from external sources is not supported
+          if (value.startsWith("#")) {
             imageId = value.substring(1);
             imageId = value.substring(1);
+          }
           break;
           break;
         default:
         default:
           // Do nothing.
           // Do nothing.

library/core/src/main/java/com/google/android/exoplayer2/text/ttml/TtmlNode.java

@@ -159,7 +159,8 @@ import java.util.TreeSet;
 
 
   private void getEventTimes(TreeSet<Long> out, boolean descendsPNode) {
   private void getEventTimes(TreeSet<Long> out, boolean descendsPNode) {
     boolean isPNode = TAG_P.equals(tag);
     boolean isPNode = TAG_P.equals(tag);
-    if (descendsPNode || isPNode) {
+    boolean isDivNode = TAG_DIV.equals(tag);
+    if (descendsPNode || isPNode || (isDivNode && imageId != null)) {
       if (startTimeUs != C.TIME_UNSET) {
       if (startTimeUs != C.TIME_UNSET) {
         out.add(startTimeUs);
         out.add(startTimeUs);
       }
       }
@@ -204,7 +205,7 @@ import java.util.TreeSet;
               Cue.TYPE_UNSET,
               Cue.TYPE_UNSET,
               region.line,
               region.line,
               region.lineAnchor,
               region.lineAnchor,
-              region.width,
+              region.width == Cue.DIMEN_UNSET ? 0.5f : region.width,
               Cue.DIMEN_UNSET
               Cue.DIMEN_UNSET
           )
           )
       );
       );
@@ -229,13 +230,18 @@ import java.util.TreeSet;
     return cues;
     return cues;
   }
   }
 
 
-  private void traverseForImage(long timeUs, String inheritedRegion, List<Pair<String, String>> regionImageList) {
-      // TODO isActive needed?
+  private void traverseForImage(
+      long timeUs,
+      String inheritedRegion,
+      List<Pair<String, String>> regionImageList) {
 
 
     String resolvedRegionId = ANONYMOUS_REGION_ID.equals(regionId) ? inheritedRegion : regionId;
     String resolvedRegionId = ANONYMOUS_REGION_ID.equals(regionId) ? inheritedRegion : regionId;
+
+    if (isActive(timeUs)) {
       if (TAG_DIV.equals(tag) && imageId != null) {
       if (TAG_DIV.equals(tag) && imageId != null) {
         regionImageList.add(new Pair<>(resolvedRegionId, imageId));
         regionImageList.add(new Pair<>(resolvedRegionId, imageId));
       }
       }
+    }
 
 
     for (int i = 0; i < getChildCount(); ++i) {
     for (int i = 0; i < getChildCount(); ++i) {
       getChild(i).traverseForImage(timeUs, resolvedRegionId, regionImageList);
       getChild(i).traverseForImage(timeUs, resolvedRegionId, regionImageList);