Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
c1767899
authored
Jan 24, 2019
by
aquilescanta
Committed by
Oliver Woodman
Jan 30, 2019
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Parse CHANNELS attribute from EXT-X-MEDIA
PiperOrigin-RevId: 230743198
parent
28434044
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
38 additions
and
1 deletions
RELEASENOTES.md
library/hls/src/main/java/com/google/android/exoplayer2/source/hls/playlist/HlsPlaylistParser.java
library/hls/src/test/java/com/google/android/exoplayer2/source/hls/playlist/HlsMasterPlaylistParserTest.java
RELEASENOTES.md
View file @
c1767899
# Release notes #
# Release notes #
### 2.9.5 ###
*
HLS: Parse
`CHANNELS`
attribute from
`EXT-X-MEDIA`
.
### 2.9.4 ###
### 2.9.4 ###
*
IMA extension: Clear ads loader listeners on release
*
IMA extension: Clear ads loader listeners on release
...
...
library/hls/src/main/java/com/google/android/exoplayer2/source/hls/playlist/HlsPlaylistParser.java
View file @
c1767899
...
@@ -101,6 +101,7 @@ public final class HlsPlaylistParser implements ParsingLoadable.Parser<HlsPlayli
...
@@ -101,6 +101,7 @@ public final class HlsPlaylistParser implements ParsingLoadable.Parser<HlsPlayli
Pattern
.
compile
(
"AVERAGE-BANDWIDTH=(\\d+)\\b"
);
Pattern
.
compile
(
"AVERAGE-BANDWIDTH=(\\d+)\\b"
);
private
static
final
Pattern
REGEX_AUDIO
=
Pattern
.
compile
(
"AUDIO=\"(.+?)\""
);
private
static
final
Pattern
REGEX_AUDIO
=
Pattern
.
compile
(
"AUDIO=\"(.+?)\""
);
private
static
final
Pattern
REGEX_BANDWIDTH
=
Pattern
.
compile
(
"[^-]BANDWIDTH=(\\d+)\\b"
);
private
static
final
Pattern
REGEX_BANDWIDTH
=
Pattern
.
compile
(
"[^-]BANDWIDTH=(\\d+)\\b"
);
private
static
final
Pattern
REGEX_CHANNELS
=
Pattern
.
compile
(
"CHANNELS=\"(.+?)\""
);
private
static
final
Pattern
REGEX_CODECS
=
Pattern
.
compile
(
"CODECS=\"(.+?)\""
);
private
static
final
Pattern
REGEX_CODECS
=
Pattern
.
compile
(
"CODECS=\"(.+?)\""
);
private
static
final
Pattern
REGEX_RESOLUTION
=
Pattern
.
compile
(
"RESOLUTION=(\\d+x\\d+)"
);
private
static
final
Pattern
REGEX_RESOLUTION
=
Pattern
.
compile
(
"RESOLUTION=(\\d+x\\d+)"
);
private
static
final
Pattern
REGEX_FRAME_RATE
=
Pattern
.
compile
(
"FRAME-RATE=([\\d\\.]+)\\b"
);
private
static
final
Pattern
REGEX_FRAME_RATE
=
Pattern
.
compile
(
"FRAME-RATE=([\\d\\.]+)\\b"
);
...
@@ -346,6 +347,7 @@ public final class HlsPlaylistParser implements ParsingLoadable.Parser<HlsPlayli
...
@@ -346,6 +347,7 @@ public final class HlsPlaylistParser implements ParsingLoadable.Parser<HlsPlayli
switch
(
parseStringAttr
(
line
,
REGEX_TYPE
,
variableDefinitions
))
{
switch
(
parseStringAttr
(
line
,
REGEX_TYPE
,
variableDefinitions
))
{
case
TYPE_AUDIO:
case
TYPE_AUDIO:
String
codecs
=
audioGroupIdToCodecs
.
get
(
groupId
);
String
codecs
=
audioGroupIdToCodecs
.
get
(
groupId
);
int
channelCount
=
parseChannelsAttribute
(
line
,
variableDefinitions
);
String
sampleMimeType
=
codecs
!=
null
?
MimeTypes
.
getMediaMimeType
(
codecs
)
:
null
;
String
sampleMimeType
=
codecs
!=
null
?
MimeTypes
.
getMediaMimeType
(
codecs
)
:
null
;
format
=
format
=
Format
.
createAudioContainerFormat
(
Format
.
createAudioContainerFormat
(
...
@@ -355,7 +357,7 @@ public final class HlsPlaylistParser implements ParsingLoadable.Parser<HlsPlayli
...
@@ -355,7 +357,7 @@ public final class HlsPlaylistParser implements ParsingLoadable.Parser<HlsPlayli
sampleMimeType
,
sampleMimeType
,
codecs
,
codecs
,
/* bitrate= */
Format
.
NO_VALUE
,
/* bitrate= */
Format
.
NO_VALUE
,
/* channelCount= */
Format
.
NO_VALUE
,
channelCount
,
/* sampleRate= */
Format
.
NO_VALUE
,
/* sampleRate= */
Format
.
NO_VALUE
,
/* initializationData= */
null
,
/* initializationData= */
null
,
selectionFlags
,
selectionFlags
,
...
@@ -661,6 +663,13 @@ public final class HlsPlaylistParser implements ParsingLoadable.Parser<HlsPlayli
...
@@ -661,6 +663,13 @@ public final class HlsPlaylistParser implements ParsingLoadable.Parser<HlsPlayli
return
flags
;
return
flags
;
}
}
private
static
int
parseChannelsAttribute
(
String
line
,
Map
<
String
,
String
>
variableDefinitions
)
{
String
channelsString
=
parseOptionalStringAttr
(
line
,
REGEX_CHANNELS
,
variableDefinitions
);
return
channelsString
!=
null
?
Integer
.
parseInt
(
Util
.
splitAtFirst
(
channelsString
,
"/"
)[
0
])
:
Format
.
NO_VALUE
;
}
private
static
@Nullable
SchemeData
parsePlayReadySchemeData
(
private
static
@Nullable
SchemeData
parsePlayReadySchemeData
(
String
line
,
Map
<
String
,
String
>
variableDefinitions
)
throws
ParserException
{
String
line
,
Map
<
String
,
String
>
variableDefinitions
)
throws
ParserException
{
String
keyFormatVersions
=
String
keyFormatVersions
=
...
...
library/hls/src/test/java/com/google/android/exoplayer2/source/hls/playlist/HlsMasterPlaylistParserTest.java
View file @
c1767899
...
@@ -81,6 +81,18 @@ public class HlsMasterPlaylistParserTest {
...
@@ -81,6 +81,18 @@ public class HlsMasterPlaylistParserTest {
+
"CODECS=\"mp4a.40.2,avc1.66.30\",RESOLUTION=304x128\n"
+
"CODECS=\"mp4a.40.2,avc1.66.30\",RESOLUTION=304x128\n"
+
"http://example.com/low.m3u8\n"
;
+
"http://example.com/low.m3u8\n"
;
private
static
final
String
PLAYLIST_WITH_CHANNELS_ATTRIBUTE
=
" #EXTM3U \n"
+
"#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID=\"audio\",CHANNELS=\"6\",NAME=\"Eng6\","
+
"URI=\"something.m3u8\"\n"
+
"#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID=\"audio\",CHANNELS=\"2/6\",NAME=\"Eng26\","
+
"URI=\"something2.m3u8\"\n"
+
"#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID=\"audio\",NAME=\"Eng\","
+
"URI=\"something3.m3u8\"\n"
+
"#EXT-X-STREAM-INF:BANDWIDTH=1280000,"
+
"CODECS=\"mp4a.40.2,avc1.66.30\",AUDIO=\"audio\",RESOLUTION=304x128\n"
+
"http://example.com/low.m3u8\n"
;
private
static
final
String
PLAYLIST_WITHOUT_CC
=
private
static
final
String
PLAYLIST_WITHOUT_CC
=
" #EXTM3U \n"
" #EXTM3U \n"
+
"#EXT-X-MEDIA:TYPE=CLOSED-CAPTIONS,"
+
"#EXT-X-MEDIA:TYPE=CLOSED-CAPTIONS,"
...
@@ -217,6 +229,17 @@ public class HlsMasterPlaylistParserTest {
...
@@ -217,6 +229,17 @@ public class HlsMasterPlaylistParserTest {
}
}
@Test
@Test
public
void
testPlaylistWithChannelsAttribute
()
throws
IOException
{
HlsMasterPlaylist
playlist
=
parseMasterPlaylist
(
PLAYLIST_URI
,
PLAYLIST_WITH_CHANNELS_ATTRIBUTE
);
List
<
HlsMasterPlaylist
.
HlsUrl
>
audios
=
playlist
.
audios
;
assertThat
(
audios
).
hasSize
(
3
);
assertThat
(
audios
.
get
(
0
).
format
.
channelCount
).
isEqualTo
(
6
);
assertThat
(
audios
.
get
(
1
).
format
.
channelCount
).
isEqualTo
(
2
);
assertThat
(
audios
.
get
(
2
).
format
.
channelCount
).
isEqualTo
(
Format
.
NO_VALUE
);
}
@Test
public
void
testPlaylistWithoutClosedCaptions
()
throws
IOException
{
public
void
testPlaylistWithoutClosedCaptions
()
throws
IOException
{
HlsMasterPlaylist
playlist
=
parseMasterPlaylist
(
PLAYLIST_URI
,
PLAYLIST_WITHOUT_CC
);
HlsMasterPlaylist
playlist
=
parseMasterPlaylist
(
PLAYLIST_URI
,
PLAYLIST_WITHOUT_CC
);
assertThat
(
playlist
.
muxedCaptionFormats
).
isEmpty
();
assertThat
(
playlist
.
muxedCaptionFormats
).
isEmpty
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment