Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
be69d5b7
authored
Jan 07, 2019
by
aquilescanta
Committed by
Oliver Woodman
Jan 08, 2019
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Expand check for muxed audio media tags to include uris that match variants
Issue:#5313 PiperOrigin-RevId: 228155222
parent
147deafd
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
34 additions
and
1 deletions
library/hls/src/main/java/com/google/android/exoplayer2/source/hls/playlist/HlsPlaylistParser.java
library/hls/src/test/java/com/google/android/exoplayer2/source/hls/playlist/HlsMasterPlaylistParserTest.java
library/hls/src/main/java/com/google/android/exoplayer2/source/hls/playlist/HlsPlaylistParser.java
View file @
be69d5b7
...
...
@@ -360,7 +360,7 @@ public final class HlsPlaylistParser implements ParsingLoadable.Parser<HlsPlayli
/* initializationData= */
null
,
selectionFlags
,
language
);
if
(
uri
==
null
)
{
if
(
isMediaTagMuxed
(
variants
,
uri
)
)
{
muxedAudioFormat
=
format
;
}
else
{
audios
.
add
(
new
HlsMasterPlaylist
.
HlsUrl
(
uri
,
format
));
...
...
@@ -766,6 +766,20 @@ public final class HlsPlaylistParser implements ParsingLoadable.Parser<HlsPlayli
return
Pattern
.
compile
(
attribute
+
"=("
+
BOOLEAN_FALSE
+
"|"
+
BOOLEAN_TRUE
+
")"
);
}
private
static
boolean
isMediaTagMuxed
(
List
<
HlsMasterPlaylist
.
HlsUrl
>
variants
,
String
mediaTagUri
)
{
if
(
mediaTagUri
==
null
)
{
return
true
;
}
// The URI attribute is defined, but it may match the uri of a variant.
for
(
int
i
=
0
;
i
<
variants
.
size
();
i
++)
{
if
(
mediaTagUri
.
equals
(
variants
.
get
(
i
).
url
))
{
return
true
;
}
}
return
false
;
}
private
static
class
LineIterator
{
private
final
BufferedReader
reader
;
...
...
library/hls/src/test/java/com/google/android/exoplayer2/source/hls/playlist/HlsMasterPlaylistParserTest.java
View file @
be69d5b7
...
...
@@ -134,6 +134,17 @@ public class HlsMasterPlaylistParserTest {
+
"#EXT-X-STREAM-INF:BANDWIDTH=65000,CODECS=\"{$codecs}\"\n"
+
"http://example.com/{$tricky}\n"
;
private
static
final
String
PLAYLIST_WITH_MULTIPLE_MUXED_MEDIA_TAGS
=
"#EXTM3U\n"
+
"#EXT-X-VERSION:3\n"
+
"#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID=\"a\",NAME=\"audio_0\",DEFAULT=YES,URI=\"0/0.m3u8\"\n"
+
"#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID=\"b\",NAME=\"audio_0\",DEFAULT=YES,URI=\"1/1.m3u8\"\n"
+
"#EXT-X-STREAM-INF:BANDWIDTH=140800,CODECS=\"mp4a.40.2\",AUDIO=\"a\"\n"
+
"0/0.m3u8\n"
+
"\n"
+
"#EXT-X-STREAM-INF:BANDWIDTH=281600,CODECS=\"mp4a.40.2\",AUDIO=\"b\"\n"
+
"1/1.m3u8\n"
;
@Test
public
void
testParseMasterPlaylist
()
throws
IOException
{
HlsMasterPlaylist
masterPlaylist
=
parseMasterPlaylist
(
PLAYLIST_URI
,
PLAYLIST_SIMPLE
);
...
...
@@ -271,6 +282,14 @@ public class HlsMasterPlaylistParserTest {
assertThat
(
variant
.
url
).
isEqualTo
(
"http://example.com/This/{$nested}/reference/shouldnt/work"
);
}
@Test
public
void
testMultipleMuxedMediaTags
()
throws
IOException
{
HlsMasterPlaylist
playlistWithMultipleMuxedMediaTags
=
parseMasterPlaylist
(
PLAYLIST_URI
,
PLAYLIST_WITH_MULTIPLE_MUXED_MEDIA_TAGS
);
assertThat
(
playlistWithMultipleMuxedMediaTags
.
variants
).
hasSize
(
2
);
assertThat
(
playlistWithMultipleMuxedMediaTags
.
audios
).
isEmpty
();
}
private
static
HlsMasterPlaylist
parseMasterPlaylist
(
String
uri
,
String
playlistString
)
throws
IOException
{
Uri
playlistUri
=
Uri
.
parse
(
uri
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment