Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
b48a762f
authored
Jul 14, 2020
by
ibaker
Committed by
Oliver Woodman
Jul 24, 2020
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Migrate overrides of deprecated AdsViewProvider.getAdOverlayViews
PiperOrigin-RevId: 321121735
parent
e9a83353
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
7 deletions
extensions/ima/build.gradle
extensions/ima/src/androidTest/java/com/google/android/exoplayer2/ext/ima/ImaPlaybackTest.java
extensions/ima/src/test/java/com/google/android/exoplayer2/ext/ima/ImaAdsLoaderTest.java
extensions/ima/build.gradle
View file @
b48a762f
...
...
@@ -35,6 +35,7 @@ dependencies {
androidTestImplementation
'androidx.multidex:multidex:'
+
androidxMultidexVersion
androidTestImplementation
'androidx.test:rules:'
+
androidxTestRulesVersion
androidTestImplementation
'androidx.test:runner:'
+
androidxTestRunnerVersion
androidTestImplementation
'com.google.guava:guava:'
+
guavaVersion
androidTestCompileOnly
'org.checkerframework:checker-qual:'
+
checkerframeworkVersion
testImplementation
project
(
modulePrefix
+
'testutils'
)
testImplementation
'com.google.guava:guava:'
+
guavaVersion
...
...
extensions/ima/src/androidTest/java/com/google/android/exoplayer2/ext/ima/ImaPlaybackTest.java
View file @
b48a762f
...
...
@@ -20,7 +20,6 @@ import static com.google.common.truth.Truth.assertThat;
import
android.content.Context
;
import
android.net.Uri
;
import
android.view.Surface
;
import
android.view.View
;
import
android.view.ViewGroup
;
import
android.widget.FrameLayout
;
import
androidx.annotation.Nullable
;
...
...
@@ -39,6 +38,7 @@ import com.google.android.exoplayer2.decoder.DecoderCounters;
import
com.google.android.exoplayer2.drm.DrmSessionManager
;
import
com.google.android.exoplayer2.source.DefaultMediaSourceFactory
;
import
com.google.android.exoplayer2.source.MediaSource
;
import
com.google.android.exoplayer2.source.ads.AdsLoader
;
import
com.google.android.exoplayer2.source.ads.AdsLoader.AdViewProvider
;
import
com.google.android.exoplayer2.source.ads.AdsMediaSource
;
import
com.google.android.exoplayer2.testutil.ActionSchedule
;
...
...
@@ -50,6 +50,7 @@ import com.google.android.exoplayer2.upstream.DataSource;
import
com.google.android.exoplayer2.upstream.DefaultDataSourceFactory
;
import
com.google.android.exoplayer2.util.Assertions
;
import
com.google.android.exoplayer2.util.Util
;
import
com.google.common.collect.ImmutableList
;
import
java.util.ArrayList
;
import
java.util.Arrays
;
import
java.util.List
;
...
...
@@ -249,14 +250,15 @@ public final class ImaPlaybackTest {
dataSourceFactory
,
Assertions
.
checkNotNull
(
imaAdsLoader
),
new
AdViewProvider
()
{
@Override
public
ViewGroup
getAdViewGroup
()
{
return
overlayFrameLayout
;
}
@Override
public
View
[]
getAdOverlayView
s
()
{
return
new
View
[
0
]
;
public
ImmutableList
<
AdsLoader
.
OverlayInfo
>
getAdOverlayInfo
s
()
{
return
ImmutableList
.
of
()
;
}
});
}
...
...
extensions/ima/src/test/java/com/google/android/exoplayer2/ext/ima/ImaAdsLoaderTest.java
View file @
b48a762f
...
...
@@ -116,7 +116,6 @@ public final class ImaAdsLoaderTest {
@Mock
private
AdEvent
mockPostrollFetchErrorAdEvent
;
private
ViewGroup
adViewGroup
;
private
View
adOverlayView
;
private
AdsLoader
.
AdViewProvider
adViewProvider
;
private
AdEvent
.
AdEventListener
adEventListener
;
private
ContentProgressProvider
contentProgressProvider
;
...
...
@@ -129,7 +128,7 @@ public final class ImaAdsLoaderTest {
public
void
setUp
()
{
setupMocks
();
adViewGroup
=
new
FrameLayout
(
ApplicationProvider
.
getApplicationContext
());
adOverlayView
=
new
View
(
ApplicationProvider
.
getApplicationContext
());
View
adOverlayView
=
new
View
(
ApplicationProvider
.
getApplicationContext
());
adViewProvider
=
new
AdsLoader
.
AdViewProvider
()
{
@Override
...
...
@@ -138,8 +137,9 @@ public final class ImaAdsLoaderTest {
}
@Override
public
View
[]
getAdOverlayViews
()
{
return
new
View
[]
{
adOverlayView
};
public
ImmutableList
<
AdsLoader
.
OverlayInfo
>
getAdOverlayInfos
()
{
return
ImmutableList
.
of
(
new
AdsLoader
.
OverlayInfo
(
adOverlayView
,
AdsLoader
.
OverlayInfo
.
PURPOSE_CLOSE_AD
));
}
};
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment