Skip to content

SDK / exoplayer

Go to a project
Commit af5386cb by samrobinson Committed by Ian Baker
Options

Add the frame count to TransformationResult. 

Calculate throughputFps for TransformationTestResult.

PiperOrigin-RevId: 438817440
parent 0c688286
Inline Side-by-side
Showing with 66 additions and 138 deletions
libraries/transformer/src/androidTest/java/androidx/media3/transformer/FrameCountingMuxer.java deleted 100644 → 0
/*
* Copyright 2022 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package androidx.media3.transformer;
import android.os.ParcelFileDescriptor;
import androidx.annotation.Nullable;
import androidx.media3.common.C;
import androidx.media3.common.Format;
import androidx.media3.common.MimeTypes;
import com.google.common.collect.ImmutableList;
import java.io.IOException;
import java.nio.ByteBuffer;
import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
/**
* An implementation of {@link Muxer} that forwards operations to another {@link Muxer}, counting
* the number of frames as they go past.
*/
/* package */ final class FrameCountingMuxer implements Muxer {
public static final class Factory implements Muxer.Factory {
private final Muxer.Factory muxerFactory;
private @MonotonicNonNull FrameCountingMuxer frameCountingMuxer;
public Factory(Muxer.Factory muxerFactory) {
this.muxerFactory = muxerFactory;
}
@Override
public Muxer create(String path, String outputMimeType) throws IOException {
frameCountingMuxer = new FrameCountingMuxer(muxerFactory.create(path, outputMimeType));
return frameCountingMuxer;
}
@Override
public Muxer create(ParcelFileDescriptor parcelFileDescriptor, String outputMimeType)
throws IOException {
frameCountingMuxer =
new FrameCountingMuxer(muxerFactory.create(parcelFileDescriptor, outputMimeType));
return frameCountingMuxer;
}
@Override
public boolean supportsOutputMimeType(String mimeType) {
return muxerFactory.supportsOutputMimeType(mimeType);
}
@Override
public boolean supportsSampleMimeType(@Nullable String sampleMimeType, String outputMimeType) {
return muxerFactory.supportsSampleMimeType(sampleMimeType, outputMimeType);
}
@Override
public ImmutableList<String> getSupportedSampleMimeTypes(
@C.TrackType int trackType, String containerMimeType) {
return muxerFactory.getSupportedSampleMimeTypes(trackType, containerMimeType);
}
@Nullable
public FrameCountingMuxer getLastFrameCountingMuxerCreated() {
return frameCountingMuxer;
}
}
private final Muxer muxer;
private int videoTrackIndex;
private int frameCount;
private FrameCountingMuxer(Muxer muxer) throws IOException {
this.muxer = muxer;
}
@Override
public int addTrack(Format format) throws MuxerException {
int trackIndex = muxer.addTrack(format);
if (MimeTypes.isVideo(format.sampleMimeType)) {
videoTrackIndex = trackIndex;
}
return trackIndex;
}
@Override
public void writeSampleData(
int trackIndex, ByteBuffer data, boolean isKeyFrame, long presentationTimeUs)
throws MuxerException {
muxer.writeSampleData(trackIndex, data, isKeyFrame, presentationTimeUs);
if (trackIndex == videoTrackIndex) {
frameCount++;
}
}
@Override
public void release(boolean forCancellation) throws MuxerException {
muxer.release(forCancellation);
}
/* Returns the number of frames written for the video track. */
public int getFrameCount() {
return frameCount;
}
}
libraries/transformer/src/androidTest/java/androidx/media3/transformer/TransformationTestResult.java
...@@ -31,7 +31,6 @@ public class TransformationTestResult { ...@@ -31,7 +31,6 @@ public class TransformationTestResult {
@Nullable private String filePath; @Nullable private String filePath;
@Nullable private Exception analysisException; @Nullable private Exception analysisException;
private long elapsedTimeMs; private long elapsedTimeMs;
private double ssim; private double ssim;
...@@ -103,9 +102,13 @@ public class TransformationTestResult { ...@@ -103,9 +102,13 @@ public class TransformationTestResult {
} }
public final TransformationResult transformationResult; public final TransformationResult transformationResult;
@Nullable public final String filePath; @Nullable public final String filePath;
/** /**
* The average rate (per second) at which frames are processed by the transformer, or {@link
* C#RATE_UNSET} if unset or unknown.
*/
public final float throughputFps;
/**
* The amount of time taken to perform the transformation in milliseconds. {@link C#TIME_UNSET} if * The amount of time taken to perform the transformation in milliseconds. {@link C#TIME_UNSET} if
* unset. * unset.
*/ */
...@@ -133,6 +136,12 @@ public class TransformationTestResult { ...@@ -133,6 +136,12 @@ public class TransformationTestResult {
if (transformationResult.averageVideoBitrate != C.RATE_UNSET_INT) { if (transformationResult.averageVideoBitrate != C.RATE_UNSET_INT) {
jsonObject.put("averageVideoBitrate", transformationResult.averageVideoBitrate); jsonObject.put("averageVideoBitrate", transformationResult.averageVideoBitrate);
} }
if (transformationResult.videoFrameCount > 0) {
jsonObject.put("videoFrameCount", transformationResult.videoFrameCount);
}
if (throughputFps != C.RATE_UNSET) {
jsonObject.put("throughputFps", throughputFps);
}
if (elapsedTimeMs != C.TIME_UNSET) { if (elapsedTimeMs != C.TIME_UNSET) {
jsonObject.put("elapsedTimeMs", elapsedTimeMs); jsonObject.put("elapsedTimeMs", elapsedTimeMs);
} }
...@@ -156,5 +165,9 @@ public class TransformationTestResult { ...@@ -156,5 +165,9 @@ public class TransformationTestResult {
this.elapsedTimeMs = elapsedTimeMs; this.elapsedTimeMs = elapsedTimeMs;
this.ssim = ssim; this.ssim = ssim;
this.analysisException = analysisException; this.analysisException = analysisException;
this.throughputFps =
elapsedTimeMs != C.TIME_UNSET && transformationResult.videoFrameCount > 0
? 1000f * transformationResult.videoFrameCount / elapsedTimeMs
: C.RATE_UNSET;
} }
} }
libraries/transformer/src/androidTest/java/androidx/media3/transformer/TransformerEndToEndTest.java
...@@ -15,7 +15,7 @@ ...@@ -15,7 +15,7 @@
*/ */
package androidx.media3.transformer; package androidx.media3.transformer;
import static androidx.media3.common.util.Assertions.checkNotNull; import static androidx.media3.transformer.AndroidTestUtil.MP4_ASSET_URI_STRING;
import static com.google.common.truth.Truth.assertThat; import static com.google.common.truth.Truth.assertThat;
import android.content.Context; import android.content.Context;
...@@ -31,18 +31,13 @@ import org.junit.runner.RunWith; ...@@ -31,18 +31,13 @@ import org.junit.runner.RunWith;
@RunWith(AndroidJUnit4.class) @RunWith(AndroidJUnit4.class)
public class TransformerEndToEndTest { public class TransformerEndToEndTest {
private static final String AVC_VIDEO_URI_STRING = "asset:///media/mp4/sample.mp4";
@Test @Test
public void videoEditing_completesWithConsistentFrameCount() throws Exception { public void videoEditing_completesWithConsistentFrameCount() throws Exception {
Context context = ApplicationProvider.getApplicationContext(); Context context = ApplicationProvider.getApplicationContext();
FrameCountingMuxer.Factory muxerFactory =
new FrameCountingMuxer.Factory(new FrameworkMuxer.Factory());
Transformer transformer = Transformer transformer =
new Transformer.Builder(context) new Transformer.Builder(context)
.setTransformationRequest( .setTransformationRequest(
new TransformationRequest.Builder().setResolution(480).build()) new TransformationRequest.Builder().setResolution(480).build())
.setMuxerFactory(muxerFactory)
.setEncoderFactory( .setEncoderFactory(
new DefaultEncoderFactory(EncoderSelector.DEFAULT, /* enableFallback= */ false)) new DefaultEncoderFactory(EncoderSelector.DEFAULT, /* enableFallback= */ false))
.build(); .build();
...@@ -50,13 +45,14 @@ public class TransformerEndToEndTest { ...@@ -50,13 +45,14 @@ public class TransformerEndToEndTest {
// ffprobe -count_frames -select_streams v:0 -show_entries stream=nb_read_frames sample.mp4 // ffprobe -count_frames -select_streams v:0 -show_entries stream=nb_read_frames sample.mp4
int expectedFrameCount = 30; int expectedFrameCount = 30;
TransformationTestResult result =
new TransformerAndroidTestRunner.Builder(context, transformer) new TransformerAndroidTestRunner.Builder(context, transformer)
.build() .build()
.run(/* testId= */ "videoEditing_completesWithConsistentFrameCount", AVC_VIDEO_URI_STRING); .run(
/* testId= */ "videoEditing_completesWithConsistentFrameCount",
MP4_ASSET_URI_STRING);
FrameCountingMuxer frameCountingMuxer = assertThat(result.transformationResult.videoFrameCount).isEqualTo(expectedFrameCount);
checkNotNull(muxerFactory.getLastFrameCountingMuxerCreated());
assertThat(frameCountingMuxer.getFrameCount()).isEqualTo(expectedFrameCount);
} }
@Test @Test
...@@ -75,7 +71,7 @@ public class TransformerEndToEndTest { ...@@ -75,7 +71,7 @@ public class TransformerEndToEndTest {
TransformationTestResult result = TransformationTestResult result =
new TransformerAndroidTestRunner.Builder(context, transformer) new TransformerAndroidTestRunner.Builder(context, transformer)
.build() .build()
.run(/* testId= */ "videoOnly_completesWithConsistentDuration", AVC_VIDEO_URI_STRING); .run(/* testId= */ "videoOnly_completesWithConsistentDuration", MP4_ASSET_URI_STRING);
assertThat(result.transformationResult.durationMs).isEqualTo(expectedDurationMs); assertThat(result.transformationResult.durationMs).isEqualTo(expectedDurationMs);
} }
......
libraries/transformer/src/main/java/androidx/media3/transformer/MuxerWrapper.java
...@@ -48,6 +48,7 @@ import java.nio.ByteBuffer; ...@@ -48,6 +48,7 @@ import java.nio.ByteBuffer;
private final Muxer muxer; private final Muxer muxer;
private final Muxer.Factory muxerFactory; private final Muxer.Factory muxerFactory;
private final SparseIntArray trackTypeToIndex; private final SparseIntArray trackTypeToIndex;
private final SparseIntArray trackTypeToSampleCount;
private final SparseLongArray trackTypeToTimeUs; private final SparseLongArray trackTypeToTimeUs;
private final SparseLongArray trackTypeToBytesWritten; private final SparseLongArray trackTypeToBytesWritten;
private final String containerMimeType; private final String containerMimeType;
...@@ -62,7 +63,9 @@ import java.nio.ByteBuffer; ...@@ -62,7 +63,9 @@ import java.nio.ByteBuffer;
this.muxer = muxer; this.muxer = muxer;
this.muxerFactory = muxerFactory; this.muxerFactory = muxerFactory;
this.containerMimeType = containerMimeType; this.containerMimeType = containerMimeType;
trackTypeToIndex = new SparseIntArray(); trackTypeToIndex = new SparseIntArray();
trackTypeToSampleCount = new SparseIntArray();
trackTypeToTimeUs = new SparseLongArray(); trackTypeToTimeUs = new SparseLongArray();
trackTypeToBytesWritten = new SparseLongArray(); trackTypeToBytesWritten = new SparseLongArray();
previousTrackType = C.TRACK_TYPE_NONE; previousTrackType = C.TRACK_TYPE_NONE;
...@@ -123,6 +126,7 @@ import java.nio.ByteBuffer; ...@@ -123,6 +126,7 @@ import java.nio.ByteBuffer;
int trackIndex = muxer.addTrack(format); int trackIndex = muxer.addTrack(format);
trackTypeToIndex.put(trackType, trackIndex); trackTypeToIndex.put(trackType, trackIndex);
trackTypeToSampleCount.put(trackType, 0);
trackTypeToTimeUs.put(trackType, 0L); trackTypeToTimeUs.put(trackType, 0L);
trackTypeToBytesWritten.put(trackType, 0L); trackTypeToBytesWritten.put(trackType, 0L);
trackFormatCount++; trackFormatCount++;
...@@ -158,6 +162,7 @@ import java.nio.ByteBuffer; ...@@ -158,6 +162,7 @@ import java.nio.ByteBuffer;
return false; return false;
} }
trackTypeToSampleCount.put(trackType, trackTypeToSampleCount.get(trackType) + 1);
trackTypeToBytesWritten.put( trackTypeToBytesWritten.put(
trackType, trackTypeToBytesWritten.get(trackType) + data.remaining()); trackType, trackTypeToBytesWritten.get(trackType) + data.remaining());
if (trackTypeToTimeUs.get(trackType) < presentationTimeUs) { if (trackTypeToTimeUs.get(trackType) < presentationTimeUs) {
...@@ -218,6 +223,16 @@ import java.nio.ByteBuffer; ...@@ -218,6 +223,16 @@ import java.nio.ByteBuffer;
/* divisor= */ trackDurationUs); /* divisor= */ trackDurationUs);
} }
/** Returns the number of samples written to the track of the provided {@code trackType}. */
public int getTrackSampleCount(@C.TrackType int trackType) {
return trackTypeToSampleCount.get(trackType, /* valueIfKeyNotFound= */ 0);
}
/** Returns the duration of the longest track in milliseconds. */
public long getDurationMs() {
return Util.usToMs(maxValue(trackTypeToTimeUs));
}
/** /**
* Returns whether the muxer can write a sample of the given track type. * Returns whether the muxer can write a sample of the given track type.
* *
...@@ -243,9 +258,4 @@ import java.nio.ByteBuffer; ...@@ -243,9 +258,4 @@ import java.nio.ByteBuffer;
} }
return trackTimeUs - minTrackTimeUs <= MAX_TRACK_WRITE_AHEAD_US; return trackTimeUs - minTrackTimeUs <= MAX_TRACK_WRITE_AHEAD_US;
} }
/** Returns the duration of the longest track in milliseconds. */
public long getDurationMs() {
return Util.usToMs(maxValue(trackTypeToTimeUs));
}
} }
libraries/transformer/src/main/java/androidx/media3/transformer/TransformationResult.java
...@@ -31,6 +31,7 @@ public final class TransformationResult { ...@@ -31,6 +31,7 @@ public final class TransformationResult {
private long fileSizeBytes; private long fileSizeBytes;
private int averageAudioBitrate; private int averageAudioBitrate;
private int averageVideoBitrate; private int averageVideoBitrate;
private int videoFrameCount;
public Builder() { public Builder() {
durationMs = C.TIME_UNSET; durationMs = C.TIME_UNSET;
...@@ -83,13 +84,24 @@ public final class TransformationResult { ...@@ -83,13 +84,24 @@ public final class TransformationResult {
return this; return this;
} }
/**
* Sets the number of video frames.
*
* <p>Input must be positive or {@code 0}.
*/
public Builder setVideoFrameCount(int videoFrameCount) {
checkArgument(videoFrameCount >= 0);
this.videoFrameCount = videoFrameCount;
return this;
}
public TransformationResult build() { public TransformationResult build() {
return new TransformationResult( return new TransformationResult(
durationMs, fileSizeBytes, averageAudioBitrate, averageVideoBitrate); durationMs, fileSizeBytes, averageAudioBitrate, averageVideoBitrate, videoFrameCount);
} }
} }
/** The duration of the video in milliseconds, or {@link C#TIME_UNSET} if unset or unknown. */ /** The duration of the file in milliseconds, or {@link C#TIME_UNSET} if unset or unknown. */
public final long durationMs; public final long durationMs;
/** The size of the file in bytes, or {@link C#LENGTH_UNSET} if unset or unknown. */ /** The size of the file in bytes, or {@link C#LENGTH_UNSET} if unset or unknown. */
public final long fileSizeBytes; public final long fileSizeBytes;
...@@ -101,13 +113,20 @@ public final class TransformationResult { ...@@ -101,13 +113,20 @@ public final class TransformationResult {
* The average bitrate of the video track data, or {@link C#RATE_UNSET_INT} if unset or unknown. * The average bitrate of the video track data, or {@link C#RATE_UNSET_INT} if unset or unknown.
*/ */
public final int averageVideoBitrate; public final int averageVideoBitrate;
/** The number of video frames. */
public final int videoFrameCount;
private TransformationResult( private TransformationResult(
long durationMs, long fileSizeBytes, int averageAudioBitrate, int averageVideoBitrate) { long durationMs,
long fileSizeBytes,
int averageAudioBitrate,
int averageVideoBitrate,
int videoFrameCount) {
this.durationMs = durationMs; this.durationMs = durationMs;
this.fileSizeBytes = fileSizeBytes; this.fileSizeBytes = fileSizeBytes;
this.averageAudioBitrate = averageAudioBitrate; this.averageAudioBitrate = averageAudioBitrate;
this.averageVideoBitrate = averageVideoBitrate; this.averageVideoBitrate = averageVideoBitrate;
this.videoFrameCount = videoFrameCount;
} }
public Builder buildUpon() { public Builder buildUpon() {
...@@ -115,7 +134,8 @@ public final class TransformationResult { ...@@ -115,7 +134,8 @@ public final class TransformationResult {
.setDurationMs(durationMs) .setDurationMs(durationMs)
.setFileSizeBytes(fileSizeBytes) .setFileSizeBytes(fileSizeBytes)
.setAverageAudioBitrate(averageAudioBitrate) .setAverageAudioBitrate(averageAudioBitrate)
.setAverageVideoBitrate(averageVideoBitrate); .setAverageVideoBitrate(averageVideoBitrate)
.setVideoFrameCount(videoFrameCount);
} }
@Override @Override
...@@ -130,7 +150,8 @@ public final class TransformationResult { ...@@ -130,7 +150,8 @@ public final class TransformationResult {
return durationMs == result.durationMs return durationMs == result.durationMs
&& fileSizeBytes == result.fileSizeBytes && fileSizeBytes == result.fileSizeBytes
&& averageAudioBitrate == result.averageAudioBitrate && averageAudioBitrate == result.averageAudioBitrate
&& averageVideoBitrate == result.averageVideoBitrate; && averageVideoBitrate == result.averageVideoBitrate
&& videoFrameCount == result.videoFrameCount;
} }
@Override @Override
...@@ -139,6 +160,7 @@ public final class TransformationResult { ...@@ -139,6 +160,7 @@ public final class TransformationResult {
result = 31 * result + (int) fileSizeBytes; result = 31 * result + (int) fileSizeBytes;
result = 31 * result + averageAudioBitrate; result = 31 * result + averageAudioBitrate;
result = 31 * result + averageVideoBitrate; result = 31 * result + averageVideoBitrate;
result = 31 * result + videoFrameCount;
return result; return result;
} }
} }
libraries/transformer/src/main/java/androidx/media3/transformer/Transformer.java
...@@ -704,7 +704,6 @@ public final class Transformer { ...@@ -704,7 +704,6 @@ public final class Transformer {
if (player != null) { if (player != null) {
throw new IllegalStateException("There is already a transformation in progress."); throw new IllegalStateException("There is already a transformation in progress.");
} }
MuxerWrapper muxerWrapper = new MuxerWrapper(muxer, muxerFactory, containerMimeType); MuxerWrapper muxerWrapper = new MuxerWrapper(muxer, muxerFactory, containerMimeType);
this.muxerWrapper = muxerWrapper; this.muxerWrapper = muxerWrapper;
DefaultTrackSelector trackSelector = new DefaultTrackSelector(context); DefaultTrackSelector trackSelector = new DefaultTrackSelector(context);
...@@ -1005,7 +1004,9 @@ public final class Transformer { ...@@ -1005,7 +1004,9 @@ public final class Transformer {
.setDurationMs(muxerWrapper.getDurationMs()) .setDurationMs(muxerWrapper.getDurationMs())
.setAverageAudioBitrate(muxerWrapper.getTrackAverageBitrate(C.TRACK_TYPE_AUDIO)) .setAverageAudioBitrate(muxerWrapper.getTrackAverageBitrate(C.TRACK_TYPE_AUDIO))
.setAverageVideoBitrate(muxerWrapper.getTrackAverageBitrate(C.TRACK_TYPE_VIDEO)) .setAverageVideoBitrate(muxerWrapper.getTrackAverageBitrate(C.TRACK_TYPE_VIDEO))
.setVideoFrameCount(muxerWrapper.getTrackSampleCount(C.TRACK_TYPE_VIDEO))
.build(); .build();
listeners.queueEvent( listeners.queueEvent(
/* eventFlag= */ C.INDEX_UNSET, /* eventFlag= */ C.INDEX_UNSET,
listener -> listener.onTransformationCompleted(mediaItem, result)); listener -> listener.onTransformationCompleted(mediaItem, result));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment