Skip to content

SDK / exoplayer

Go to a project
Commit 9d88db71 by Dustin
Options

Clean up BitmapFactoryVideoRenderer

parent b520b26f
Inline Side-by-side
Showing with 53 additions and 42 deletions
library/core/src/main/java/com/google/android/exoplayer2/video/BitmapFactoryVideoRenderer.java
...@@ -24,17 +24,22 @@ import java.nio.ByteBuffer; ...@@ -24,17 +24,22 @@ import java.nio.ByteBuffer;
public class BitmapFactoryVideoRenderer extends BaseRenderer { public class BitmapFactoryVideoRenderer extends BaseRenderer {
private static final String TAG = "BitmapFactoryRenderer"; private static final String TAG = "BitmapFactoryRenderer";
final VideoRendererEventListener.EventDispatcher eventDispatcher; private static int threadId;
@Nullable
volatile Surface surface;
private final Rect rect = new Rect(); private final Rect rect = new Rect();
private final Point lastSurface = new Point(); private final Point lastSurface = new Point();
private final RenderRunnable renderRunnable = new RenderRunnable(); private final RenderRunnable renderRunnable = new RenderRunnable();
private final Thread thread = new Thread(renderRunnable, "BitmapFactoryVideoRenderer");
final VideoRendererEventListener.EventDispatcher eventDispatcher;
final Thread thread = new Thread(renderRunnable, getClass().getSimpleName() + threadId++);
@Nullable
volatile Surface surface;
private VideoSize lastVideoSize = VideoSize.UNKNOWN; private VideoSize lastVideoSize = VideoSize.UNKNOWN;
private long currentTimeUs; private long currentTimeUs;
private long frameUs; private long frameUs;
boolean ended; private boolean firstFrameRendered;
@Nullable @Nullable
private DecoderCounters decoderCounters; private DecoderCounters decoderCounters;
...@@ -60,8 +65,7 @@ public class BitmapFactoryVideoRenderer extends BaseRenderer { ...@@ -60,8 +65,7 @@ public class BitmapFactoryVideoRenderer extends BaseRenderer {
@Override @Override
protected void onDisabled() { protected void onDisabled() {
renderRunnable.running = false; renderRunnable.stop();
thread.interrupt();
@Nullable @Nullable
final DecoderCounters decoderCounters = this.decoderCounters; final DecoderCounters decoderCounters = this.decoderCounters;
...@@ -111,7 +115,7 @@ public class BitmapFactoryVideoRenderer extends BaseRenderer { ...@@ -111,7 +115,7 @@ public class BitmapFactoryVideoRenderer extends BaseRenderer {
@Override @Override
public boolean isEnded() { public boolean isEnded() {
return renderRunnable.ended; return renderRunnable.isEnded();
} }
@Override @Override
...@@ -123,32 +127,9 @@ public class BitmapFactoryVideoRenderer extends BaseRenderer { ...@@ -123,32 +127,9 @@ public class BitmapFactoryVideoRenderer extends BaseRenderer {
return RendererCapabilities.create(C.FORMAT_UNSUPPORTED_TYPE); return RendererCapabilities.create(C.FORMAT_UNSUPPORTED_TYPE);
} }
class RenderRunnable implements Runnable { void renderBitmap(final Bitmap bitmap) {
private volatile boolean ended;
private boolean firstFrameRendered;
private volatile boolean running = true;
@Nullable @Nullable
private Bitmap decodeInputBuffer(final DecoderInputBuffer decoderInputBuffer) { final Surface surface = this.surface;
@Nullable final ByteBuffer byteBuffer = decoderInputBuffer.data;
if (byteBuffer != null) {
final Bitmap bitmap;
try {
bitmap = BitmapFactory.decodeByteArray(byteBuffer.array(), byteBuffer.arrayOffset(),
byteBuffer.arrayOffset() + byteBuffer.position());
if (bitmap == null) {
eventDispatcher.videoCodecError(new NullPointerException("Decode bytes failed"));
} else {
return bitmap;
}
} catch (Exception e) {
eventDispatcher.videoCodecError(e);
}
}
return null;
}
private void renderBitmap(final Bitmap bitmap, @Nullable final Surface surface) {
if (surface == null) { if (surface == null) {
return; return;
} }
...@@ -192,6 +173,41 @@ public class BitmapFactoryVideoRenderer extends BaseRenderer { ...@@ -192,6 +173,41 @@ public class BitmapFactoryVideoRenderer extends BaseRenderer {
} }
} }
class RenderRunnable implements Runnable {
final DecoderInputBuffer decoderInputBuffer =
new DecoderInputBuffer(DecoderInputBuffer.BUFFER_REPLACEMENT_MODE_NORMAL);
private volatile boolean running = true;
void stop() {
running = false;
thread.interrupt();
}
boolean isEnded() {
return !running || decoderInputBuffer.isEndOfStream();
}
@Nullable
private Bitmap decodeInputBuffer(final DecoderInputBuffer decoderInputBuffer) {
@Nullable final ByteBuffer byteBuffer = decoderInputBuffer.data;
if (byteBuffer != null) {
final Bitmap bitmap;
try {
bitmap = BitmapFactory.decodeByteArray(byteBuffer.array(), byteBuffer.arrayOffset(),
byteBuffer.arrayOffset() + byteBuffer.position());
if (bitmap == null) {
eventDispatcher.videoCodecError(new NullPointerException("Decode bytes failed"));
} else {
return bitmap;
}
} catch (Exception e) {
eventDispatcher.videoCodecError(e);
}
}
return null;
}
/** /**
* *
* @return true if interrupted * @return true if interrupted
...@@ -210,9 +226,6 @@ public class BitmapFactoryVideoRenderer extends BaseRenderer { ...@@ -210,9 +226,6 @@ public class BitmapFactoryVideoRenderer extends BaseRenderer {
public void run() { public void run() {
final FormatHolder formatHolder = getFormatHolder(); final FormatHolder formatHolder = getFormatHolder();
@NonNull
final DecoderInputBuffer decoderInputBuffer =
new DecoderInputBuffer(DecoderInputBuffer.BUFFER_REPLACEMENT_MODE_NORMAL);
long start = SystemClock.uptimeMillis(); long start = SystemClock.uptimeMillis();
main: main:
while (running) { while (running) {
...@@ -221,10 +234,8 @@ public class BitmapFactoryVideoRenderer extends BaseRenderer { ...@@ -221,10 +234,8 @@ public class BitmapFactoryVideoRenderer extends BaseRenderer {
formatHolder.format == null ? SampleStream.FLAG_REQUIRE_FORMAT : 0); formatHolder.format == null ? SampleStream.FLAG_REQUIRE_FORMAT : 0);
if (result == C.RESULT_BUFFER_READ) { if (result == C.RESULT_BUFFER_READ) {
if (decoderInputBuffer.isEndOfStream()) { if (decoderInputBuffer.isEndOfStream()) {
ended = true; //Wait for shutdown or stream to be changed
if (!sleep()) { sleep();
ended = false;
}
continue; continue;
} }
final long leadUs = decoderInputBuffer.timeUs - currentTimeUs; final long leadUs = decoderInputBuffer.timeUs - currentTimeUs;
...@@ -244,17 +255,17 @@ public class BitmapFactoryVideoRenderer extends BaseRenderer { ...@@ -244,17 +255,17 @@ public class BitmapFactoryVideoRenderer extends BaseRenderer {
while (currentTimeUs < decoderInputBuffer.timeUs) { while (currentTimeUs < decoderInputBuffer.timeUs) {
//Log.d(TAG, "Sleep: us=" + currentTimeUs); //Log.d(TAG, "Sleep: us=" + currentTimeUs);
if (sleep()) { if (sleep()) {
//Sleep was interrupted, discard Bitmap
continue main; continue main;
} }
} }
if (running) { if (running) {
renderBitmap(bitmap, surface); renderBitmap(bitmap);
} }
} else if (result == C.RESULT_FORMAT_READ) { } else if (result == C.RESULT_FORMAT_READ) {
onFormatChanged(formatHolder); onFormatChanged(formatHolder);
} }
} }
ended = true;
} }
} }
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment